Skip to contentSkip to conversation

cmd: define CMD_DATA_SIZE when CONFIG_CMD_SETEXPR is selected

PATCH New Bartosz Golaszewski 2 participants 2 messages May 20, 2019 – Jun 15, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cmd: define CMD_DATA_SIZE when CONFIG_CMD_SETEXPR is selected

From: Bartosz Golaszewski <[email protected]>

The setexpr shell command calls cmd_get_data_size() which is only built when CMD_DATA_SIZE is defined. We need to define CMD_DATA_SIZE if CONFIG_CMD_SETEXPR is selected or the build will fail if no other command selecting this option is enabled.

---
 include/command.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/command.h +2 -1
index be74f6ac92..2bfee89df3 100644
@@ -109,7 +109,8 @@ int cmd_process_error(cmd_tbl_t *cmdtp, int err);
 #if defined(CONFIG_CMD_MEMORY) || \
 	defined(CONFIG_CMD_I2C) || \
 	defined(CONFIG_CMD_ITEST) || \
-	defined(CONFIG_CMD_PCI)
+	defined(CONFIG_CMD_PCI) || \
+	defined(CONFIG_CMD_SETEXPR)
 #define CMD_DATA_SIZE
 extern int cmd_get_data_size(char* arg, int default_size);
 #endif
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/1 cmd: define CMD_DATA_SIZE when CONFIG_CMD_SETEXPR is selected

Quoted 8 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

The setexpr shell command calls cmd_get_data_size() which is only built when CMD_DATA_SIZE is defined. We need to define CMD_DATA_SIZE if CONFIG_CMD_SETEXPR is selected or the build will fail if no other command selecting this option is enabled.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190615/1f17cfb1/attachment.sig>