Skip to contentSkip to conversation

Pull request: u-boot-spi/master

U-Boot NAK Jagan Teki 4 participants 8 messages May 20, 2019 – Jun 7, 2019

lore
Share & tools
lore

Jagan Teki

author
#0 lore raw

Hi Tom,

Please pull this PR.

Summary:
- mpc8xxx spi driver fixes (Mario)
- mpc8xxx spi dm conversion (Mario, Jagan)
- SPI DM Migration update (Jagan)

The following changes since commit 748198cb8d32d41bc35e6f492bac9948f339bece:

Revert "Makefile: Prioritize external dtb if defined" (2019-05-19 18:09:35 -0400)

are available in the Git repository at:

git://git.denx.de/u-boot-spi.git master

for you to fetch changes up to 93842e580cee40c9d3e70de625e4bd826a749e65:

dm: MIGRATION: Update migration status for SPI (2019-05-20 22:18:54 +0530)

----------------------------------------------------------------
Jagan Teki (2):
spi: mpc8xxx: Convert to DM
dm: MIGRATION: Update migration status for SPI

Mario Six (17):
spi: mpc8xxx: Use short type names
spi: mpc8xxx: Fix comments
spi: mpc8xxx: Rename camel-case variables
spi: mpc8xxx: Fix space after cast
spi: mpc8xxx: Fix function names in strings
spi: mpc8xxx: Replace defines with enums
spi: mpc8xxx: Use IO accessors
spi: mpc8xxx: Simplify if
spi: mpc8xxx: Get rid of is_read
spi: mpc8xxx: Simplify logic a bit
spi: mpc8xxx: Reduce scope of loop variables
spi: mpc8xxx: Make code more readable
spi: mpc8xxx: Rename variable
spi: mpc8xxx: Document LEN setting better
spi: mpc8xxx: Re-order transfer setup
spi: mpc8xxx: Fix if check
spi: mpc8xxx: Use get_timer

 doc/driver-model/MIGRATION.txt |   6 +-
 drivers/spi/Kconfig            |  10 +-
 drivers/spi/mpc8xxx_spi.c      | 279 +++++++++++++++++++++++++++--------------
 3 files changed, 194 insertions(+), 101 deletions(-)
#1 lore raw
Quoted 13 lines · Jagan Teki

Hi Tom,

Please pull this PR.

Summary:
- mpc8xxx spi driver fixes (Mario)
- mpc8xxx spi dm conversion (Mario, Jagan)
- SPI DM Migration update (Jagan)

The following changes since commit 748198cb8d32d41bc35e6f492bac9948f339bece:

Revert "Makefile: Prioritize external dtb if defined" (2019-05-19 18:09:35 -0400)

Quoted 8 lines

are available in the Git repository at:

git://git.denx.de/u-boot-spi.git master

for you to fetch changes up to 93842e580cee40c9d3e70de625e4bd826a749e65:

dm: MIGRATION: Update migration status for SPI (2019-05-20 22:18:54 +0530)

NAK:
powerpc: + ids8313
+(ids8313) cmd/built-in.o: In function `do_spi_xfer':
+(ids8313) build/../cmd/spi.c:53: undefined reference to spi_setup_slave' +(ids8313) build/../cmd/spi.c:60: undefined reference to spi_claim_bus' +(ids8313) build/../cmd/spi.c:63: undefined reference to spi_xfer' +(ids8313) build/../cmd/spi.c:80: undefined reference to spi_release_bus' +(ids8313) build/../cmd/spi.c:82: undefined reference to spi_free_slave' +(ids8313) common/built-in.o: In function jumptable_init':
+(ids8313) build/../include/_exports.h:56: undefined reference to spi_setup_slave' +(ids8313) build/../include/_exports.h:58: undefined reference to spi_free_slave' +(ids8313) build/../include/_exports.h:65: undefined reference to spi_claim_bus' +(ids8313) build/../include/_exports.h:66: undefined reference to spi_release_bus' +(ids8313) build/../include/_exports.h:67: undefined reference to `spi_xfer' +(ids8313) make[1]: *** [Makefile:1552: u-boot] Error 1
+(ids8313) make: *** [Makefile:148: sub-make] Error 2

Due to:
commit 96ff5503a543bee956c0f55f43c26a1f6a07f21a

Author: Jagan Teki <[email protected]>
Date:   Mon Apr 29 01:58:53 2019 +0530

spi: mpc8xxx: Convert to DM

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190521/2bea9145/attachment.sig>
author
#2 lore raw

Hi Mario,

Quoted 32 lines · Tom Rini
Quoted 13 lines · Jagan Teki

Hi Tom,

Please pull this PR.

Summary:
- mpc8xxx spi driver fixes (Mario)
- mpc8xxx spi dm conversion (Mario, Jagan)
- SPI DM Migration update (Jagan)

The following changes since commit 748198cb8d32d41bc35e6f492bac9948f339bece:

Revert "Makefile: Prioritize external dtb if defined" (2019-05-19 18:09:35 -0400)

Quoted 8 lines

are available in the Git repository at:

git://git.denx.de/u-boot-spi.git master

for you to fetch changes up to 93842e580cee40c9d3e70de625e4bd826a749e65:

dm: MIGRATION: Update migration status for SPI (2019-05-20 22:18:54 +0530)

NAK:

   powerpc:  +   ids8313
(quoted diff) +4 -0
+(ids8313) cmd/built-in.o: In function `do_spi_xfer':
+(ids8313) build/../cmd/spi.c:53: undefined reference to `spi_setup_slave'
+(ids8313) build/../cmd/spi.c:60: undefined reference to `spi_claim_bus'
+(ids8313) build/../cmd/spi.c:63: undefined reference to `spi_xfer'

Review

Quoted 10 lines
(quoted diff) +10 -0
+(ids8313) build/../cmd/spi.c:80: undefined reference to `spi_release_bus'
+(ids8313) build/../cmd/spi.c:82: undefined reference to `spi_free_slave'
+(ids8313) common/built-in.o: In function `jumptable_init':
+(ids8313) build/../include/_exports.h:56: undefined reference to `spi_setup_slave'
+(ids8313) build/../include/_exports.h:58: undefined reference to `spi_free_slave'
+(ids8313) build/../include/_exports.h:65: undefined reference to `spi_claim_bus'
+(ids8313) build/../include/_exports.h:66: undefined reference to `spi_release_bus'
+(ids8313) build/../include/_exports.h:67: undefined reference to `spi_xfer'
+(ids8313) make[1]: *** [Makefile:1552: u-boot] Error 1
+(ids8313) make: *** [Makefile:148: sub-make] Error 2

Any help?

#3 lore raw

(adding Heiko, since he's the maintainer of the board in question)

Quoted 40 lines · Jagan Teki

Hi Mario,

Quoted 36 lines · Tom Rini
Quoted 13 lines · Jagan Teki

Hi Tom,

Please pull this PR.

Summary:
- mpc8xxx spi driver fixes (Mario)
- mpc8xxx spi dm conversion (Mario, Jagan)
- SPI DM Migration update (Jagan)

The following changes since commit 748198cb8d32d41bc35e6f492bac9948f339bece:

Revert "Makefile: Prioritize external dtb if defined" (2019-05-19 18:09:35 -0400)

Quoted 8 lines

are available in the Git repository at:

git://git.denx.de/u-boot-spi.git master

for you to fetch changes up to 93842e580cee40c9d3e70de625e4bd826a749e65:

dm: MIGRATION: Update migration status for SPI (2019-05-20 22:18:54 +0530)

NAK:

   powerpc:  +   ids8313
(quoted diff) +9 -0
+(ids8313) cmd/built-in.o: In function `do_spi_xfer':
+(ids8313) build/../cmd/spi.c:53: undefined reference to `spi_setup_slave'
+(ids8313) build/../cmd/spi.c:60: undefined reference to `spi_claim_bus'
+(ids8313) build/../cmd/spi.c:63: undefined reference to `spi_xfer'
+(ids8313) build/../cmd/spi.c:80: undefined reference to `spi_release_bus'
+(ids8313) build/../cmd/spi.c:82: undefined reference to `spi_free_slave'
+(ids8313) common/built-in.o: In function `jumptable_init':
+(ids8313) build/../include/_exports.h:56: undefined reference to `spi_setup_slave'
+(ids8313) build/../include/_exports.h:58: undefined reference to `spi_free_slave'
Quoted 8 lines

Review

Quoted 6 lines
(quoted diff) +5 -0
+(ids8313) build/../include/_exports.h:65: undefined reference to `spi_claim_bus'
+(ids8313) build/../include/_exports.h:66: undefined reference to `spi_release_bus'
+(ids8313) build/../include/_exports.h:67: undefined reference to `spi_xfer'
+(ids8313) make[1]: *** [Makefile:1552: u-boot] Error 1
+(ids8313) make: *** [Makefile:148: sub-make] Error 2

Any help?

@Heiko: I'll post a minimal patch that starts DM conversion on ids8313; I used the mpc8313erdb tree from the Linux sources for now. No guarantees for functionality, but it does compile.

@Jagan: Could you rebase this series on the current master to pull in my MPC83xx DM updates, and then apply the previously mentioned ids8313 patch after Heiko gave his OK?

Thanks, and best regards,
Mario

#4 lore raw

Hello Mario,

Am 07.06.2019 um 09:51 schrieb Mario Six:

Quoted 3 lines

(adding Heiko, since he's the maintainer of the board in question)

On Fri, May 24, 2019 at 9:34 PM Jagan Teki <[email protected]> wrote:

Huch, missed this Email ...

Quoted 49 lines
Quoted 40 lines

Hi Mario,

Quoted 36 lines · Tom Rini
Quoted 13 lines · Jagan Teki

Hi Tom,

Please pull this PR.

Summary:
- mpc8xxx spi driver fixes (Mario)
- mpc8xxx spi dm conversion (Mario, Jagan)
- SPI DM Migration update (Jagan)

The following changes since commit 748198cb8d32d41bc35e6f492bac9948f339bece:

Revert "Makefile: Prioritize external dtb if defined" (2019-05-19 18:09:35 -0400)

Quoted 8 lines

are available in the Git repository at:

git://git.denx.de/u-boot-spi.git master

for you to fetch changes up to 93842e580cee40c9d3e70de625e4bd826a749e65:

dm: MIGRATION: Update migration status for SPI (2019-05-20 22:18:54 +0530)

NAK:

    powerpc:  +   ids8313
(quoted diff) +9 -0
+(ids8313) cmd/built-in.o: In function `do_spi_xfer':
+(ids8313) build/../cmd/spi.c:53: undefined reference to `spi_setup_slave'
+(ids8313) build/../cmd/spi.c:60: undefined reference to `spi_claim_bus'
+(ids8313) build/../cmd/spi.c:63: undefined reference to `spi_xfer'
+(ids8313) build/../cmd/spi.c:80: undefined reference to `spi_release_bus'
+(ids8313) build/../cmd/spi.c:82: undefined reference to `spi_free_slave'
+(ids8313) common/built-in.o: In function `jumptable_init':
+(ids8313) build/../include/_exports.h:56: undefined reference to `spi_setup_slave'
+(ids8313) build/../include/_exports.h:58: undefined reference to `spi_free_slave'
Quoted 8 lines

Review

Quoted 6 lines
(quoted diff) +5 -0
+(ids8313) build/../include/_exports.h:65: undefined reference to `spi_claim_bus'
+(ids8313) build/../include/_exports.h:66: undefined reference to `spi_release_bus'
+(ids8313) build/../include/_exports.h:67: undefined reference to `spi_xfer'
+(ids8313) make[1]: *** [Makefile:1552: u-boot] Error 1
+(ids8313) make: *** [Makefile:148: sub-make] Error 2

Any help?

Quoted 3 lines

@Heiko: I'll post a minimal patch that starts DM conversion on ids8313; I used the mpc8313erdb tree from the Linux sources for now. No guarantees for functionality, but it does compile.

Just saw this patch .. it is really a fast shot :-P

I just wrote an EMail to the customer, if we should remove the board from mainline (or convert it).

Quoted 3 lines

@Jagan: Could you rebase this series on the current master to pull in my MPC83xx DM updates, and then apply the previously mentioned ids8313 patch after Heiko gave his OK?

As it blocks spi patches ... Isn,t it better we remove SPI functionality from the ids8313 board instead of adding a DTS which does not really fit?

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#5 lore raw

Hi Heiko,

Quoted 68 lines · Heiko Schocher

Hello Mario,

Am 07.06.2019 um 09:51 schrieb Mario Six:

Quoted 3 lines

(adding Heiko, since he's the maintainer of the board in question)

On Fri, May 24, 2019 at 9:34 PM Jagan Teki <[email protected]> wrote:

Huch, missed this Email ...

Quoted 49 lines
Quoted 40 lines

Hi Mario,

Quoted 36 lines · Tom Rini
Quoted 13 lines · Jagan Teki

Hi Tom,

Please pull this PR.

Summary:
- mpc8xxx spi driver fixes (Mario)
- mpc8xxx spi dm conversion (Mario, Jagan)
- SPI DM Migration update (Jagan)

The following changes since commit 748198cb8d32d41bc35e6f492bac9948f339bece:

Revert "Makefile: Prioritize external dtb if defined" (2019-05-19 18:09:35 -0400)

Quoted 8 lines

are available in the Git repository at:

git://git.denx.de/u-boot-spi.git master

for you to fetch changes up to 93842e580cee40c9d3e70de625e4bd826a749e65:

dm: MIGRATION: Update migration status for SPI (2019-05-20 22:18:54 +0530)

NAK:

    powerpc:  +   ids8313
(quoted diff) +9 -0
+(ids8313) cmd/built-in.o: In function `do_spi_xfer':
+(ids8313) build/../cmd/spi.c:53: undefined reference to `spi_setup_slave'
+(ids8313) build/../cmd/spi.c:60: undefined reference to `spi_claim_bus'
+(ids8313) build/../cmd/spi.c:63: undefined reference to `spi_xfer'
+(ids8313) build/../cmd/spi.c:80: undefined reference to `spi_release_bus'
+(ids8313) build/../cmd/spi.c:82: undefined reference to `spi_free_slave'
+(ids8313) common/built-in.o: In function `jumptable_init':
+(ids8313) build/../include/_exports.h:56: undefined reference to `spi_setup_slave'
+(ids8313) build/../include/_exports.h:58: undefined reference to `spi_free_slave'
Quoted 8 lines

Review

Quoted 6 lines
(quoted diff) +5 -0
+(ids8313) build/../include/_exports.h:65: undefined reference to `spi_claim_bus'
+(ids8313) build/../include/_exports.h:66: undefined reference to `spi_release_bus'
+(ids8313) build/../include/_exports.h:67: undefined reference to `spi_xfer'
+(ids8313) make[1]: *** [Makefile:1552: u-boot] Error 1
+(ids8313) make: *** [Makefile:148: sub-make] Error 2

Any help?

Quoted 3 lines

@Heiko: I'll post a minimal patch that starts DM conversion on ids8313; I used the mpc8313erdb tree from the Linux sources for now. No guarantees for functionality, but it does compile.

Just saw this patch .. it is really a fast shot :-P

I just wrote an EMail to the customer, if we should remove the board from mainline (or convert it).

Quoted 7 lines
Quoted 3 lines

@Jagan: Could you rebase this series on the current master to pull in my MPC83xx DM updates, and then apply the previously mentioned ids8313 patch after Heiko gave his OK?

As it blocks spi patches ... Isn,t it better we remove SPI functionality from the ids8313 board instead of adding a DTS which does not really fit?

That would be the alternative, of course. If you do want to go forward with removing the board, then I'm all for disabling the SPI support until we know more, of course.

Do you want to prepare a patch for the SPI removal, or should I do it?

Quoted 3 lines

bye,
Heiko

Best regards,
Mario

#6 lore raw

Hello Mario,

Am 07.06.2019 um 11:10 schrieb Mario Six:

Quoted 75 lines

Hi Heiko,

Quoted 72 lines · Heiko Schocher

Hello Mario,

Am 07.06.2019 um 09:51 schrieb Mario Six:

Quoted 3 lines

(adding Heiko, since he's the maintainer of the board in question)

On Fri, May 24, 2019 at 9:34 PM Jagan Teki <[email protected]> wrote:

Huch, missed this Email ...

Quoted 49 lines
Quoted 40 lines

Hi Mario,

Quoted 36 lines · Tom Rini
Quoted 13 lines · Jagan Teki

Hi Tom,

Please pull this PR.

Summary:
- mpc8xxx spi driver fixes (Mario)
- mpc8xxx spi dm conversion (Mario, Jagan)
- SPI DM Migration update (Jagan)

The following changes since commit 748198cb8d32d41bc35e6f492bac9948f339bece:

    Revert "Makefile: Prioritize external dtb if defined" (2019-05-19 18:09:35 -0400)
Quoted 8 lines

are available in the Git repository at:

git://git.denx.de/u-boot-spi.git master

for you to fetch changes up to 93842e580cee40c9d3e70de625e4bd826a749e65:

    dm: MIGRATION: Update migration status for SPI (2019-05-20 22:18:54 +0530)

NAK:

     powerpc:  +   ids8313
(quoted diff) +9 -0
+(ids8313) cmd/built-in.o: In function `do_spi_xfer':
+(ids8313) build/../cmd/spi.c:53: undefined reference to `spi_setup_slave'
+(ids8313) build/../cmd/spi.c:60: undefined reference to `spi_claim_bus'
+(ids8313) build/../cmd/spi.c:63: undefined reference to `spi_xfer'
+(ids8313) build/../cmd/spi.c:80: undefined reference to `spi_release_bus'
+(ids8313) build/../cmd/spi.c:82: undefined reference to `spi_free_slave'
+(ids8313) common/built-in.o: In function `jumptable_init':
+(ids8313) build/../include/_exports.h:56: undefined reference to `spi_setup_slave'
+(ids8313) build/../include/_exports.h:58: undefined reference to `spi_free_slave'
Quoted 8 lines

Review

Quoted 6 lines
(quoted diff) +5 -0
+(ids8313) build/../include/_exports.h:65: undefined reference to `spi_claim_bus'
+(ids8313) build/../include/_exports.h:66: undefined reference to `spi_release_bus'
+(ids8313) build/../include/_exports.h:67: undefined reference to `spi_xfer'
+(ids8313) make[1]: *** [Makefile:1552: u-boot] Error 1
+(ids8313) make: *** [Makefile:148: sub-make] Error 2

Any help?

Quoted 3 lines

@Heiko: I'll post a minimal patch that starts DM conversion on ids8313; I used the mpc8313erdb tree from the Linux sources for now. No guarantees for functionality, but it does compile.

Just saw this patch .. it is really a fast shot :-P

I just wrote an EMail to the customer, if we should remove the board from mainline (or convert it).

Quoted 3 lines

@Jagan: Could you rebase this series on the current master to pull in my MPC83xx DM updates, and then apply the previously mentioned ids8313 patch after Heiko gave his OK?

Quoted 8 lines
Quoted 3 lines

As it blocks spi patches ... Isn,t it better we remove SPI functionality from the ids8313 board instead of adding a DTS which does not really fit?

That would be the alternative, of course. If you do want to go forward with removing the board, then I'm all for disabling the SPI support until we know more, of course.

Do you want to prepare a patch for the SPI removal, or should I do it?

If you can do it, that would be great!

Many thanks!

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#7 lore raw

Hi Heiko,

Quoted 82 lines · Heiko Schocher

Hello Mario,

Am 07.06.2019 um 11:10 schrieb Mario Six:

Quoted 78 lines

Hi Heiko,

Quoted 75 lines · Heiko Schocher

Hello Mario,

Am 07.06.2019 um 09:51 schrieb Mario Six:

Quoted 3 lines

(adding Heiko, since he's the maintainer of the board in question)

On Fri, May 24, 2019 at 9:34 PM Jagan Teki <[email protected]> wrote:

Huch, missed this Email ...

Quoted 49 lines
Quoted 40 lines

Hi Mario,

Quoted 36 lines · Tom Rini
Quoted 13 lines · Jagan Teki

Hi Tom,

Please pull this PR.

Summary:
- mpc8xxx spi driver fixes (Mario)
- mpc8xxx spi dm conversion (Mario, Jagan)
- SPI DM Migration update (Jagan)

The following changes since commit 748198cb8d32d41bc35e6f492bac9948f339bece:

    Revert "Makefile: Prioritize external dtb if defined" (2019-05-19 18:09:35 -0400)
Quoted 8 lines

are available in the Git repository at:

git://git.denx.de/u-boot-spi.git master

for you to fetch changes up to 93842e580cee40c9d3e70de625e4bd826a749e65:

    dm: MIGRATION: Update migration status for SPI (2019-05-20 22:18:54 +0530)

NAK:

     powerpc:  +   ids8313
(quoted diff) +9 -0
+(ids8313) cmd/built-in.o: In function `do_spi_xfer':
+(ids8313) build/../cmd/spi.c:53: undefined reference to `spi_setup_slave'
+(ids8313) build/../cmd/spi.c:60: undefined reference to `spi_claim_bus'
+(ids8313) build/../cmd/spi.c:63: undefined reference to `spi_xfer'
+(ids8313) build/../cmd/spi.c:80: undefined reference to `spi_release_bus'
+(ids8313) build/../cmd/spi.c:82: undefined reference to `spi_free_slave'
+(ids8313) common/built-in.o: In function `jumptable_init':
+(ids8313) build/../include/_exports.h:56: undefined reference to `spi_setup_slave'
+(ids8313) build/../include/_exports.h:58: undefined reference to `spi_free_slave'
Quoted 8 lines

Review

Quoted 6 lines
(quoted diff) +5 -0
+(ids8313) build/../include/_exports.h:65: undefined reference to `spi_claim_bus'
+(ids8313) build/../include/_exports.h:66: undefined reference to `spi_release_bus'
+(ids8313) build/../include/_exports.h:67: undefined reference to `spi_xfer'
+(ids8313) make[1]: *** [Makefile:1552: u-boot] Error 1
+(ids8313) make: *** [Makefile:148: sub-make] Error 2

Any help?

Quoted 3 lines

@Heiko: I'll post a minimal patch that starts DM conversion on ids8313; I used the mpc8313erdb tree from the Linux sources for now. No guarantees for functionality, but it does compile.

Just saw this patch .. it is really a fast shot :-P

I just wrote an EMail to the customer, if we should remove the board from mainline (or convert it).

Quoted 3 lines

@Jagan: Could you rebase this series on the current master to pull in my MPC83xx DM updates, and then apply the previously mentioned ids8313 patch after Heiko gave his OK?

As it blocks spi patches ... Isn,t it better we remove SPI functionality from the ids8313 board instead of adding a DTS which does not really fit?

Quoted 8 lines
Quoted 5 lines

That would be the alternative, of course. If you do want to go forward with removing the board, then I'm all for disabling the SPI support until we know more, of course.

Do you want to prepare a patch for the SPI removal, or should I do it?

If you can do it, that would be great!

Sure, one patch coming up...

Quoted 5 lines

Many thanks!

bye,
Heiko

Best regards,
Mario