Skip to contentSkip to conversation

drm/msm/mdp5: Fix mdp5_cfg_init error return

PATCH RESEND New Jeffrey Hugo 1 participant 1 message May 21, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 drm/msm/mdp5: Fix mdp5_cfg_init error return

If mdp5_cfg_init fails because of an unknown major version, a null pointer dereference occurs. This is because the caller of init expects error pointers, but init returns NULL on error. Fix this by returning the expected values on error.

Fixes 2e362e1772b8 (drm/msm/mdp5: introduce mdp5_cfg module)
---
 drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c +1 -1
index ea8f7d7daf7f..52e23780fce1 100644
@@ -721,7 +721,7 @@ struct mdp5_cfg_handler *mdp5_cfg_init(struct mdp5_kms *mdp5_kms,
 	if (cfg_handler)
 		mdp5_cfg_destroy(cfg_handler);
 
-	return NULL;
+	return ERR_PTR(ret);
 }
 
 static struct mdp5_cfg_platform *mdp5_get_config(struct platform_device *dev)
Signature · 1 line
2.17.1