net: stmmac: fix reset gpio free missing
Subsystems (4)
PATCH 1/1 net: stmmac: fix reset gpio free missing
Commit 984203ceff27 ("net: stmmac: mdio: remove reset gpio free") removed the reset gpio free, when the driver is unbinded or rmmod, we miss the gpio free.
This patch uses managed API to request the reset gpio, so that the gpio could be freed properly.
Signed-off-by Jisheng Zhang <[email protected]>
Fixes 984203ceff27 ("net: stmmac: mdio: remove reset gpio free")
--- drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c +2 -1
@@ -267,7 +267,8 @@ int stmmac_mdio_reset(struct mii_bus *bus)of_property_read_u32_array (np,"snps,reset-delays-us" , data->delays,3 ); -if (gpio_request (data->reset_gpio,"mdio-reset" )) +if (devm_gpio_request (priv->device, data->reset_gpio, +"mdio-reset" ))return 0 ; }
Signature · 1 line
2.20.1
From: Jisheng Zhang <[email protected]>
Date: Wed, 22 May 2019 10:05:09 +0000
Quoted 9 lines
Commit
984203ceff27("net: stmmac: mdio: remove reset gpio free") removed the reset gpio free, when the driver is unbinded or rmmod, we miss the gpio free.This patch uses managed API to request the reset gpio, so that the gpio could be freed properly.
Signed-off-by Jisheng Zhang <[email protected]>Fixes 984203ceff27 ("net: stmmac: mdio: remove reset gpio free")
Please put the Fixes: tag first in the list of tags in the future.
Applied, thank you.