lib/igt_audio: fix uninitialized variable

PATCH In review Simon Ser 3 participants 4 messages May 23, 2019 – May 24, 2019 Library code

lore

Share & tools

lore

Simon Ser

author

2019-05-23 10:49 UTC #0 lore raw

PATCH 1/1 lib/igt_audio: fix uninitialized variable

Seems like I'm not used to the C89 style yet, and ASan caught it but with a completely unrelated stack trace.

Signed-off-by Simon Ser <[email protected]>

---
 lib/igt_audio.c | 1 +
 1 file changed, 1 insertion(+)

lib/igt_audio.c +1 -0

index 07935e660c5a..376e04ba6ed6 100644
@@ -205,6 +205,7 @@ static size_t audio_signal_count_freqs(struct audio_signal *signal, int channel)
 	size_t n, i;
 	struct audio_signal_freq *freq;
 
+	n = 0;
 	for (i = 0; i < signal->freqs_count; i++) {
 		freq = &signal->freqs[i];
 		if (freq->channel < 0 || freq->channel == channel)

--
2.21.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2019-05-23 12:08 UTC #1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for lib/igt_audio: fix uninitialized variable

== Series Details ==

Series: lib/igt_audio: fix uninitialized variable
URL : https://patchwork.freedesktop.org/series/61023/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6129 -> IGTPW_3044
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/61023/revisions/1/mbox/

Known issues
------------

Here are the changes found in IGTPW_3044 that come from known issues:

### IGT changes ###

#### Possible fixes ####

* igt@gem_ctx_create@basic-files:
- {fi-icl-dsi}: [INCOMPLETE][1] ([fdo#107713] / [fdo#109100]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/fi-icl-dsi/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/fi-icl-dsi/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [DMESG-WARN][3] ([fdo#102614]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/fi-hsw-peppy/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/fi-hsw-peppy/igt@[email protected]

#### Warnings ####

* igt@i915_selftest@live_hangcheck:
- fi-apl-guc: [INCOMPLETE][5] ([fdo#103927] / [fdo#110624]) -> [FAIL][6] ([fdo#110623])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/fi-apl-guc/igt@i915_selftest@live_hangcheck.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/fi-apl-guc/igt@i915_selftest@live_hangcheck.html

* igt@runner@aborted:
- fi-apl-guc: [FAIL][7] ([fdo#110624]) -> [FAIL][8] ([fdo#110622])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/fi-apl-guc/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/fi-apl-guc/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (53 -> 45)
------------------------------

Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-pnv-d510 fi-byt-clapper fi-bdw-samus

Build changes
-------------

* IGT: IGT_5007 -> IGTPW_3044

CI_DRM_6129: e5d5516eb302ea0f83ea3d9014385f88ed850d53 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3044: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/
IGT_5007: ed4a5515109ee83556f505a9519e33acd9518279 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2019-05-24 12:20 UTC #2 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for lib/igt_audio: fix uninitialized variable

In reply to Simon Ser

== Series Details ==

Series: lib/igt_audio: fix uninitialized variable
URL : https://patchwork.freedesktop.org/series/61023/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6129_full -> IGTPW_3044_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/61023/revisions/1/mbox/

Known issues
------------

Here are the changes found in IGTPW_3044_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_tiled_swapping@non-threaded:
- shard-hsw: [PASS][1] -> [FAIL][2] ([fdo#108686])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/shard-hsw8/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/shard-hsw6/igt@[email protected]

* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/shard-apl2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/shard-apl1/igt@[email protected]

* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: [PASS][5] -> [FAIL][6] ([fdo#105767])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/shard-hsw4/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/shard-hsw8/igt@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-glk: [PASS][7] -> [FAIL][8] ([fdo#105363])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/shard-glk9/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/shard-glk9/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-mmap-cpu:
- shard-hsw: [PASS][9] -> [SKIP][10] ([fdo#109271]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/shard-hsw4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-mmap-cpu.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/shard-hsw5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-mmap-cpu.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#103167])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: [PASS][13] -> [FAIL][14] ([fdo#103166])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/shard-iclb3/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/shard-iclb8/igt@[email protected]

* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109441]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_gtt.html

#### Possible fixes ####

* igt@gem_exec_whisper@normal:
- shard-glk: [INCOMPLETE][17] ([fdo#103359] / [k.org#198133]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/shard-glk5/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/shard-glk2/igt@[email protected]

* igt@i915_suspend@debugfs-reader:
- shard-apl: [DMESG-WARN][19] ([fdo#108566]) -> [PASS][20] +4 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/shard-apl6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/shard-apl8/igt@[email protected]

* {igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding}:
- shard-apl: [INCOMPLETE][21] ([fdo#103927]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/shard-apl1/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/shard-apl4/igt@[email protected]

* igt@kms_cursor_legacy@all-pipes-single-bo:
- shard-snb: [INCOMPLETE][23] ([fdo#105411]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/shard-snb1/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/shard-snb6/igt@[email protected]

* igt@kms_flip@2x-plain-flip-interruptible:
- shard-hsw: [SKIP][25] ([fdo#109271]) -> [PASS][26] +25 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/shard-hsw5/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/shard-hsw8/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-modesetfrombusy:
- shard-glk: [FAIL][27] ([fdo#103167]) -> [PASS][28] +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/shard-glk5/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/shard-glk2/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-tilingchange:
- shard-apl: [FAIL][29] ([fdo#103167]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/shard-apl6/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/shard-apl7/igt@[email protected]
- shard-kbl: [FAIL][31] ([fdo#103167]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/shard-kbl1/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/shard-kbl7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-iclb: [FAIL][33] ([fdo#103167]) -> [PASS][34] +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html

* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][35] ([fdo#108341]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/shard-iclb1/igt@kms_psr@no_drrs.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/shard-iclb7/igt@kms_psr@no_drrs.html

#### Warnings ####

* igt@gem_ctx_isolation@rcs0-s3:
- shard-apl: [DMESG-WARN][37] ([fdo#108566]) -> [WARN][38] ([fdo#110738])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/shard-apl4/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/shard-apl7/igt@[email protected]

* igt@gem_mmap_gtt@forked-big-copy-xy:
- shard-iclb: [TIMEOUT][39] ([fdo#109673]) -> [INCOMPLETE][40] ([fdo#107713] / [fdo#109100])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/shard-iclb2/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/shard-iclb1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-glk: [FAIL][41] ([fdo#108145]) -> [INCOMPLETE][42] ([fdo#103359] / [k.org#198133])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6129/shard-glk9/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3044/shard-glk6/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (10 -> 6)
------------------------------

Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005

Build changes
-------------

* IGT: IGT_5007 -> IGTPW_3044
* Piglit: piglit_4509 -> None

== Logs ==

Arkadiusz Hiler

Reviewed-by on v1 1/1

2019-05-24 13:52 UTC #3 lore raw

In reply to Simon Ser

Quoted 4 lines · Simon Ser

Seems like I'm not used to the C89 style yet, and ASan caught it but with a completely unrelated stack trace.
Signed-off-by Simon Ser <[email protected]>

Reviewed-by Arkadiusz Hiler <[email protected]>

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev