Skip to contentSkip to conversation

package_manager: add help packages based on languages selected in IMAGE_LINGUAS

PATCH In review Andreas Müller 3 participants 5 messages May 23, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package_manager: add help packages based on languages selected in IMAGE_LINGUAS

This is the one-line mentioned in [1].

[1] http://lists.openembedded.org/pipermail/openembedded-devel/2019-May/199769.html

---
 meta/lib/oe/package_manager.py | 1 +
 1 file changed, 1 insertion(+)
meta/lib/oe/package_manager.py +1 -0
index 2835c1ddf8..bd2432f6d3 100644
@@ -566,6 +566,7 @@ class PackageManager(object, metaclass=ABCMeta):
 
             for lang in split_linguas:
                 globs += " *-locale-%s" % lang
+                globs += " *-help-%s" % lang
 
         if globs is None:
             return
Signature · 1 line
2.20.1
#1 lore raw

Why -help- and not -doc?

Ross

Quoted 30 lines · Andreas Müller

This is the one-line mentioned in [1].

[1] http://lists.openembedded.org/pipermail/openembedded-devel/2019-May/199769.html

---
 meta/lib/oe/package_manager.py | 1 +
 1 file changed, 1 insertion(+)
meta/lib/oe/package_manager.py +1 -1
index 2835c1ddf8..bd2432f6d3 100644
@@ -566,6 +566,7 @@ class PackageManager(object, metaclass=ABCMeta):
 
             for lang in split_linguas:
                 globs += " *-locale-%s" % lang
+                globs += " *-help-%s" % lang
 
         if globs is None:
             return
--

2.20.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#2 lore raw
Quoted 3 lines · Ross

Why -help- and not -doc?

Because there are help files installed in 'help' directory and displayed by a help browser.

Andreas

#3 lore raw
Quoted 4 lines · Andreas Müller
Quoted 2 lines

Why -help- and not -doc?

Because there are help files installed in 'help' directory and displayed by a help browser.

Sounds a lot like documentation to me...

#4 lore raw
In reply to Burton, Ross
Quoted 1 line · Ross

Why -help- and not -doc?

I was thinking it may make better sense to have a variable that DEFAULTS to "*-locale-%s", but can be extended to have other locale based files.. Such as a *-doc-%s, or *-man-%s, etc...

(We will -never- get all of the possible ones, unless they all have 'locale' in the names or similar.)

--Mark

Quoted 33 lines

Ross

Quoted 30 lines · Andreas Müller

This is the one-line mentioned in [1].

[1] http://lists.openembedded.org/pipermail/openembedded-devel/2019-May/199769.html

---
 meta/lib/oe/package_manager.py | 1 +
 1 file changed, 1 insertion(+)
meta/lib/oe/package_manager.py +1 -1
index 2835c1ddf8..bd2432f6d3 100644
@@ -566,6 +566,7 @@ class PackageManager(object, metaclass=ABCMeta):
 
             for lang in split_linguas:
                 globs += " *-locale-%s" % lang
+                globs += " *-help-%s" % lang
 
         if globs is None:
             return
--

2.20.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core