Skip to contentSkip to conversation

staging: ks7010: Remove initialisation

PATCH Superseded Nishka Dasgupta 2 participants 4 messages May 24, 2019 Staging

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: ks7010: Remove initialisation

As the initial value of the return variable result is never used, it can be removed.
Issue found with Coccinelle.

---
 drivers/staging/ks7010/ks7010_sdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/ks7010/ks7010_sdio.c +1 -1
index 74551eb717fc..4b379542ecd5 100644
@@ -380,7 +380,7 @@ int ks_wlan_hw_tx(struct ks_wlan_private *priv, void *p, unsigned long size,
 					   struct sk_buff *skb),
 		  struct sk_buff *skb)
 {
-	int result = 0;
+	int result;
 	struct hostif_hdr *hdr;
 
 	hdr = (struct hostif_hdr *)p;
Signature · 1 line
2.19.1
maintainer
#1 lore raw
Quoted 8 lines · Nishka Dasgupta

As the initial value of the return variable result is never used, it can be removed.
Issue found with Coccinelle.

---
 drivers/staging/ks7010/ks7010_sdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Didn't you already send this?

And please run a spell-checker on your subject line when you resend this :)

thanks,

greg k-h

#2 lore raw
Quoted 11 lines · Greg KH
Quoted 8 lines · Nishka Dasgupta

As the initial value of the return variable result is never used, it can be removed.
Issue found with Coccinelle.

---
  drivers/staging/ks7010/ks7010_sdio.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Didn't you already send this?

I sent two patches about removing initialisation in ks7010 today, but I couldn't make it a patch series because the different files had different maintainers. I don't think I've sent this patch before, but it's possible I made a mistake because my local tree has not been the best organised lately. I apologise for the confusion.

Quoted 2 lines

And please run a spell-checker on your subject line when you resend this :)

Is this about "initialise" (and now also "organised", "apologise", etc)? As far as I'm aware whether the word ends in "-ise"/"-ize" depends on local varieties of English, so I went with the variety I'm more used to. Should I stick with American/Canadian spelling variants (including "-or" over "-our" etc) from now on?

Nishka

Quoted 5 lines

thanks,

greg k-h

maintainer
#3 lore raw
Quoted 11 lines · Nishka Dasgupta
Quoted 10 lines · Greg KH
Quoted 8 lines · Nishka Dasgupta

As the initial value of the return variable result is never used, it can be removed.
Issue found with Coccinelle.

---
  drivers/staging/ks7010/ks7010_sdio.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 8 lines
Quoted 1 line

Didn't you already send this?

I sent two patches about removing initialisation in ks7010 today, but I couldn't make it a patch series because the different files had different maintainers. I don't think I've sent this patch before, but it's possible I made a mistake because my local tree has not been the best organised lately. I apologise for the confusion.

I saw two patches with the same subject line, if I messed up, please resend.

Quoted 8 lines
Quoted 2 lines

And please run a spell-checker on your subject line when you resend this :)

Is this about "initialise" (and now also "organised", "apologise", etc)? As far as I'm aware whether the word ends in "-ise"/"-ize" depends on local varieties of English, so I went with the variety I'm more used to. Should I stick with American/Canadian spelling variants (including "-or" over "-our" etc) from now on?

Ah, didn't realize that was a valid spelling, sorry.

greg k-h