Skip to contentSkip to conversation

arm: exynos: odroid: Fix the confict scripaddr extra env setting

PATCH New Anand Moon 2 participants 4 messages May 24, 2019 – Jun 3, 2019

lore
Share & tools
lore

Anand Moon

author
#0 lore raw

PATCH 1/1 arm: exynos: odroid: Fix the confict scripaddr extra env setting

Fix the confict of scriptaddr address with ramdisk_addr_r used in EXTRA_ENV_SETTINGS.

---
Prevoius patch:

[0] https://marc.info/?l=u-boot&m=155411969503169&w=2

changes from prevoius changes:
drop: "pxefile_addr_r=0x51000000\0" \

U-Boot 2019.07-rc2-00199-g40920bdecc4-dirty (May 24 2019 - 06:39:42 +0000)

CPU:   Exynos4412 @ 1 GHz
Model: Odroid based on Exynos4412
Type:  u3
DRAM:  2 GiB
LDO20 at VDDQ_EMMC_1.8V: set 1800000 uV; enabling
LDO22 at VDDQ_EMMC_2.8V: set 2800000 uV; enabling
LDO21 at TFLASH_2.8V: set 2800000 uV; enabling
MMC:   SAMSUNG SDHCI: 1, EXYNOS DWMMC: 0

Loading Environment from MMC... Card did not respond to voltage select! *** Warning - No block device, using default environment

Net:   No ethernet found.
Hit any key to stop autoboot:  0

switch to partitions #0, OK
mmc1 is current device
Scanning mmc 1:1...
Found U-Boot script /boot/boot.scr
775 bytes read in 5 ms (151.4 KiB/s)
6688712 bytes read in 229 ms (27.9 MiB/s) 72645 bytes read in 41 ms (1.7 MiB/s)
6611360 bytes read in 227 ms (27.8 MiB/s) Kernel image @ 0x41000000 [ 0x000000 - 0x660fc8 ]
Booting using the fdt blob at 0x40800000 Loading Ramdisk to 4f9b1000, end 4ffff1a0 ... OK Loading Device Tree to 4f99c000, end 4f9b0bc4 ... OK

---
 include/configs/odroid.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/odroid.h +1 -1
index 9f2d43e3fa3..04bed6b0160 100644
@@ -168,7 +168,7 @@
 	"consoleoff=set console console=ram; save; reset\0" \
 	"initrdname=uInitrd\0" \
 	"ramdisk_addr_r=0x42000000\0" \
-	"scriptaddr=0x42000000\0" \
+	"scriptaddr=0x50000000\0" \
 	"fdt_addr_r=0x40800000\0" \
 	"kernel_addr_r=0x41000000\0" \
 	BOOTENV
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/1 arm: exynos: odroid: Fix the confict scripaddr extra env setting

Quoted 5 lines · Anand Moon

Fix the confict of scriptaddr address with ramdisk_addr_r used in EXTRA_ENV_SETTINGS.

My comment from previous patch stays valid:
"... but there is no conflict in the first place. These addresses are not used in the same time."

The patch does not harm but it is not correctly explained. There is no issue so it is not a fix.

Best regards,
Krzysztof

Quoted 56 lines

---
Prevoius patch:

[0] https://marc.info/?l=u-boot&m=155411969503169&w=2

changes from prevoius changes:
drop: "pxefile_addr_r=0x51000000\0" \

U-Boot 2019.07-rc2-00199-g40920bdecc4-dirty (May 24 2019 - 06:39:42 +0000)

CPU:   Exynos4412 @ 1 GHz
Model: Odroid based on Exynos4412
Type:  u3
DRAM:  2 GiB
LDO20 at VDDQ_EMMC_1.8V: set 1800000 uV; enabling
LDO22 at VDDQ_EMMC_2.8V: set 2800000 uV; enabling
LDO21 at TFLASH_2.8V: set 2800000 uV; enabling
MMC:   SAMSUNG SDHCI: 1, EXYNOS DWMMC: 0

Loading Environment from MMC... Card did not respond to voltage select! *** Warning - No block device, using default environment

Net:   No ethernet found.
Hit any key to stop autoboot:  0

switch to partitions #0, OK
mmc1 is current device
Scanning mmc 1:1...
Found U-Boot script /boot/boot.scr
775 bytes read in 5 ms (151.4 KiB/s)
6688712 bytes read in 229 ms (27.9 MiB/s) 72645 bytes read in 41 ms (1.7 MiB/s)
6611360 bytes read in 227 ms (27.8 MiB/s) Kernel image @ 0x41000000 [ 0x000000 - 0x660fc8 ]
Booting using the fdt blob at 0x40800000 Loading Ramdisk to 4f9b1000, end 4ffff1a0 ... OK Loading Device Tree to 4f99c000, end 4f9b0bc4 ... OK

---
 include/configs/odroid.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/odroid.h +1 -2
index 9f2d43e3fa3..04bed6b0160 100644
@@ -168,7 +168,7 @@
        "consoleoff=set console console=ram; save; reset\0" \
        "initrdname=uInitrd\0" \
        "ramdisk_addr_r=0x42000000\0" \
-       "scriptaddr=0x42000000\0" \
+       "scriptaddr=0x50000000\0" \
        "fdt_addr_r=0x40800000\0" \
        "kernel_addr_r=0x41000000\0" \
        BOOTENV
--

2.21.0

author
#2 lore raw

PATCH 1/1 arm: exynos: odroid: Fix the confict scripaddr extra env setting

Hi Krzysztof,

Quoted 12 lines · Krzysztof Kozlowski
Quoted 5 lines · Anand Moon

Fix the confict of scriptaddr address with ramdisk_addr_r used in EXTRA_ENV_SETTINGS.

My comment from previous patch stays valid:
"... but there is no conflict in the first place. These addresses are not used in the same time."

Quoted 5 lines

The patch does not harm but it is not correctly explained. There is no issue so it is not a fix.

Best regards,
Krzysztof

Most of the time we use custom boot.scr for loading zImage and dtb, but some how on ARCH Linux it tried to load from this EXTRA_ENV script.

Ok it's not a FIX, but still we need have different load address for script (boot.scr) to loaded.
How about change the subject and commit message to below.

"update the scriptaddr address to load from different address used in EXTRA_ENV_SETTINGS."

Best Regards
-Anand

#3 lore raw

PATCH 1/1 arm: exynos: odroid: Fix the confict scripaddr extra env setting

Quoted 19 lines · Anand Moon

Hi Krzysztof,

Quoted 15 lines · Krzysztof Kozlowski
Quoted 5 lines · Anand Moon

Fix the confict of scriptaddr address with ramdisk_addr_r used in EXTRA_ENV_SETTINGS.

My comment from previous patch stays valid:
"... but there is no conflict in the first place. These addresses are not used in the same time."

The patch does not harm but it is not correctly explained. There is no issue so it is not a fix.

Quoted 8 lines
Quoted 2 lines

Best regards,
Krzysztof

Most of the time we use custom boot.scr for loading zImage and dtb, but some how on ARCH Linux it tried to load from this EXTRA_ENV script.

Ok it's not a FIX, but still we need have different load address for script (boot.scr) to loaded.

I am not that sure that you need the different address. I guess the boot.scr is loaded first and parsed/sourced entirely. Then additional commands are executed (which are already in env), so ramdisk can be loaded under the same address. However there is no problem of changing the address... just reflect it in commit message.

Best regards,
Krzysztof

Quoted 7 lines

How about change the subject and commit message to below.

"update the scriptaddr address to load from different address used in EXTRA_ENV_SETTINGS."

Best Regards
-Anand