Skip to contentSkip to conversation

imx: Select the pinctrl drivers when DM is used

PATCH New Fabio Estevam 3 participants 4 messages May 24, 2019 – Jun 5, 2019 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 imx: Select the pinctrl drivers when DM is used

When using device model it is required to select the pinctrl drivers so that the pins can be properly configured via devicetree.

mx6sabreauto board is an example of a target that uses DM and does not select the pinctrl drivers.

Instead of doing the pinctrl driver selection in each individual defconfig file, select it at SoC level when DM is used.

---
 arch/arm/Kconfig | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/Kconfig +8 -0
index efb9aab390..4c361c9a1d 100644
@@ -787,6 +787,8 @@ config ARCH_MX31
 config ARCH_MX7ULP
 	bool "NXP MX7ULP"
 	select CPU_V7A
+	select PINCTRL if DM
+	select PINCTRL_IMX7ULP if DM
 	select ROM_UNIFIED_SECTIONS
 	imply MXC_GPIO
 
@@ -795,6 +797,8 @@ config ARCH_MX7
 	select ARCH_MISC_INIT
 	select BOARD_EARLY_INIT_F
 	select CPU_V7A
+	select PINCTRL if DM
+	select PINCTRL_IMX7 if DM
 	select SYS_FSL_HAS_SEC if SECURE_BOOT
 	select SYS_FSL_SEC_COMPAT_4
 	select SYS_FSL_SEC_LE
@@ -803,6 +807,8 @@ config ARCH_MX7
 config ARCH_MX6
 	bool "Freescale MX6"
 	select CPU_V7A
+	select PINCTRL if DM
+	select PINCTRL_IMX6 if DM
 	select SYS_FSL_HAS_SEC if SECURE_BOOT
 	select SYS_FSL_SEC_COMPAT_4
 	select SYS_FSL_SEC_LE
@@ -818,6 +824,8 @@ config ARCH_MX5
 	bool "Freescale MX5"
 	select BOARD_EARLY_INIT_F
 	select CPU_V7A
+	select PINCTRL if DM
+	select PINCTRL_IMX5 if DM
 	imply MXC_GPIO
 
 config ARCH_OWL
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 imx: Select the pinctrl drivers when DM is used

Quoted 47 lines · On Fri, 24 May 2019 09:50:53 -0300 Fabio Estevam <[email protected]> wrote:

When using device model it is required to select the pinctrl drivers so that the pins can be properly configured via devicetree.

mx6sabreauto board is an example of a target that uses DM and does not select the pinctrl drivers.

Instead of doing the pinctrl driver selection in each individual defconfig file, select it at SoC level when DM is used.

---
 arch/arm/Kconfig | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/Kconfig +6 -0
index efb9aab390..4c361c9a1d 100644
@@ -787,6 +787,8 @@ config ARCH_MX31
 config ARCH_MX7ULP
 	bool "NXP MX7ULP"
 	select CPU_V7A
+	select PINCTRL if DM
+	select PINCTRL_IMX7ULP if DM
 	select ROM_UNIFIED_SECTIONS
 	imply MXC_GPIO
 
@@ -795,6 +797,8 @@ config ARCH_MX7
 	select ARCH_MISC_INIT
 	select BOARD_EARLY_INIT_F
 	select CPU_V7A
+	select PINCTRL if DM
+	select PINCTRL_IMX7 if DM
 	select SYS_FSL_HAS_SEC if SECURE_BOOT
 	select SYS_FSL_SEC_COMPAT_4
 	select SYS_FSL_SEC_LE
@@ -803,6 +807,8 @@ config ARCH_MX7
 config ARCH_MX6
 	bool "Freescale MX6"
 	select CPU_V7A
+	select PINCTRL if DM
+	select PINCTRL_IMX6 if DM
 	select SYS_FSL_HAS_SEC if SECURE_BOOT
 	select SYS_FSL_SEC_COMPAT_4
 	select SYS_FSL_SEC_LE

arch/arm/Kconfig config ARCH_MX5 · line 831

Quoted 8 lines
arch/arm/Kconfig +2 -0
@@ -818,6 +824,8 @@ config ARCH_MX5
 	bool "Freescale MX5"
 	select BOARD_EARLY_INIT_F
 	select CPU_V7A
+	select PINCTRL if DM
+	select PINCTRL_IMX5 if DM
 	imply MXC_GPIO
 
 config ARCH_OWL

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190524/ec8328ab/attachment.sig>

#2 lore raw

PATCH 1/1 imx: Select the pinctrl drivers when DM is used

Hi Fabio,

Quoted 57 lines
Quoted 54 lines · On Fri, 24 May 2019 09:50:53 -0300 Fabio Estevam <[email protected]> wrote:

When using device model it is required to select the pinctrl drivers so that the pins can be properly configured via devicetree.

mx6sabreauto board is an example of a target that uses DM and does not select the pinctrl drivers.

Instead of doing the pinctrl driver selection in each individual defconfig file, select it at SoC level when DM is used.

---
 arch/arm/Kconfig | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/Kconfig +8 -0
index efb9aab390..4c361c9a1d 100644
@@ -787,6 +787,8 @@ config ARCH_MX31
 config ARCH_MX7ULP
 	bool "NXP MX7ULP"
 	select CPU_V7A
+	select PINCTRL if DM
+	select PINCTRL_IMX7ULP if DM
 	select ROM_UNIFIED_SECTIONS
 	imply MXC_GPIO
 
@@ -795,6 +797,8 @@ config ARCH_MX7
 	select ARCH_MISC_INIT
 	select BOARD_EARLY_INIT_F
 	select CPU_V7A
+	select PINCTRL if DM
+	select PINCTRL_IMX7 if DM
 	select SYS_FSL_HAS_SEC if SECURE_BOOT
 	select SYS_FSL_SEC_COMPAT_4
 	select SYS_FSL_SEC_LE
@@ -803,6 +807,8 @@ config ARCH_MX7
 config ARCH_MX6
 	bool "Freescale MX6"
 	select CPU_V7A
+	select PINCTRL if DM
+	select PINCTRL_IMX6 if DM
 	select SYS_FSL_HAS_SEC if SECURE_BOOT
 	select SYS_FSL_SEC_COMPAT_4
 	select SYS_FSL_SEC_LE
@@ -818,6 +824,8 @@ config ARCH_MX5
 	bool "Freescale MX5"
 	select BOARD_EARLY_INIT_F
 	select CPU_V7A
+	select PINCTRL if DM
+	select PINCTRL_IMX5 if DM
 	imply MXC_GPIO
 
Quoted 4 lines

arch/arm/Kconfig config ARCH_MX5 · line 831

Quoted 1 line
arch/arm/Kconfig +0 -0
 config ARCH_OWL  

Unfortunately, after some testing it turned out that this patch causes build break for "display5_factory_defconfig"

The build break is as follows:

WARNING: unmet direct dependencies detected for PINCTRL_IMX6
Depends on [n]: ARCH_MX6 [=y] && PINCTRL_FULL [=n] Selected by [y]:
- ARCH_MX6 [=y] && <choice> && DM [=y]

WARNING: unmet direct dependencies detected for PINCTRL_IMX6
Depends on [n]: ARCH_MX6 [=y] && PINCTRL_FULL [=n]
Selected by [y]:
- ARCH_MX6 [=y] && <choice> && DM [=y]
../drivers/pinctrl/nxp/pinctrl-imx6.c:32:32:
warning: ?imx6_pinctrl_match? defined but not used
[-Wunused-const-variable=] static const struct udevice_id
imx6_pinctrl_match[] = { ^~~~~~~~~~~~~~~~~~ drivers/built-in.o: In
function `imx6_pinctrl_probe':
build/../drivers/pinctrl/nxp/pinctrl-imx6.c:29: undefined reference to
`imx_pinctrl_probe'
drivers/built-in.o:(.u_boot_list_2_driver_2_imx6_pinctrl+0x14):
undefined reference to `imx_pinctrl_remove'
drivers/built-in.o:(.u_boot_list_2_driver_2_imx6_pinctrl+0x3c):
undefined reference to `imx_pinctrl_ops' arm-linux-gnueabihf-ld.bfd:
BFD (Linaro_Binutils-2017.05) 2.27.0.20161019 assertion
fail /home/tcwg-buildslave/workspace/tcwg-make-release/builder_arch/amd64/label/tcwg-x86_64-build/target/arm-linux-gnueabihf/snapshots/binutils-gdb.git~linaro-local~linaro_binutils-2_27-branch/bfd/elf32-arm.c:8784

Quoted 11 lines

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
lukma at denx.de

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190605/31794b5e/attachment.sig>

#3 lore raw

PATCH 1/1 imx: Select the pinctrl drivers when DM is used

In reply to Fabio Estevam
Quoted 11 lines · Fabio Estevam

When using device model it is required to select the pinctrl drivers so that the pins can be properly configured via devicetree.

mx6sabreauto board is an example of a target that uses DM and does not select the pinctrl drivers.

Instead of doing the pinctrl driver selection in each individual defconfig file, select it at SoC level when DM is used.

Quoted 44 lines
---
 arch/arm/Kconfig | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/Kconfig +8 -0
index efb9aab390..4c361c9a1d 100644
@@ -787,6 +787,8 @@ config ARCH_MX31
 config ARCH_MX7ULP
 	bool "NXP MX7ULP"
 	select CPU_V7A
+	select PINCTRL if DM
+	select PINCTRL_IMX7ULP if DM
 	select ROM_UNIFIED_SECTIONS
 	imply MXC_GPIO
 
@@ -795,6 +797,8 @@ config ARCH_MX7
 	select ARCH_MISC_INIT
 	select BOARD_EARLY_INIT_F
 	select CPU_V7A
+	select PINCTRL if DM
+	select PINCTRL_IMX7 if DM
 	select SYS_FSL_HAS_SEC if SECURE_BOOT
 	select SYS_FSL_SEC_COMPAT_4
 	select SYS_FSL_SEC_LE
@@ -803,6 +807,8 @@ config ARCH_MX7
 config ARCH_MX6
 	bool "Freescale MX6"
 	select CPU_V7A
+	select PINCTRL if DM
+	select PINCTRL_IMX6 if DM
 	select SYS_FSL_HAS_SEC if SECURE_BOOT
 	select SYS_FSL_SEC_COMPAT_4
 	select SYS_FSL_SEC_LE
@@ -818,6 +824,8 @@ config ARCH_MX5
 	bool "Freescale MX5"
 	select BOARD_EARLY_INIT_F
 	select CPU_V7A
+	select PINCTRL if DM
+	select PINCTRL_IMX5 if DM
 	imply MXC_GPIO
 
 config ARCH_OWL
Signature · 2 lines
Sjoerd Simons
Collabora Ltd.