Skip to contentSkip to conversation

habanalabs fixes for 5.2-rc2/3

GIT PULL Oded Gabbay 2 participants 3 messages May 24, 2019

lore
Share & tools
lore
#0 lore raw

Hi Greg,

This is the pull request containing fixes for 5.2-rc2/3.

It supersedes the pull request from 12/5, so you can discard that pull request, as I see you didn't merge it anyway.

It contains 3 fixes and 1 change to a new IOCTL that was introduced to kernel 5.2 in the previous pull requests.

See the tag comment for more details.

Thanks,
Oded

The following changes since commit b0576f9ecb5c51e9932531d23c447b2739261841:

misc: sgi-xp: Properly initialize buf in xpc_get_rsvd_page_pa (2019-05-24 19:00:54 +0200)

are available in the Git repository at:

git://people.freedesktop.org/~gabbayo/linux tags/misc-habanalabs-fixes-2019-05-24

for you to fetch changes up to 0dfda3cf06aac2f339442ee5934a38566619c059:

habanalabs: Avoid using a non-initialized MMU cache mutex (2019-05-24 20:38:04 +0300)

----------------------------------------------------------------
This tag contains the following fixes:

- Halt debug engines when user process closes the FD. We can't allow the device to issue transactions for a user which doesn't exists anymore.

- Fix various security holes in debugfs API.

- Add a new opcode to the DEBUG IOCTL API. The opcode is designed for setting the device into and out of debug mode. Although not a fix per-se, because this is a new IOCTL which is upstreamed in kernel 5.2, I think this is justified at this point because we won't be able to change the API later.

- Fix a bug where the code used an un-initialized mutex

----------------------------------------------------------------
Jann Horn (1):
habanalabs: fix debugfs code

Oded Gabbay (1):
uapi/habanalabs: add opcode for enable/disable device debug mode

Omer Shpigelman (1):
habanalabs: halt debug engines on user process close

Tomer Tayar (1):
habanalabs: Avoid using a non-initialized MMU cache mutex

 drivers/misc/habanalabs/context.c             |  6 +++
 drivers/misc/habanalabs/debugfs.c             | 60 ++++++++-------------------
 drivers/misc/habanalabs/device.c              |  2 +
 drivers/misc/habanalabs/goya/goya.c           |  3 +-
 drivers/misc/habanalabs/goya/goyaP.h          |  1 +
 drivers/misc/habanalabs/goya/goya_coresight.c | 17 ++++++++
 drivers/misc/habanalabs/habanalabs.h          |  2 +
 drivers/misc/habanalabs/mmu.c                 |  8 +---
 include/uapi/misc/habanalabs.h                | 22 +++++++++-
 9 files changed, 69 insertions(+), 52 deletions(-)
#1 lore raw
Quoted 10 lines · Oded Gabbay

Hi Greg,

This is the pull request containing fixes for 5.2-rc2/3.

It supersedes the pull request from 12/5, so you can discard that pull request, as I see you didn't merge it anyway.

It contains 3 fixes and 1 change to a new IOCTL that was introduced to kernel 5.2 in the previous pull requests.

Quoted 8 lines

See the tag comment for more details.

Thanks,
Oded

The following changes since commit b0576f9ecb5c51e9932531d23c447b2739261841:

misc: sgi-xp: Properly initialize buf in xpc_get_rsvd_page_pa (2019-05-24 19:00:54 +0200)

Wait, that is my char-misc-testing branch, which moves to char-misc-next, not char-misc-linus.

Please rebase this series on char-misc-linus, as the patches in char-misc-testing are NOT for 5.2-final.

thanks,

greg k-h

#2 lore raw
Quoted 21 lines · Greg KH
Quoted 10 lines · Oded Gabbay

Hi Greg,

This is the pull request containing fixes for 5.2-rc2/3.

It supersedes the pull request from 12/5, so you can discard that pull request, as I see you didn't merge it anyway.

It contains 3 fixes and 1 change to a new IOCTL that was introduced to kernel 5.2 in the previous pull requests.

Quoted 8 lines

See the tag comment for more details.

Thanks,
Oded

The following changes since commit b0576f9ecb5c51e9932531d23c447b2739261841:

misc: sgi-xp: Properly initialize buf in xpc_get_rsvd_page_pa (2019-05-24 19:00:54 +0200)

Quoted 8 lines

Wait, that is my char-misc-testing branch, which moves to char-misc-next, not char-misc-linus.

Please rebase this series on char-misc-linus, as the patches in char-misc-testing are NOT for 5.2-final.

thanks,

greg k-h

sure, np.
I'll remember this from now on.

Oded