drm/omapdrm: fix warning PTR_ERR_OR_ZERO can be used
Subsystems (3)
PATCH 1/1 drm/omapdrm: fix warning PTR_ERR_OR_ZERO can be used
fix below warnings reported by coccicheck
./drivers/gpu/drm/omapdrm/dss/hdmi_phy.c:197:1-3: WARNING:PTR_ERR_OR_ZERO can be used ./drivers/gpu/drm/omapdrm/dss/hdmi4_core.c:937:1-3: WARNING:PTR_ERR_OR_ZERO can be used ./drivers/gpu/drm/omapdrm/dss/hdmi5_core.c:913:1-3: WARNING:PTR_ERR_OR_ZERO can be used ./drivers/gpu/drm/omapdrm/dss/hdmi4.c:601:1-3: WARNING: PTR_ERR_OR_ZERO can be used
--- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 5 +---- drivers/gpu/drm/omapdrm/dss/hdmi4_core.c | 6 ++---- drivers/gpu/drm/omapdrm/dss/hdmi5_core.c | 4 +--- drivers/gpu/drm/omapdrm/dss/hdmi_phy.c | 4 +--- 4 files changed, 5 insertions(+), 14 deletions(-)
drivers/gpu/drm/omapdrm/dss/hdmi4.c +1 -4
@@ -598,10 +598,7 @@ static int hdmi_audio_register(struct omap_hdmi *hdmi) &hdmi->pdev->dev,"omap-hdmi-audio" ,PLATFORM_DEVID_AUTO , &pdata, sizeof(pdata)); -if (IS_ERR (hdmi->audio_pdev)) -return PTR_ERR (hdmi->audio_pdev); - -return 0 ; +return PTR_ERR_OR_ZERO (hdmi->audio_pdev); }/* -----------------------------------------------------------------------------
drivers/gpu/drm/omapdrm/dss/hdmi4_core.c +2 -4
@@ -934,8 +934,6 @@ int hdmi4_core_init(struct platform_device *pdev, struct hdmi_core_data *core) res =platform_get_resource_byname (pdev,IORESOURCE_MEM ,"core" ); core->base =devm_ioremap_resource (&pdev->dev, res); -if (IS_ERR (core->base)) -return PTR_ERR (core->base); - -return 0 ; + +return PTR_ERR_OR_ZERO (core->base); }
drivers/gpu/drm/omapdrm/dss/hdmi5_core.c +1 -3
@@ -910,8 +910,6 @@ int hdmi5_core_init(struct platform_device *pdev, struct hdmi_core_data *core) res =platform_get_resource_byname (pdev,IORESOURCE_MEM ,"core" ); core->base =devm_ioremap_resource (&pdev->dev, res); -if (IS_ERR (core->base)) -return PTR_ERR (core->base); -return 0 ; +return PTR_ERR_OR_ZERO (core->base); }
drivers/gpu/drm/omapdrm/dss/hdmi_phy.c +1 -3
@@ -194,8 +194,6 @@ int hdmi_phy_init(struct platform_device *pdev, struct hdmi_phy_data *phy, res =platform_get_resource_byname (pdev,IORESOURCE_MEM ,"phy" ); phy->base =devm_ioremap_resource (&pdev->dev, res); -if (IS_ERR (phy->base)) -return PTR_ERR (phy->base); -return 0 ; +return PTR_ERR_OR_ZERO (phy->base); }
Signature · 1 line
2.7.4
Quoted 3 lines · Hariprasad Kelam
fix below warnings reported by coccicheck
Hi,
a similar patch was nacked because it makes backports more difficult:
https://lore.kernel.org/lkml/[email protected]/
Tomi, what's your thought?
Signature · 2 lines
Matteo Croce per aspera ad upstream
Hi,
Quoted 6 lines · Matteo Croce
Quoted 3 lines · Hariprasad Kelam
fix below warnings reported by coccicheck
Quoted 8 lines
Hi,
a similar patch was nacked because it makes backports more difficult:
https://lore.kernel.org/lkml/[email protected]/
Tomi, what's your thought?
I don't particularly like the PTR_ERR_OR_ZERO, and changing old code to use it seem pointless.
Tomi
Signature · 6 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel