Skip to contentSkip to conversation

drivers/dca: fix warning PTR_ERR_OR_ZERO can be used

PATCH New Hariprasad Kelam 1 participant 1 message May 25, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/dca: fix warning PTR_ERR_OR_ZERO can be used

fix below warning reported by coccicheck

./drivers/dca/dca-sysfs.c:43:1-3: WARNING: PTR_ERR_OR_ZERO can be used

---
 drivers/dca/dca-sysfs.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/dca/dca-sysfs.c +2 -3
index 126cf29..5270705 100644
@@ -40,9 +40,8 @@ int dca_sysfs_add_req(struct dca_provider *dca, struct device *dev, int slot)
 
 	cd = device_create(dca_class, dca->cd, MKDEV(0, slot + 1), NULL,
 			   "requester%d", req_count++);
-	if (IS_ERR(cd))
-		return PTR_ERR(cd);
-	return 0;
+
+	return PTR_ERR_OR_ZERO(cd);
 }
 
 void dca_sysfs_remove_req(struct dca_provider *dca, int slot)
Signature · 1 line
2.7.4