ovl: support the FS_IOC_FS[SG]ETXATTR ioctls
Amir Goldstein
maintainerPATCH 1/1 ovl: support the FS_IOC_FS[SG]ETXATTR ioctls
They are the extended version of FS_IOC_FS[SG]ETFLAGS ioctls. xfs_io -c "chattr <flags>" uses the new ioctls for setting flags.
This used to work in kernel pre v4.19, before stacked file ops introduced the ovl_ioctl whitelist.
Reported-by Dave Chinner <[email protected]>
Fixes d1d04ef8572b ("ovl: stack file ops")
Cc <[email protected]> # v4.19
Signed-off-by Amir Goldstein <[email protected]>
--- fs/overlayfs/file.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
fs/overlayfs/file.c +6 -3
@@ -426,7 +426,8 @@ static unsigned int ovl_get_inode_flags(struct inode *inode)return ovl_iflags; } -static long ovl_ioctl_set_flags (struct file *file,unsigned long arg) +static long ovl_ioctl_set_flags (struct file *file,unsigned int cmd, +unsigned long arg) {long ret;struct inode *inode =file_inode (file);
@@ -456,7 +457,7 @@ static long ovl_ioctl_set_flags(struct file *file, unsigned long arg)if (ret) goto unlock; - ret =ovl_real_ioctl (file,FS_IOC_SETFLAGS , arg); + ret =ovl_real_ioctl (file, cmd, arg);ovl_copyflags (ovl_inode_real (inode), inode); unlock:
@@ -474,11 +475,13 @@ static long ovl_ioctl(struct file *file, unsigned int cmd, unsigned long arg)switch (cmd) {case FS_IOC_GETFLAGS : +case FS_IOC_FSGETXATTR : ret =ovl_real_ioctl (file, cmd, arg);break ;case FS_IOC_SETFLAGS : - ret =ovl_ioctl_set_flags (file, arg); +case FS_IOC_FSSETXATTR : + ret =ovl_ioctl_set_flags (file, cmd, arg);break ;default :
Signature · 1 line
2.17.1
Miklos Szeredi
maintainerQuoted 11 lines · Amir Goldstein
They are the extended version of FS_IOC_FS[SG]ETFLAGS ioctls.
xfs_io-c "chattr <flags>" uses the new ioctls for setting flags.This used to work in kernel pre v4.19, before stacked file ops introduced the
ovl_ioctlwhitelist.Reported-by Dave Chinner <[email protected]>Fixes d1d04ef8572b ("ovl: stack file ops")Cc <[email protected]> # v4.19Signed-off-by Amir Goldstein <[email protected]>
Thanks, applied.
Miklos