Skip to contentSkip to conversation

configs/legoev3: define CONFIG_SKIP_LOWLEVEL_INIT

PATCH New David Lechner 3 participants 4 messages May 29, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configs/legoev3: define CONFIG_SKIP_LOWLEVEL_INIT

This adds a define for CONFIG_SKIP_LOWLEVEL_INIT in the legoev3 config. On the EV3, U-Boot is loaded into RAM by another bootloader, so we don't need the lowlevel init in U-Boot.

---
 include/configs/legoev3.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/legoev3.h +1 -0
index 1e239ecadd..36ca3b201e 100644
@@ -22,6 +22,7 @@
 #define CONFIG_SYS_OSCIN_FREQ		24000000
 #define CONFIG_SYS_TIMERBASE		DAVINCI_TIMER0_BASE
 #define CONFIG_SYS_HZ_CLOCK		clk_get(DAVINCI_AUXCLK_CLKID)
+#define CONFIG_SKIP_LOWLEVEL_INIT
 
 /*
  * Memory Info
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 configs/legoev3: define CONFIG_SKIP_LOWLEVEL_INIT

Quoted 15 lines · David Lechner

This adds a define for CONFIG_SKIP_LOWLEVEL_INIT in the legoev3 config. On the EV3, U-Boot is loaded into RAM by another bootloader, so we don't need the lowlevel init in U-Boot.

---
 include/configs/legoev3.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/legoev3.h +0 -0
index 1e239ecadd..36ca3b201e 100644

include/configs/legoev3.h line 25

Quoted 4 lines
include/configs/legoev3.h +1 -0
@@ -22,6 +22,7 @@
 #define CONFIG_SYS_OSCIN_FREQ          24000000
 #define CONFIG_SYS_TIMERBASE           DAVINCI_TIMER0_BASE
 #define CONFIG_SYS_HZ_CLOCK            clk_get(DAVINCI_AUXCLK_CLKID)
+#define CONFIG_SKIP_LOWLEVEL_INIT

If that's the case, does this mean that the NAK'd patch from Bartosz removing the dead code can be accepted?

adam

Quoted 6 lines
include/configs/legoev3.h +0 -1
 /*
  * Memory Info
--

2.17.1

#2 lore raw

PATCH 1/1 configs/legoev3: define CONFIG_SKIP_LOWLEVEL_INIT

Quoted 11 lines · Adam Ford
Quoted 10 lines · David Lechner

This adds a define for CONFIG_SKIP_LOWLEVEL_INIT in the legoev3 config. On the EV3, U-Boot is loaded into RAM by another bootloader, so we don't need the lowlevel init in U-Boot.

---
  include/configs/legoev3.h | 1 +
  1 file changed, 1 insertion(+)
Quoted 12 lines

include/configs/legoev3.h line 25

Quoted 9 lines
include/configs/legoev3.h +1 -0
index 1e239ecadd..36ca3b201e 100644
@@ -22,6 +22,7 @@
  #define CONFIG_SYS_OSCIN_FREQ          24000000
  #define CONFIG_SYS_TIMERBASE           DAVINCI_TIMER0_BASE
  #define CONFIG_SYS_HZ_CLOCK            clk_get(DAVINCI_AUXCLK_CLKID)
+#define CONFIG_SKIP_LOWLEVEL_INIT

If that's the case, does this mean that the NAK'd patch from Bartosz removing the dead code can be accepted?

Probably

#3 lore raw

PATCH 1/1 configs/legoev3: define CONFIG_SKIP_LOWLEVEL_INIT

śr., 29 maj 2019 o 03:55 David Lechner <[email protected]> napisał(a):

Quoted 26 lines · Adam Ford
Quoted 11 lines · David Lechner
Quoted 10 lines

This adds a define for CONFIG_SKIP_LOWLEVEL_INIT in the legoev3 config. On the EV3, U-Boot is loaded into RAM by another bootloader, so we don't need the lowlevel init in U-Boot.

---
  include/configs/legoev3.h | 1 +
  1 file changed, 1 insertion(+)
Quoted 12 lines

include/configs/legoev3.h line 25

Quoted 9 lines
include/configs/legoev3.h +1 -0
index 1e239ecadd..36ca3b201e 100644
@@ -22,6 +22,7 @@
  #define CONFIG_SYS_OSCIN_FREQ          24000000
  #define CONFIG_SYS_TIMERBASE           DAVINCI_TIMER0_BASE
  #define CONFIG_SYS_HZ_CLOCK            clk_get(DAVINCI_AUXCLK_CLKID)
+#define CONFIG_SKIP_LOWLEVEL_INIT

If that's the case, does this mean that the NAK'd patch from Bartosz removing the dead code can be accepted?

Quoted 1 line

Probably

I will resend the two patches in a single series to avoid confusion.

Bart