Skip to contentSkip to conversation

drm/i915: selftest_lrc: Check the correct variable

PATCH In review Dan Carpenter 3 participants 4 messages May 29, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: selftest_lrc: Check the correct variable

We should check "request[n]" instead of just "request".

Fixes 78e41ddd2198 ("drm/i915: Apply an execution_mask to the virtual_engine")
---
 drivers/gpu/drm/i915/gt/selftest_lrc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/gt/selftest_lrc.c +2 -2
index a8c50900e2d4..13674f836955 100644
@@ -1526,8 +1526,8 @@ static int mask_virtual_engine(struct drm_i915_private *i915,
 
 	for (n = 0; n < nsibling; n++) {
 		request[n] = i915_request_create(ve);
-		if (IS_ERR(request)) {
-			err = PTR_ERR(request);
+		if (IS_ERR(request[n])) {
+			err = PTR_ERR(request[n]);
 			nsibling = n;
 			goto out;
 		}
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

Quoting Chris Wilson (2019-05-29 12:06:57)

Quoted 8 lines

Quoting Dan Carpenter (2019-05-29 12:03:55)

Quoted 4 lines

We should check "request[n]" instead of just "request".

Fixes 78e41ddd2198 ("drm/i915: Apply an execution_mask to the virtual_engine")

Oops.

s/Reviewd/Reviewed/
And pushed, thanks for the fix.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

✗ Fi.CI.BAT: failure for drm/i915: selftest_lrc: Check the correct variable

In reply to Dan Carpenter
== Series Details ==

== Series Details ==

Series: drm/i915: selftest_lrc: Check the correct variable
URL : https://patchwork.freedesktop.org/series/61312/
State : failure

== Summary ==

Applying: drm/i915: selftest_lrc: Check the correct variable Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/gt/selftest_lrc.c
Falling back to patching base and 3-way merge... Auto-merging drivers/gpu/drm/i915/gt/selftest_lrc.c No changes -- Patch already applied.

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx