i2c: mux: Use struct_size() in devm_kzalloc()
Subsystems (3)
PATCH 1/1 i2c: mux: Use struct_size() in devm_kzalloc()
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example:
struct foo {
int stuff;
struct boo entry[];
};instance = devm_kzalloc(dev, sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);
Instead of leaving these open-coded and prone to type mistakes, we can now use the new struct_size() helper:
instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL);
This code was detected with the help of Coccinelle.
--- drivers/i2c/i2c-mux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/i2c/i2c-mux.c +1 -2
@@ -243,8 +243,7 @@ struct i2c_mux_core *i2c_mux_alloc(struct i2c_adapter *parent, {struct i2c_mux_core *muxc; - muxc =devm_kzalloc (dev,sizeof (*muxc) - + max_adapters *sizeof (muxc->adapter[0 ]) + muxc =devm_kzalloc (dev,struct_size (muxc, adapter, max_adapters) + sizeof_priv,GFP_KERNEL );if (!muxc)return NULL ;
Signature · 1 line
2.21.0
Quoted 9 lines · Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example:
struct foo { int stuff; struct boo entry[]; };
Quoted 8 lines
instance =
devm_kzalloc(dev, sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);Instead of leaving these open-coded and prone to type mistakes, we can now use the new
struct_size()helper:instance =
devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL);This code was detected with the help of Coccinelle.
Thanks, patch applied to i2c-mux/for-next
Cheers,
Peter