power: pmic: palmas/lp87565/lp873x: Remove $SPL from Makefile
PATCH v2 1/2 power: pmic: palmas/lp87565/lp873x: Remove $SPL from Makefile
Remove $SPL from Makefile as the corresponding SPL config options are not present. This enables them at SPL.
--- drivers/power/pmic/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/power/pmic/Makefile +3 -3
@@ -20,9 +20,9 @@ obj-$(CONFIG_PMIC_RN5T567) += rn5t567.o obj-$(CONFIG_PMIC_TPS65090) += tps65090.o obj-$(CONFIG_PMIC_S5M8767) += s5m8767.o obj-$(CONFIG_DM_PMIC_TPS65910) += pmic_tps65910_dm.o -obj-$(CONFIG_$(SPL_)PMIC_PALMAS) += palmas.o -obj-$(CONFIG_$(SPL_)PMIC_LP873X) += lp873x.o -obj-$(CONFIG_$(SPL_)PMIC_LP87565) += lp87565.o +obj-$(CONFIG_PMIC_PALMAS) += palmas.o +obj-$(CONFIG_PMIC_LP873X) += lp873x.o +obj-$(CONFIG_PMIC_LP87565) += lp87565.o obj-$(CONFIG_PMIC_STPMIC1) += stpmic1.o obj-$(CONFIG_POWER_LTC3676) += pmic_ltc3676.o
Signature · 1 line
2.17.1
PATCH v2 2/2 power: regulator: palmas/lp87565/lp873x: Remove $SPL from Makefile
Remove $SPL from Makefile as the corresponding SPL config options are not present. This enables them at SPL.
--- drivers/power/regulator/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/power/regulator/Makefile +3 -3
@@ -18,10 +18,10 @@ obj-$(CONFIG_DM_REGULATOR_S2MPS11) += s2mps11_regulator.o obj-$(CONFIG_REGULATOR_S5M8767) += s5m8767.o obj-$(CONFIG_DM_REGULATOR_SANDBOX) += sandbox.o obj-$(CONFIG_REGULATOR_TPS65090) += tps65090_regulator.o -obj-$(CONFIG_$(SPL_)DM_REGULATOR_PALMAS) += palmas_regulator.o +obj-$(CONFIG_DM_REGULATOR_PALMAS) += palmas_regulator.o obj-$(CONFIG_$(SPL_)DM_REGULATOR_PBIAS) += pbias_regulator.o -obj-$(CONFIG_$(SPL_)DM_REGULATOR_LP873X) += lp873x_regulator.o -obj-$(CONFIG_$(SPL_)DM_REGULATOR_LP87565) += lp87565_regulator.o +obj-$(CONFIG_DM_REGULATOR_LP873X) += lp873x_regulator.o +obj-$(CONFIG_DM_REGULATOR_LP87565) += lp87565_regulator.o obj-$(CONFIG_$(SPL_)DM_REGULATOR_STM32_VREFBUF) += stm32-vrefbuf.o obj-$(CONFIG_DM_REGULATOR_TPS65910) += tps65910_regulator.o obj-$(CONFIG_$(SPL_)DM_REGULATOR_STPMIC1) += stpmic1.o
Signature · 1 line
2.17.1
PATCH v2 1/2 power: pmic: palmas/lp87565/lp873x: Remove $SPL from Makefile
In reply to KeerthyQuoted 15 lines · Keerthy
Remove $SPL from
Makefileas the corresponding SPL config options are not present. This enables them at SPL.Signed-off-by Keerthy <[email protected]>--- drivers/power/pmic/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/power/pmic/Makefile +0
-0@@ -20,9 +20,9 @@ obj-$(CONFIG_PMIC_RN5T567) += rn5t567.o obj-$(CONFIG_PMIC_TPS65090) += tps65090.o obj-$(CONFIG_PMIC_S5M8767) += s5m8767.o
drivers/power/pmic/Makefile obj-$(CONFIG_PMIC_RN5T567) += rn5t567.o · line 28
Quoted 10 lines
drivers/power/pmic/Makefile +3
-3obj-$(CONFIG_DM_PMIC_TPS65910) += pmic_tps65910_dm.o -obj-$(CONFIG_$(SPL_)PMIC_PALMAS) += palmas.o -obj-$(CONFIG_$(SPL_)PMIC_LP873X) += lp873x.o -obj-$(CONFIG_$(SPL_)PMIC_LP87565) += lp87565.o +obj-$(CONFIG_PMIC_PALMAS) += palmas.o +obj-$(CONFIG_PMIC_LP873X) += lp873x.o +obj-$(CONFIG_PMIC_LP87565) += lp87565.o obj-$(CONFIG_PMIC_STPMIC1) += stpmic1.o obj-$(CONFIG_POWER_LTC3676) += pmic_ltc3676.o
This comment applies to both 1/2 and 2/2, and is much more obvious with 2/2. Why is this the right approach rather than adding SPL symbols for the parts in question? We have a whole lot of "I am concerned about SPL size" posts. Especially on 2/2 some of the drivers in question aren't even things used on TI parts and do (or are shown in the patch context to be) use, apparently, the SPL symbol. Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190530/0f56b0e0/attachment.sig>
PATCH v2 1/2 power: pmic: palmas/lp87565/lp873x: Remove $SPL from Makefile
Quoted 25 lines · Tom Rini
Quoted 24 lines · Keerthy
Remove $SPL from
Makefileas the corresponding SPL config options are not present. This enables them at SPL.Signed-off-by Keerthy <[email protected]>--- drivers/power/pmic/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/power/pmic/Makefile +3
-3@@ -20,9 +20,9 @@ obj-$(CONFIG_PMIC_RN5T567) += rn5t567.o obj-$(CONFIG_PMIC_TPS65090) += tps65090.o obj-$(CONFIG_PMIC_S5M8767) += s5m8767.o obj-$(CONFIG_DM_PMIC_TPS65910) += pmic_tps65910_dm.o -obj-$(CONFIG_$(SPL_)PMIC_PALMAS) += palmas.o -obj-$(CONFIG_$(SPL_)PMIC_LP873X) += lp873x.o -obj-$(CONFIG_$(SPL_)PMIC_LP87565) += lp87565.o +obj-$(CONFIG_PMIC_PALMAS) += palmas.o +obj-$(CONFIG_PMIC_LP873X) += lp873x.o +obj-$(CONFIG_PMIC_LP87565) += lp87565.o obj-$(CONFIG_PMIC_STPMIC1) += stpmic1.o
Quoted 9 lines
drivers/power/pmic/Makefile obj-$(CONFIG_PMIC_RN5T567) += rn5t567.o · line 28
Quoted 1 line
drivers/power/pmic/Makefile +0
-0obj-$(CONFIG_POWER_LTC3676) += pmic_ltc3676.oThis comment applies to both 1/2 and 2/2, and is much more obvious with 2/2. Why is this the right approach rather than adding SPL symbols for the parts in question? We have a whole lot of "I am concerned about SPL size" posts. Especially on 2/2 some of the drivers in question aren't even things used on TI parts and do (or are shown in the patch context to be) use, apparently, the SPL symbol. Thanks!
lp873x is used with DRA71 and LP87565 is used with DRA76.
We want them to be enabled at SPL level in dra7xx_evm_defconfig but if due to SPL size constraints if we want control over not enabling them in SPL then i will send next version with SPL_ defined in their respective KConfigs.
Thanks,
Keerthy