Skip to contentSkip to conversation

netlink: Relax sequence check for the group notifications

PATCH Applied Tim Kourt 2 participants 2 messages May 30, 2019 – May 31, 2019

lore
Share & tools
lore

Tim Kourt

author
#0 lore raw

PATCH 1/1 netlink: Relax sequence check for the group notifications

Some of the RTNL groups such as RTNLGRP_IPV4_IFADDR set the sequence number in the header of the broadcasted messages. In order to be able to receive the such messages, we relax the check and allow the broadcasted messages with non-zero sequence numbers.

---
 ell/netlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
ell/netlink.c +1 -1
index 3d291cf..33d0e5b 100644
@@ -275,7 +275,7 @@ static bool can_read_data(struct l_io *io, void *user_data)
 
 	for (nlmsg = iov.iov_base; NLMSG_OK(nlmsg, (uint32_t) len);
 					nlmsg = NLMSG_NEXT(nlmsg, len)) {
-		if (group > 0 && nlmsg->nlmsg_seq == 0) {
+		if (group > 0) {
 			process_broadcast(netlink, group, nlmsg);
 			continue;
 		}
Signature · 1 line
2.13.6
#1 lore raw

Hi Tim,

Quoted 9 lines · Tim Kourt

Some of the RTNL groups such as RTNLGRP_IPV4_IFADDR set the sequence number in the header of the broadcasted messages. In order to be able to receive the such messages, we relax the check and allow the broadcasted messages with non-zero sequence numbers.

---
  ell/netlink.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Regards,
-Denis