nvme-cli: update command message for "help"
PATCH 1/1 nvme-cli: update command message for "help"
The "help" subcommand will show the man page, not the help message which is printed out to stdout by --help option. The previous message might make confusions between man page and --help options so that it needs to be updated.
--- plugin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
plugin.c +1 -1
@@ -91,7 +91,7 @@ void general_help(struct plugin *plugin) plugin->commands[i]->help);printf (" %-*s %s\n" , padding,"version" ,"Shows the program version" ); -printf (" %-*s %s\n" , padding,"help" ,"Display this help" ); +printf (" %-*s %s\n" , padding,"help" ,"Display the man page" );printf ("\n" );if (plugin->name)
Signature · 1 line
2.21.0
Sagi Grimberg
maintainerPATCH 1/1 nvme-cli: update command message for "help"
PATCH 1/1 nvme-cli: update command message for "help"
In reply to Minwoo ImLooks good to me.
Quoted 24 lines · Minwoo Im
The "help" subcommand will show the man page, not the help message which is printed out to stdout by --help option. The previous message might make confusions between man page and --help options so that it needs to be updated.
Cc Keith Busch <kbusch at kernel.org>Signed-off-by Minwoo Im <minwoo.im.dev at gmail.com>--- plugin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)plugin.c +1
-1@@ -91,7 +91,7 @@ void general_help(struct plugin *plugin) plugin->commands[i]->help);printf (" %-*s %s\n" , padding,"version" ,"Shows the program version" ); -printf (" %-*s %s\n" , padding,"help" ,"Display this help" ); +printf (" %-*s %s\n" , padding,"help" ,"Display the man page" );printf ("\n" );if (plugin->name)
Keith Busch
maintainerPATCH 1/1 nvme-cli: update command message for "help"
In reply to Minwoo ImQuoted 4 lines · Minwoo Im
The "help" subcommand will show the man page, not the help message which is printed out to stdout by --help option. The previous message might make confusions between man page and --help options so that it needs to be updated.
If you just type "nvme help", you get that help message. If you type "nvme help <command>", then you get that command's manpage. This behavior was copied from 'git'.
PATCH 1/1 nvme-cli: update command message for "help"
Quoted 9 lines · Keith Busch
Quoted 4 lines · Minwoo Im
The "help" subcommand will show the man page, not the help message which is printed out to stdout by --help option. The previous message might make confusions between man page and --help options so that it needs to be updated.
If you just type "nvme help", you get that help message. If you type "nvme help <command>", then you get that command's manpage. This behavior was copied from 'git'.
Hi Keith,
Yes, That's what I meant in this patch, but it does not look like cover "nvme help" command itself.
Let's keep it that way, then.
Thanks!