Skip to contentSkip to conversation

pci: shpchp: Remove unused callback get_mode1_ECC_cap

PATCH New Emanuel Bennici 1 participant 2 messages Jun 2, 2019 PCI

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 pci: shpchp: Remove unused callback get_mode1_ECC_cap

This callback is never invoked/ used in this driver. Removing this callback does not affect the driver.

---
 drivers/pci/hotplug/shpchp_hpc.c | 1 -
 1 file changed, 1 deletion(-)
drivers/pci/hotplug/shpchp_hpc.c +0 -1
index db047284c291..59f75e567c63 100644
@@ -905,7 +905,6 @@ static const struct hpc_ops shpchp_hpc_ops = {
 	.get_adapter_status		= hpc_get_adapter_status,
 
 	.get_adapter_speed		= hpc_get_adapter_speed,
-	.get_mode1_ECC_cap		= hpc_get_mode1_ECC_cap,
 	.get_prog_int			= hpc_get_prog_int,
 
 	.query_power_fault		= hpc_query_power_fault,

--
2.19.1

#1 lore raw

PATCH 2/2 pci: shpchp: Remove function hpc_get_mode1_ECC_cap

Remove function hpc_get_mode1_ECC_cap since it was used by the get_mode1_ECC_cap Callback - that was removed.
So this function is unused and can be safely removed.

---
 drivers/pci/hotplug/shpchp_hpc.c | 17 -----------------
 1 file changed, 17 deletions(-)
drivers/pci/hotplug/shpchp_hpc.c +0 -17
index 59f75e567c63..a6d713360dca 100644
@@ -494,23 +494,6 @@ static int hpc_get_adapter_speed(struct slot *slot, enum pci_bus_speed *value)
 	return retval;
 }
 
-static int hpc_get_mode1_ECC_cap(struct slot *slot, u8 *mode)
-{
-	int retval = 0;
-	struct controller *ctrl = slot->ctrl;
-	u16 sec_bus_status = shpc_readw(ctrl, SEC_BUS_CONFIG);
-	u8 pi = shpc_readb(ctrl, PROG_INTERFACE);
-
-	if (pi == 2) {
-		*mode = (sec_bus_status & 0x0100) >> 8;
-	} else {
-		retval = -1;
-	}
-
-	ctrl_dbg(ctrl, "Mode 1 ECC cap = %d\n", *mode);
-	return retval;
-}
-
 static int hpc_query_power_fault(struct slot *slot)
 {
 	struct controller *ctrl = slot->ctrl;

--
2.19.1