Skip to contentSkip to conversation

lrzsz: Add implicit declaration fixes from Debian

PATCH Superseded Adrian Bunk 2 participants 3 messages Jun 3, 2019 – Jun 5, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lrzsz: Add implicit declaration fixes from Debian

--
v2: Add comment in the patch header.

---
 .../lrzsz/lrzsz-0.12.20/include.patch         | 25 +++++++++++++++++++
 meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb       |  1 +
 2 files changed, 26 insertions(+)
 create mode 100644 meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch
meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch new file +25 -0
new file mode 100644
index 0000000000..5fcb3aa92b
@@ -0,0 +1,25 @@
+Implicit declaration compile warning fixes from Debian
+
+Signed-off-by: Adrian Bunk <[email protected]>
+Upstream-Status: Inappropriate [upstream is dead]
+
+--- lrzsz-0.12.21.orig/lib/long-options.c
++++ lrzsz-0.12.21/lib/long-options.c
+@@ -22,6 +22,7 @@
+ #endif
+ 
+ #include <stdio.h>
++#include <stdlib.h>
+ #include <getopt.h>
+ #include "long-options.h"
+ 
+--- lrzsz-0.12.21.orig/src/lsyslog.c
++++ lrzsz-0.12.21/src/lsyslog.c
+@@ -22,6 +22,7 @@
+ #ifdef ENABLE_SYSLOG
+ #include "zglobal.h"
+ #include <pwd.h>
++#include <stdio.h>
+ #include <stdlib.h>
+ #include <string.h>
+ #endif
meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb +1 -0
index 002c774c6d..34556b2c29 100644
@@ -20,6 +20,7 @@ SRC_URI = "http://www.ohse.de/uwe/releases/lrzsz-${PV}.tar.gz \
 	   file://lrzsz_fix_for_automake-1.12.patch \
            file://lrzsz-check-locale.h.patch \
            file://cve-2018-10195.patch \
+           file://include.patch \
            "
 
 SRC_URI[md5sum] = "b5ce6a74abc9b9eb2af94dffdfd372a4"
Signature · 1 line
2.17.1
#1 lore raw
Quoted 2 lines · Adrian Bunk

--

You need one more dash here, now this v2 comment ended in final commit message which I believe wasn't the intention.

http://git.openembedded.org/openembedded-core/commit/?id=6fa60ac102f6d3977df4236bd5a22680298bdac2

the same with tcp-wrappers change:
http://git.openembedded.org/openembedded-core/commit/?id=cd1dc2334fd3e3d1db9be1d26e888051e3f59c5a

Quoted 58 lines

v2: Add comment in the patch header.

---
 .../lrzsz/lrzsz-0.12.20/include.patch         | 25 +++++++++++++++++++
 meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb       |  1 +
 2 files changed, 26 insertions(+)
 create mode 100644 meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch
meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch new file +25 -0
new file mode 100644
index 0000000000..5fcb3aa92b
@@ -0,0 +1,25 @@
+Implicit declaration compile warning fixes from Debian
+
+Signed-off-by: Adrian Bunk <[email protected]>
+Upstream-Status: Inappropriate [upstream is dead]
+
+--- lrzsz-0.12.21.orig/lib/long-options.c
++++ lrzsz-0.12.21/lib/long-options.c
+@@ -22,6 +22,7 @@
+ #endif
+ 
+ #include <stdio.h>
++#include <stdlib.h>
+ #include <getopt.h>
+ #include "long-options.h"
+ 
+--- lrzsz-0.12.21.orig/src/lsyslog.c
++++ lrzsz-0.12.21/src/lsyslog.c
+@@ -22,6 +22,7 @@
+ #ifdef ENABLE_SYSLOG
+ #include "zglobal.h"
+ #include <pwd.h>
++#include <stdio.h>
+ #include <stdlib.h>
+ #include <string.h>
+ #endif
meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb +1 -0
index 002c774c6d..34556b2c29 100644
@@ -20,6 +20,7 @@ SRC_URI = "http://www.ohse.de/uwe/releases/lrzsz-${PV}.tar.gz \
 	   file://lrzsz_fix_for_automake-1.12.patch \
            file://lrzsz-check-locale.h.patch \
            file://cve-2018-10195.patch \
+           file://include.patch \
            "
 
 SRC_URI[md5sum] = "b5ce6a74abc9b9eb2af94dffdfd372a4"
Signature · 7 lines
2.17.1

-- 
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#2 lore raw
Quoted 4 lines · Martin Jansa
Quoted 2 lines · Adrian Bunk

--

Quoted 8 lines

You need one more dash here, now this v2 comment ended in final commit message which I believe wasn't the intention.

http://git.openembedded.org/openembedded-core/commit/?id=6fa60ac102f6d3977df4236bd5a22680298bdac2

the same with tcp-wrappers change:
http://git.openembedded.org/openembedded-core/commit/?id=cd1dc2334fd3e3d1db9be1d26e888051e3f59c5a
...

Yes thanks, I already noticed my mistake.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed