syscalls/pidfd_send_signal01

Add test to check basic error handling of the syscall.

Signed-off-by Christian Amann <[email protected]>

+#define _GNU_SOURCE

Add testcase to check if the syscall will send a signal to a process with the same PID as the targeted process.

+++ b/testcases/kernel/syscalls/pidfd_send_signal/pidfd_send_signal03.c

+#define _GNU_SOURCE

testcases/kernel/syscalls/pidfd_send_signal/pidfd_send_signal03.c new file +62 -0

+
+#define PIDTRIES	3
+
+static char *last_pid_file;
+static int pidfd, new_pidfd;
+static int old_inode, new_inode;
+
+static int get_inode_number(int fd)
+{
+	struct stat file_stat;
+
+	SAFE_FSTAT(fd, &file_stat);
+	return file_stat.st_ino;
+}
+
+static void verify_pidfd_send_signal(void)
+{
+	pid_t pid, new_pid;
+	char pid_filename[32];
+	char pid_str[16];
+	int i, fail;
+
+	fail = 1;
+	for (i = 0; i < PIDTRIES; i++) {
+		pid = SAFE_FORK();
+		if (pid == 0) {
+			TST_CHECKPOINT_WAIT(0);
+			return;
+		}
+
+		sprintf(pid_filename, "/proc/%d", pid);
+		pidfd = SAFE_OPEN(pid_filename, O_DIRECTORY | O_CLOEXEC);
+		old_inode = get_inode_number(pidfd);
+
+		TST_CHECKPOINT_WAKE(0);
+		tst_reap_children();
+
+		/* Manipulate PID for next process */
+		sprintf(pid_str, "%d", pid - 1);
+		SAFE_FILE_PRINTF(last_pid_file, pid_str);
+
+		new_pid = SAFE_FORK();
+		if (new_pid == 0) {
+			TST_CHECKPOINT_WAIT(0);
+			return;
+		}
+
+		if (new_pid == pid) {
+			new_pidfd = SAFE_OPEN(pid_filename,
+					O_DIRECTORY | O_CLOEXEC);
+			new_inode = get_inode_number(new_pidfd);
+			SAFE_CLOSE(new_pidfd);
+			fail = 0;
+			break;
+		}
+
+		if (i < PIDTRIES) {
+			tst_res(TINFO,
+				"Failed to set correct PID, trying again...");
+		}
+		SAFE_CLOSE(pidfd);
+		TST_CHECKPOINT_WAKE(0);

testcases/kernel/syscalls/pidfd_send_signal/pidfd_send_signal03.c new file +5 -0

+	}
+
+	TEST(pidfd_send_signal(pidfd, SIGUSR1, NULL, 0));
+	if (TST_RET == -1 && TST_ERR == ESRCH) {
+		tst_res(TPASS,

Hi!
When I attempty to compile this code I get:

In file included from pidfd_send_signal.h:11:0,

                 from pidfd_send_signal01.c:17:
pidfd_send_signal.h: In function 'check_syscall_support':
pidfd_send_signal.h:16:14: error: '__NR_pidfd_send_signal' undeclared (first use in this function); did you mean '__NR_perf_event_open'?
  tst_syscall(__NR_pidfd_send_signal);
              ^
../../../../include/lapi/syscalls.h:39:6: note: in definition of macro 'tst_syscall'
  if (NR == __LTP__NR_INVALID_SYSCALL) { \
      ^~
pidfd_send_signal.h:16:14: note: each undeclared identifier is reported only once for each function it appears in
  tst_syscall(__NR_pidfd_send_signal);
              ^
../../../../include/lapi/syscalls.h:39:6: note: in definition of macro 'tst_syscall'
  if (NR == __LTP__NR_INVALID_SYSCALL) { \
      ^~
pidfd_send_signal.h: In function 'pidfd_send_signal':
pidfd_send_signal.h:23:21: error: '__NR_pidfd_send_signal' undeclared (first use in this function); did you mean 'pidfd_send_signal'?
  return tst_syscall(__NR_pidfd_send_signal, pidfd, sig, info, flags);
                     ^
../../../../include/lapi/syscalls.h:39:6: note: in definition of macro 'tst_syscall'
  if (NR == __LTP__NR_INVALID_SYSCALL) { \
      ^~

make: *** [<builtin>: pidfd_send_signal01] Error 1

Have you forgotten to git add the *.in files with syscall numbers?

Add testcase to check if pidfd_send_signal() can provide the same functionality as rt_sigqueueinfo().

Signed-off-by Christian Amann <[email protected]>

testcases/kernel/syscalls/pidfd_send_signal/pidfd_send_signal01.c new file +2 -0

new file mode 100644
index 000000000..f44fce013
@@ -0,0 +1,108 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*

testcases/kernel/syscalls/pidfd_send_signal/pidfd_send_signal01.c new file +4 -0

+
+static void check_syscall_support(void)
+{
+	/* allow the tests to fail early */

testcases/kernel/syscalls/pidfd_send_signal/pidfd_send_signal01.c new file +2 -0

+
+#endif /* PIDFD_SEND_SIGNAL_H */

testcases/kernel/syscalls/pidfd_send_signal/pidfd_send_signal01.c new file +82 -0

new file mode 100644
index 000000000..f44fce013
@@ -0,0 +1,108 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2019 SUSE LLC
+ * Author: Christian Amann <[email protected]>
+ */
+/*
+ * Tests if the pidfd_send_signal syscall behaves
+ * like rt_sigqueueinfo when a pointer to a siginfo_t
+ * struct is passed.
+ */
+
+#define _GNU_SOURCE
+
+#include <signal.h>
+#include <stdlib.h>
+#include "tst_safe_pthread.h"
+#include "pidfd_send_signal.h"
+
+#define SIGNAL  SIGUSR1
+#define DATA	777
+
+static struct sigaction *sig_action;
+static int sig_rec;
+static siginfo_t *uinfo;
+static int pidfd;
+
+static void received_signal(int sig, siginfo_t *info, void *ucontext)
+{
+	if (info && ucontext) {
+		if (sig == SIGNAL && uinfo->si_value.sival_int == DATA) {
+			tst_res(TPASS, "Received correct signal and data!");
+			sig_rec = 1;
+		} else {
+			tst_res(TFAIL, "Received wrong signal and/or data!");
+		}
+	} else {
+		tst_res(TFAIL, "Signal handling went wrong!");
+	}
+}
+
+static void *handle_thread(void *arg)
+{
+	SAFE_SIGACTION(SIGNAL, sig_action, NULL);
+	TST_CHECKPOINT_WAKE_AND_WAIT(0);
+	return arg;
+}
+
+static void verify_pidfd_send_signal(void)
+{
+	pthread_t thr;
+
+	SAFE_PTHREAD_CREATE(&thr, NULL, handle_thread, NULL);
+
+	TST_CHECKPOINT_WAIT(0);
+
+	TEST(pidfd_send_signal(pidfd, SIGNAL, uinfo, 0));
+	if (TST_RET != 0) {
+		tst_res(TFAIL | TTERRNO, "pidfd_send_signal() failed");
+		return;
+	}
+
+	TST_CHECKPOINT_WAKE(0);
+	SAFE_PTHREAD_JOIN(thr, NULL);
+
+	if (sig_rec) {
+		tst_res(TPASS,
+			"pidfd_send_signal() behaved like rt_sigqueueinfo()");
+	}
+}
+
+static void setup(void)
+{
+	check_syscall_support();
+
+	pidfd = SAFE_OPEN("/proc/self", O_DIRECTORY | O_CLOEXEC);
+
+	sig_action = SAFE_MALLOC(sizeof(struct sigaction));
+
+	memset(sig_action, 0, sizeof(*sig_action));
+	sig_action->sa_sigaction = received_signal;
+	sig_action->sa_flags = SA_SIGINFO;
+