Skip to contentSkip to conversation

habanalabs: remove simulator dedicated code

PATCH New Oded Gabbay 1 participant 1 message Jun 4, 2019 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 habanalabs: remove simulator dedicated code

This patch removes two code sections in the common code that contain code which is only relevant for simulator support (which is not upstreamed).

This removal saves the need to update this code upstream, which is not needed anyway.

---
 drivers/misc/habanalabs/device.c | 7 -------
 drivers/misc/habanalabs/sysfs.c  | 4 ----
 2 files changed, 11 deletions(-)
drivers/misc/habanalabs/device.c +0 -7
index feedf4810430..843f0b6547b5 100644
@@ -693,13 +693,6 @@ int hl_device_reset(struct hl_device *hdev, bool hard_reset,
 
 		hdev->hard_reset_pending = true;
 
-		if (!hdev->pdev) {
-			dev_err(hdev->dev,
-				"Reset action is NOT supported in simulator\n");
-			rc = -EINVAL;
-			goto out_err;
-		}
-
 		device_reset_work = kzalloc(sizeof(*device_reset_work),
 						GFP_ATOMIC);
 		if (!device_reset_work) {
drivers/misc/habanalabs/sysfs.c +0 -4
index c900ab15cceb..25eb46d29d88 100644
@@ -328,10 +328,6 @@ static ssize_t pci_addr_show(struct device *dev, struct device_attribute *attr,
 {
 	struct hl_device *hdev = dev_get_drvdata(dev);
 
-	/* Use dummy, fixed address for simulator */
-	if (!hdev->pdev)
-		return sprintf(buf, "0000:%02d:00.0\n", hdev->id);
-
 	return sprintf(buf, "%04x:%02x:%02x.%x\n",
 			pci_domain_nr(hdev->pdev->bus),
 			hdev->pdev->bus->number,
Signature · 1 line
2.17.1