IMX: serial: dm: Set DM_FLAG_PRE_RELOC in the IMX uart driver
PATCH 1/1 IMX: serial: dm: Set DM_FLAG_PRE_RELOC in the IMX uart driver
The DM_FLAG_PRE_RELOC shall be set unconditionally as this driver is going to be re-used in both early SPL and U-Boot proper's pre-reloc.
For i.MX based devices it is crucial to have available the serial console before relocation (otherwise the board may hand).
The device definition may be provided either via device tree description or with U_BOOT_DEVICE(mxc_serial) definition. In the latter case the device will not bind in U-Boot proper when DM_FLAG_PRE_RELOC is not set.
The !CONFIG_IS_ENABLED(OF_CONTROL) #if check was set as a "workaround" for DM problem described in following commit 4687919684e0 ("serial: Remove DM_FLAG_PRE_RELOC flag in various drivers").
Let's look on this check more thoroughly - we add this flag if the board doesn't support OF_CONTROL. This is a bit strange as the serial_mxc.c can be used with CONFIG_DM_SERIAL but without corresponding device tree description (OF_CONTROL). In such case the aforementioned U_BOOT_DEVICE(mxc_serial) definition is used.
Other boards/SoCs have this flag set unconditionally for serial driver.
---
drivers/serial/serial_mxc.c | 2 -- 1 file changed, 2 deletions(-)
drivers/serial/serial_mxc.c +0 -2
@@ -366,9 +366,7 @@ U_BOOT_DRIVER(serial_mxc) = {#endif .probe = mxc_serial_probe, .ops = &mxc_serial_ops, -#if !CONFIG_IS_ENABLED (OF_CONTROL ) .flags = DM_FLAG_PRE_RELOC, -#endif };#endif
Signature · 1 line
2.11.0
PATCH 1/1 IMX: serial: dm: Set DM_FLAG_PRE_RELOC in the IMX uart driver
Quoted 16 lines
The
DM_FLAG_PRE_RELOCshall be set unconditionally as this driver is going to be re-used in both early SPL and U-Boot proper's pre-reloc. For i.MX based devices it is crucial to have available the serial console before relocation (otherwise the board may hand).
The device definition may be provided either via device tree description or withU_BOOT_DEVICE(mxc_serial)definition. In the latter case the device will not bind in U-Boot proper whenDM_FLAG_PRE_RELOCis not set. The !CONFIG_IS_ENABLED(OF_CONTROL) #if check was set as a "workaround" for DM problem described in following commit4687919684e0
("serial: RemoveDM_FLAG_PRE_RELOCflag in various drivers"). Let's look on this check more thoroughly - we add this flag if the board doesn't supportOF_CONTROL. This is a bit strange as theserial_mxc.ccan be used withCONFIG_DM_SERIALbut without corresponding device tree description (OF_CONTROL). In such case the aforementionedU_BOOT_DEVICE(mxc_serial)definition is used.
Other boards/SoCs have this flag set unconditionally for serial driver.
Quoted 1 line
Signed-off-by Lukasz Majewski <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================