Skip to contentSkip to conversation

spice: append to CFLAGS instead of +=

PATCH New Martin Jansa 1 participant 1 message Jun 5, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spice: append to CFLAGS instead of +=

* so that -Wno-address-of-packed-member is used for all the builds not only for target builds
* with native it was overwritten with BUILD_CFLAGS and for nativesdk with BUILDSDK_CFLAGS
* this issue isn't specific for gcc-9 as the original commit said, I see nativesdk-spice failing on older hosts with gcc-7 with the same issue
* also use -Wno-error=address-of-packed-member instead of -Wno-address-of-packed-member so that there is still a warning, just not fatal for the build in combination with -Werror.

---
 meta-networking/recipes-support/spice/spice_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-support/spice/spice_git.bb +1 -1
index 6249b0422b..b0fab0d65f 100644
@@ -36,7 +36,7 @@ DEPENDS_append_class-nativesdk = "nativesdk-openssl"
 export PYTHON="${STAGING_BINDIR_NATIVE}/python-native/python"
 export PYTHONPATH="${PKG_CONFIG_SYSROOT_DIR}${libdir}/python2.7/site-packages"
 
-CFLAGS += "-Wno-address-of-packed-member"
+CFLAGS_append = " -Wno-error=address-of-packed-member"
 
 PACKAGECONFIG_class-native = ""
 PACKAGECONFIG_class-nativesdk = ""
Signature · 1 line
2.17.1