Skip to contentSkip to conversation

net: eth-uclass: No warning for using ROM MAC

PATCH New Trent Piepho 1 participant 1 message Jun 6, 2019 Networking

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: eth-uclass: No warning for using ROM MAC

Using a ROM burned in MAC address is the normal way devices that have this ability will store their MAC. It's normal operation and a warning message isn't appropriate. Make it a debug message, as it is in non-DM_ETH code paths that do this.

---
 net/eth-uclass.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
net/eth-uclass.c +1 -2
index 031d558625..dae4987355 100644
@@ -533,8 +533,7 @@ static int eth_post_probe(struct udevice *dev)
 		memcpy(pdata->enetaddr, env_enetaddr, ARP_HLEN);
 	} else if (is_valid_ethaddr(pdata->enetaddr)) {
 		eth_env_set_enetaddr_by_index("eth", dev->seq, pdata->enetaddr);
-		printf("\nWarning: %s using MAC address from ROM\n",
-		       dev->name);
+		debug("%s using MAC address from ROM\n", dev->name);
 	} else if (is_zero_ethaddr(pdata->enetaddr) ||
 		   !is_valid_ethaddr(pdata->enetaddr)) {
 #ifdef CONFIG_NET_RANDOM_ETHADDR
Signature · 1 line
2.14.5