staging: rtl8723bs: Fix Unneeded variable: "ret". Return "0"
PATCH 1/1 staging: rtl8723bs: Fix Unneeded variable: "ret". Return "0"
coccicheck reported Unneeded variable ret at rtl8723bs/core/rtw_ap.c:1400. Function "rtw_acl_remove_sta" always returns 0. Modified return type of the function to void.
Signed-off-by Shobhit Kukreti <[email protected]>
--- drivers/staging/rtl8723bs/core/rtw_ap.c | 4 +--- drivers/staging/rtl8723bs/include/rtw_ap.h | 2 +- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 3 ++- 3 files changed, 4 insertions(+), 5 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ap.c +1 -3
@@ -1394,10 +1394,9 @@ int rtw_acl_add_sta(struct adapter *padapter, u8 *addr)return ret; } -int rtw_acl_remove_sta (struct adapter *padapter,u8 *addr) +void rtw_acl_remove_sta (struct adapter *padapter,u8 *addr) {struct list_head *plist, *phead; -int ret =0 ;struct rtw_wlan_acl_node *paclnode;struct sta_priv *pstapriv = &padapter->stapriv;struct wlan_acl_pool *pacl_list = &pstapriv->acl_list;
@@ -1438,7 +1437,6 @@ int rtw_acl_remove_sta(struct adapter *padapter, u8 *addr)DBG_871X ("%s, acl_num =%d\n" , __func__, pacl_list->num); -return ret; }u8 rtw_ap_set_pairwise_key (struct adapter *padapter,struct sta_info *psta)
drivers/staging/rtl8723bs/include/rtw_ap.h +1 -1
@@ -19,7 +19,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len);void rtw_ap_restore_network (struct adapter *padapter);void rtw_set_macaddr_acl (struct adapter *padapter,int mode);int rtw_acl_add_sta (struct adapter *padapter,u8 *addr); -int rtw_acl_remove_sta (struct adapter *padapter,u8 *addr); +void rtw_acl_remove_sta (struct adapter *padapter,u8 *addr);u8 rtw_ap_set_pairwise_key (struct adapter *padapter,struct sta_info *psta);int rtw_ap_set_group_key (struct adapter *padapter,u8 *key,u8 alg,int keyid);
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +2 -1
@@ -4174,7 +4174,8 @@ static int rtw_ioctl_acl_remove_sta(struct net_device *dev, struct ieee_param *preturn -EINVAL ; } -return rtw_acl_remove_sta (padapter, param->sta_addr); +rtw_acl_remove_sta (padapter, param->sta_addr); +return 0 ; }
Signature · 1 line
2.7.4
Quoted 7 lines · Shobhit Kukreti
coccicheck reported Unneeded variable ret at
rtl8723bs/core/rtw_ap.c:1400.
Function "rtw_acl_remove_sta" always returns 0. Modified return type of the
function to void.Signed-off-by Shobhit Kukreti <[email protected]>
Looks good, thanks.
Reviewed-by Bastien Nocera <[email protected]>