staging: rtl8723bs: core: Remove variable priority
PATCH 1/1 staging: rtl8723bs: core: Remove variable priority
Remove local variable change_priority, as it takes the value of the argument priority; as both of these variables are of type u8, priority can be modified without changing the value of its copy at the call site. Issue found with Coccinelle.
Signed-off-by Nishka Dasgupta <[email protected]>
--- drivers/staging/rtl8723bs/core/rtw_xmit.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/staging/rtl8723bs/core/rtw_xmit.c +4 -6
@@ -625,13 +625,11 @@ static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *pu8 qos_acm (u8 acm_mask,u8 priority) { -u8 change_priority = priority; -switch (priority) {case 0 :case 3 :if (acm_mask &BIT (1 )) - change_priority =1 ; + priority =1 ;break ;case 1 :case 2 :
@@ -639,19 +637,19 @@ u8 qos_acm(u8 acm_mask, u8 priority)case 4 :case 5 :if (acm_mask &BIT (2 )) - change_priority =0 ; + priority =0 ;break ;case 6 :case 7 :if (acm_mask &BIT (3 )) - change_priority =5 ; + priority =5 ;break ;default :DBG_871X ("qos_acm(): invalid pattrib->priority: %d!!!\n" , priority);break ; } -return change_priority; +return priority; }static void set_qos (struct pkt_file *ppktfile,struct pkt_attrib *pattrib)
Signature · 1 line
2.19.1