usb/hcd: Fix a NULL vs IS_ERR() bug in usb_hcd_setup_local_mem()
Subsystems (2)
PATCH 1/1 usb/hcd: Fix a NULL vs IS_ERR() bug in usb_hcd_setup_local_mem()
The devm_memremap() function doesn't return NULL, it returns error pointers.
Fixes b0310c2f09bb ("USB: use genalloc for USB HCs with local memory")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/usb/core/hcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/core/hcd.c +2 -2
@@ -3052,8 +3052,8 @@ int usb_hcd_setup_local_mem(struct usb_hcd *hcd, phys_addr_t phys_addr, local_mem =devm_memremap (hcd->self.sysdev, phys_addr, size,MEMREMAP_WC ); -if (!local_mem) -return -ENOMEM ; +if (IS_ERR (local_mem)) +return PTR_ERR (local_mem);/* * Here we pass a dma_addr_t but the arg type is a phys_addr_t.
Signature · 1 line
2.20.1
Quoted 5 lines · Dan Carpenter
The
devm_memremap()function doesn't return NULL, it returns error pointers.Fixes b0310c2f09bb ("USB: use genalloc for USB HCs with local memory")Signed-off-by Dan Carpenter <[email protected]>
Sebastian