Skip to contentSkip to conversation

block: move tag field position in struct request

PATCH RESEND Applied Minwoo Im 3 participants 3 messages Jun 8, 2019 – Jun 20, 2019 Block layer

lore
Share & tools
lore

Minwoo Im

author
#0 lore raw

PATCH RESEND 1/1 block: move tag field position in struct request

__data_len and __sector are internal fields which should not be accessed directly in driver-level like the comment above it. But, tag field can be accessed by driver level directly so that we need to make the comment right by moving it to some other place.

---
 include/linux/blkdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/blkdev.h +1 -1
index 592669bcc536..90e6914bea0c 100644
@@ -137,11 +137,11 @@ struct request {
 	unsigned int cmd_flags;		/* op and common flags */
 	req_flags_t rq_flags;
 
+	int tag;
 	int internal_tag;
 
 	/* the following two fields are internal, NEVER access directly */
 	unsigned int __data_len;	/* total data len */
-	int tag;
 	sector_t __sector;		/* sector cursor */
 
 	struct bio *bio;
Signature · 1 line
2.21.0
maintainer Applied
#2 lore raw
In reply to Minwoo Im
Quoted 4 lines · Minwoo Im

__data_len and __sector are internal fields which should not be accessed directly in driver-level like the comment above it. But, tag field can be accessed by driver level directly so that we need to make the comment right by moving it to some other place.

Applied, thanks.

Signature · 1 line
Jens Axboe