ext4/035: skip this test if DAX is in use

PATCH In review Theodore Ts'o 2 participants 3 messages Jun 10, 2019

Share & tools

Theodore Ts'o

author

2019-06-10 02:43 UTC #0 lore raw

PATCH 1/1 ext4/035: skip this test if DAX is in use

This test creates a file system with a 1k block size. Since there are no architectures with a 1k page size, test file system can never be mounted with DAX enabled, causing the test to fail.

Signed-off-by Theodore Ts'o <[email protected]>

Cc Yang Xu <[email protected]>

---
 tests/ext4/035 | 1 +
 1 file changed, 1 insertion(+)

tests/ext4/035 +1 -0

index ac5f38e0..05867402 100755
@@ -36,6 +36,7 @@ _cleanup()
 _supported_fs ext4
 _supported_os Linux
 _require_scratch
+_exclude_scratch_mount_option dax
 _require_command "$RESIZE2FS_PROG" resize2fs
 
 rm -f $seqres.full

Signature · 1 line

2.22.0

Theodore Ts'o

author

2019-06-10 02:53 UTC #1 lore raw

Quoted 2 lines · Theodore Ts'o

This test creates a file system with a 1k block size. Since there are no architectures with a 1k page size, test file system can never be

s/test file system/the test file system/

Quoted 1 line

mounted with DAX enabled, causing the test to fail.

Sorry, typo.

- Ted

Yang Xu

Reviewed-by

2019-06-10 05:34 UTC #2 lore raw

Quoted 6 lines · Theodore Ts'o

Quoted 2 lines · Theodore Ts'o
This test creates a file system with a 1k block size. Since there are no architectures with a 1k page size, test file system can never be
s/test file system/the test file system/
Quoted 1 line
mounted with DAX enabled, causing the test to fail.

Looks good to me. Feel free to add:

Reviewed-by Yang Xu<[email protected]>

Quoted 6 lines

Sorry, typo.
- Ted