Skip to contentSkip to conversation

perf version: Fix segfault

PATCH Applied Ravi Bangoria 3 participants 3 messages Jun 11, 2019 – Jul 17, 2019 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf version: Fix segfault

'perf version' on powerpc segfaults when used with non-supported option:

  # perf version -a
  Segmentation fault (core dumped)

Fix this.

---
 tools/perf/builtin-version.c | 1 +
 1 file changed, 1 insertion(+)
tools/perf/builtin-version.c +1 -0
index f470144d1a70..bf114ca9ca87 100644
@@ -19,6 +19,7 @@ static struct version version;
 static struct option version_options[] = {
 	OPT_BOOLEAN(0, "build-options", &version.build_options,
 		    "display the build options"),
+	OPT_END(),
 };
 
 static const char * const version_usage[] = {
Signature · 1 line
2.20.1
#1 lore raw

Em Tue, Jun 11, 2019 at 08:31:09AM +0530, Ravi Bangoria escreveu:

Quoted 19 lines

'perf version' on powerpc segfaults when used with non-supported option:

  # perf version -a
  Segmentation fault (core dumped)

Fix this.

---
 tools/perf/builtin-version.c | 1 +
 1 file changed, 1 insertion(+)
tools/perf/builtin-version.c +0 -0
index f470144d1a70..bf114ca9ca87 100644

tools/perf/builtin-version.c static struct version version; · line 23

Quoted 5 lines
tools/perf/builtin-version.c +1 -0
@@ -19,6 +19,7 @@ static struct version version;
 static struct option version_options[] = {
 	OPT_BOOLEAN(0, "build-options", &version.build_options,
 		    "display the build options"),
+	OPT_END(),
 };

Thanks, applied.

- Arnaldo

#2 lore raw

[tip:perf/urgent] perf version: Fix segfault due to missing OPT_END()

In reply to Ravi Bangoria
perf version: Fix segfault due to missing OPT_END()
Commit-ID:  916c31fff946fae0e05862f9b2435fdb29fd5090
Gitweb:     https://git.kernel.org/tip/916c31fff946fae0e05862f9b2435fdb29fd5090
Author:     Ravi Bangoria <[email protected]>
AuthorDate: Tue, 11 Jun 2019 08:31:09 +0530
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 15 Jul 2019 07:59:05 -0300

perf version: Fix segfault due to missing OPT_END()

'perf version' on powerpc segfaults when used with non-supported option:

  # perf version -a
  Segmentation fault (core dumped)

Fix this.

---
 tools/perf/builtin-version.c | 1 +
 1 file changed, 1 insertion(+)
tools/perf/builtin-version.c +1 -0
index f470144d1a70..bf114ca9ca87 100644
@@ -19,6 +19,7 @@ static struct version version;
 static struct option version_options[] = {
 	OPT_BOOLEAN(0, "build-options", &version.build_options,
 		    "display the build options"),
+	OPT_END(),
 };
 
 static const char * const version_usage[] = {