Skip to contentSkip to conversation

genwq: no need to check return value of debugfs_create functions

PATCH In review Greg Kroah-Hartman 2 participants 2 messages Jun 11, 2019 – Jun 12, 2019

Subsystems (2)
lore
Share & tools
lore

Greg Kroah-Hartman

author maintainer
#0 lore raw

PATCH 1/1 genwq: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.

---
 drivers/misc/genwqe/card_base.c    |   5 -
 drivers/misc/genwqe/card_base.h    |   2 +-
 drivers/misc/genwqe/card_debugfs.c | 165 ++++++-----------------------
 drivers/misc/genwqe/card_dev.c     |   6 +-
 4 files changed, 32 insertions(+), 146 deletions(-)
drivers/misc/genwqe/card_base.c +0 -5
index d137d0fab9bf..f9f329651037 100644
@@ -1377,10 +1377,6 @@ static int __init genwqe_init_module(void)
 	class_genwqe->devnode = genwqe_devnode;
 
 	debugfs_genwqe = debugfs_create_dir(GENWQE_DEVNAME, NULL);
-	if (!debugfs_genwqe) {
-		rc = -ENOMEM;
-		goto err_out;
-	}
 
 	rc = pci_register_driver(&genwqe_driver);
 	if (rc != 0) {
@@ -1392,7 +1388,6 @@ static int __init genwqe_init_module(void)
 
  err_out0:
 	debugfs_remove(debugfs_genwqe);
- err_out:
 	class_destroy(class_genwqe);
 	return rc;
 }
drivers/misc/genwqe/card_base.h +1 -1
index 77ed3967c5b0..d9e4a6e5fe3c 100644
@@ -445,7 +445,7 @@ int  genwqe_device_create(struct genwqe_dev *cd);
 int  genwqe_device_remove(struct genwqe_dev *cd);
 
 /* debugfs */
-int  genwqe_init_debugfs(struct genwqe_dev *cd);
+void genwqe_init_debugfs(struct genwqe_dev *cd);
 void genqwe_exit_debugfs(struct genwqe_dev *cd);
 
 int  genwqe_read_softreset(struct genwqe_dev *cd);
drivers/misc/genwqe/card_debugfs.c +30 -135

194 lines not on this page · raw message

drivers/misc/genwqe/card_dev.c +1 -5
index 8c1b63a4337b..b5942e8943ef 100644
@@ -1307,14 +1307,10 @@ int genwqe_device_create(struct genwqe_dev *cd)
 		goto err_cdev;
 	}
 
-	rc = genwqe_init_debugfs(cd);
-	if (rc != 0)
-		goto err_debugfs;
+	genwqe_init_debugfs(cd);
 
 	return 0;
 
- err_debugfs:
-	device_destroy(cd->class_genwqe, cd->devnum_genwqe);
  err_cdev:
 	cdev_del(&cd->cdev_genwqe);
  err_add:
Signature · 1 line
2.22.0