Skip to contentSkip to conversation

drivers: regulator: 88pm800: fix warning same module names

PATCH In review Anders Roxell 2 participants 5 messages Jun 12, 2019 Voltage and current regulator framework

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drivers: regulator: 88pm800: fix warning same module names

When building with CONFIG_MFD_88PM800 and CONFIG_REGULATOR_88PM800 enabled as loadable modules, we see the following warning:

warning: same module names found:
drivers/regulator/88pm800.ko
drivers/mfd/88pm800.ko

Rework so that the file is named 88pm800-regulator.

---
 drivers/regulator/{88pm800.c => 88pm800-regulator.c} | 0
 drivers/regulator/Makefile                           | 2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename drivers/regulator/{88pm800.c => 88pm800-regulator.c} (100%)
drivers/regulator/88pm800-regulator.c renamed from drivers/regulator/88pm800.c +0 -0
similarity index 100%
rename from drivers/regulator/88pm800.c
rename to drivers/regulator/88pm800-regulator.c
drivers/regulator/Makefile +1 -1
index 76e78fa449a2..c15b0b613766 100644
@@ -11,7 +11,7 @@ obj-$(CONFIG_REGULATOR_VIRTUAL_CONSUMER) += virtual.o
 obj-$(CONFIG_REGULATOR_USERSPACE_CONSUMER) += userspace-consumer.o
 
 obj-$(CONFIG_REGULATOR_88PG86X) += 88pg86x.o
-obj-$(CONFIG_REGULATOR_88PM800) += 88pm800.o
+obj-$(CONFIG_REGULATOR_88PM800) += 88pm800-regulator.o
 obj-$(CONFIG_REGULATOR_88PM8607) += 88pm8607.o
 obj-$(CONFIG_REGULATOR_CPCAP) += cpcap-regulator.o
 obj-$(CONFIG_REGULATOR_AAT2870) += aat2870-regulator.o
Signature · 1 line
2.20.1
maintainer
#1 lore raw
Quoted 2 lines · Anders Roxell

When building with CONFIG_MFD_88PM800 and CONFIG_REGULATOR_88PM800 enabled as loadable modules, we see the following warning:

Please use subject lines matching the style for the subsystem. This makes it easier for people to identify relevant patches.

#2 lore raw
Quoted 7 lines · Mark Brown
Quoted 2 lines · Anders Roxell

When building with CONFIG_MFD_88PM800 and CONFIG_REGULATOR_88PM800 enabled as loadable modules, we see the following warning:

Please use subject lines matching the style for the subsystem. This makes it easier for people to identify relevant patches.

I should have payed more attention, sorry.

Do you want me to send a v3 to fix the subject line for this patch?

Cheers,
Anders

maintainer
#3 lore raw
Quoted 8 lines · Anders Roxell
Quoted 2 lines · Mark Brown

Please use subject lines matching the style for the subsystem. This makes it easier for people to identify relevant patches.

I should have payed more attention, sorry.

Do you want me to send a v3 to fix the subject line for this patch?

It's OK, I fixed it up by hand.

maintainer
#4 lore raw

Applied "regulator: 88pm800: fix warning same module names" to the regulator tree

In reply to Anders Roxell

The patch

regulator: 88pm800: fix warning same module names

has been applied to the regulator tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.3

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

From 6f10419187d0d5fe395e2a2f2a64370961bf02a3 Mon Sep 17 00:00:00 2001
From: Anders Roxell <[email protected]>
Date: Wed, 12 Jun 2019 10:11:58 +0200
Subject: [PATCH] regulator: 88pm800: fix warning same module names

When building with CONFIG_MFD_88PM800 and CONFIG_REGULATOR_88PM800 enabled as loadable modules, we see the following warning:

warning: same module names found:
drivers/regulator/88pm800.ko
drivers/mfd/88pm800.ko

Rework so that the file is named 88pm800-regulator.

---
 drivers/regulator/{88pm800.c => 88pm800-regulator.c} | 0
 drivers/regulator/Makefile                           | 2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename drivers/regulator/{88pm800.c => 88pm800-regulator.c} (100%)
drivers/regulator/88pm800-regulator.c renamed from drivers/regulator/88pm800.c +0 -0
similarity index 100%
rename from drivers/regulator/88pm800.c
rename to drivers/regulator/88pm800-regulator.c
drivers/regulator/Makefile +1 -1
index 76e78fa449a2..c15b0b613766 100644
@@ -11,7 +11,7 @@ obj-$(CONFIG_REGULATOR_VIRTUAL_CONSUMER) += virtual.o
 obj-$(CONFIG_REGULATOR_USERSPACE_CONSUMER) += userspace-consumer.o
 
 obj-$(CONFIG_REGULATOR_88PG86X) += 88pg86x.o
-obj-$(CONFIG_REGULATOR_88PM800) += 88pm800.o
+obj-$(CONFIG_REGULATOR_88PM800) += 88pm800-regulator.o
 obj-$(CONFIG_REGULATOR_88PM8607) += 88pm8607.o
 obj-$(CONFIG_REGULATOR_CPCAP) += cpcap-regulator.o
 obj-$(CONFIG_REGULATOR_AAT2870) += aat2870-regulator.o
Signature · 1 line
2.20.1