swiotlb: no need to check return value of debugfs_create functions
PATCH 1/1 swiotlb: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Konrad Rzeszutek Wilk <[email protected]>
Cc Christoph Hellwig <[email protected]>
Cc Marek Szyprowski <[email protected]>
Cc Robin Murphy <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
--- kernel/dma/swiotlb.c | 25 ++++--------------------- 1 file changed, 4 insertions(+), 21 deletions(-)
kernel/dma/swiotlb.c +4 -21
@@ -696,29 +696,12 @@ bool is_swiotlb_active(void)static int __init swiotlb_create_debugfs (void ) { -struct dentry *d_swiotlb_usage; -struct dentry *ent; - - d_swiotlb_usage =debugfs_create_dir ("swiotlb" ,NULL ); - -if (!d_swiotlb_usage) -return -ENOMEM ; - - ent =debugfs_create_ulong ("io_tlb_nslabs" ,0400 , - d_swiotlb_usage, &io_tlb_nslabs); -if (!ent) - goto fail; - - ent =debugfs_create_ulong ("io_tlb_used" ,0400 , - d_swiotlb_usage, &io_tlb_used); -if (!ent) - goto fail; +struct dentry *root; + root =debugfs_create_dir ("swiotlb" ,NULL ); +debugfs_create_ulong ("io_tlb_nslabs" ,0400 , root, &io_tlb_nslabs); +debugfs_create_ulong ("io_tlb_used" ,0400 , root, &io_tlb_used);return 0 ; - -fail: -debugfs_remove_recursive (d_swiotlb_usage); -return -ENOMEM ; }late_initcall (swiotlb_create_debugfs);
Signature · 6 lines
2.22.0 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu