Skip to contentSkip to conversation

lib: 842: no need to check return value of debugfs_create functions

PATCH New Greg Kroah-Hartman 1 participant 1 message Jun 12, 2019 IBM Power 842 compression accelerator

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib: 842: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.

---
 lib/842/842_debugfs.h | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
lib/842/842_debugfs.h +1 -4
index 277e403e8701..4469407c3e0d 100644
@@ -22,8 +22,6 @@ static int __init sw842_debugfs_create(void)
 		return -ENODEV;
 
 	sw842_debugfs_root = debugfs_create_dir(MODULE_NAME, NULL);
-	if (IS_ERR(sw842_debugfs_root))
-		return PTR_ERR(sw842_debugfs_root);
 
 	for (i = 0; i < ARRAY_SIZE(template_count); i++) {
 		char name[32];
@@ -46,8 +44,7 @@ static int __init sw842_debugfs_create(void)
 
 static void __exit sw842_debugfs_remove(void)
 {
-	if (sw842_debugfs_root && !IS_ERR(sw842_debugfs_root))
-		debugfs_remove_recursive(sw842_debugfs_root);
+	debugfs_remove_recursive(sw842_debugfs_root);
 }
 
 #endif
Signature · 1 line
2.22.0