Skip to contentSkip to conversation

usb: gadget: u_audio: Fixed variable declaration coding style issue

PATCH In review Jonas Stenvall 2 participants 2 messages Jun 13, 2019 USB

lore
Share & tools
lore
Reviewed-by on v1 1/1
#1 lore raw
In reply to Jonas Stenvall

Hi Jonas,

Quoted 1 line · Jonas Stenvall

Fixed a coding style issue, replacing unsigned with unsigned int.

No concerns on my side. FWIW, the 'bare use of unsigned' coding style inconsistency is quite common in the USB gadget framework [1-2].

Depending on the feedback from the maintainers, I see below potential outcomes for this patch (sorted by my personal estimation of chance):
- we take it and we fix the rest on best-effort basis.
- we kindly ask you to fix the issue globally in USB gadget space.
- we don't care, as this is not a functional issue. We rather prefer to concentrate on functional problems.

Deciding on the above is a matter of maintainer's preference.

Quoted 5 lines
---
 drivers/usb/gadget/function/u_audio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

From my end:

[1] git grep -E "unsigned [^(int|short|char|long)]" -- drivers/usb/gadget/function | wc -l 32
[2] git grep -E "unsigned [^(int|short|char|long)]" -- drivers/usb/gadget | wc -l 99

Signature · 2 lines
Best Regards,
Eugeniu.
#0 lore raw

PATCH 1/1 usb: gadget: u_audio: Fixed variable declaration coding style issue

Fixed a coding style issue, replacing unsigned with unsigned int.

---
 drivers/usb/gadget/function/u_audio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/gadget/function/u_audio.c +2 -2
index fb5ed97572e5..56906d15fb55 100644
@@ -40,7 +40,7 @@ struct uac_rtd_params {
 
 	void *rbuf;
 
-	unsigned max_psize;	/* MaxPacketSize of endpoint */
+	unsigned int max_psize;	/* MaxPacketSize of endpoint */
 	struct uac_req *ureq;
 
 	spinlock_t lock;
@@ -78,7 +78,7 @@ static const struct snd_pcm_hardware uac_pcm_hardware = {
 
 static void u_audio_iso_complete(struct usb_ep *ep, struct usb_request *req)
 {
-	unsigned pending;
+	unsigned int pending;
 	unsigned long flags, flags2;
 	unsigned int hw_ptr;
 	int status = req->status;
Signature · 1 line
2.17.1