vc4: no need to check return value of debugfs_create functions
Subsystems (3)
PATCH 1/1 vc4: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Eric Anholt <[email protected]>
Cc David Airlie <[email protected]>
Cc Daniel Vetter <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
--- drivers/gpu/drm/vc4/vc4_debugfs.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/gpu/drm/vc4/vc4_debugfs.c +2 -6
@@ -29,13 +29,9 @@ vc4_debugfs_init(struct drm_minor *minor) {struct vc4_dev *vc4 =to_vc4_dev (minor->dev);struct vc4_debugfs_info_entry *entry; -struct dentry *dentry; - dentry =debugfs_create_bool ("hvs_load_tracker" ,S_IRUGO |S_IWUSR , - minor->debugfs_root, - &vc4->load_tracker_enabled); -if (!dentry) -return -ENOMEM ; +debugfs_create_bool ("hvs_load_tracker" ,S_IRUGO |S_IWUSR , + minor->debugfs_root, &vc4->load_tracker_enabled);list_for_each_entry (entry, &vc4->debugfs_list, link) { int ret = drm_debugfs_create_files(&entry->info, 1,
Signature · 6 lines
2.22.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Eric Anholt
AppliedQuoted 3 lines · Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Applied to drm-misc-next. Thanks!
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel