nouveau: no need to check return value of debugfs_create functions
Subsystems (3)
PATCH 1/1 nouveau: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Ben Skeggs <[email protected]>
Cc David Airlie <[email protected]>
Cc Daniel Vetter <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
--- drivers/gpu/drm/nouveau/nouveau_debugfs.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
drivers/gpu/drm/nouveau/nouveau_debugfs.c +4 -8
@@ -224,14 +224,10 @@ nouveau_drm_debugfs_init(struct drm_minor *minor)struct dentry *dentry;int i, ret; -for (i =0 ; i <ARRAY_SIZE (nouveau_debugfs_files); i++) { - dentry =debugfs_create_file (nouveau_debugfs_files[i].name, -S_IRUGO |S_IWUSR , - minor->debugfs_root, minor->dev, - nouveau_debugfs_files[i].fops); -if (!dentry) -return -ENOMEM ; - } +for (i =0 ; i <ARRAY_SIZE (nouveau_debugfs_files); i++) +debugfs_create_file (nouveau_debugfs_files[i].name, +S_IRUGO |S_IWUSR , minor->debugfs_root, + minor->dev, nouveau_debugfs_files[i].fops); ret = drm_debugfs_create_files(nouveau_debugfs_list, NOUVEAU_DEBUGFS_ENTRIES,
Signature · 6 lines
2.22.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel