thermal: intel: no need to check return value of debugfs_create functions
PATCH 1/1 thermal: intel: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Zhang Rui <[email protected]>
Cc Eduardo Valentin <[email protected]>
Cc Daniel Lezcano <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
--- drivers/thermal/intel/x86_pkg_temp_thermal.c | 25 ++++---------------- 1 file changed, 5 insertions(+), 20 deletions(-)
drivers/thermal/intel/x86_pkg_temp_thermal.c +5 -20
@@ -87,29 +87,14 @@ static struct dentry *debugfs;static unsigned int pkg_interrupt_cnt;static unsigned int pkg_work_cnt; -static int pkg_temp_debugfs_init (void ) +static void pkg_temp_debugfs_init (void ) { -struct dentry *d; - debugfs =debugfs_create_dir ("pkg_temp_thermal" ,NULL ); -if (!debugfs) -return -ENOENT ; - - d =debugfs_create_u32 ("pkg_thres_interrupt" ,S_IRUGO , debugfs, - &pkg_interrupt_cnt); -if (!d) - goto err_out; - - d =debugfs_create_u32 ("pkg_thres_work" ,S_IRUGO , debugfs, - &pkg_work_cnt); -if (!d) - goto err_out; -return 0 ; - -err_out: -debugfs_remove_recursive (debugfs); -return -ENOENT ; +debugfs_create_u32 ("pkg_thres_interrupt" ,S_IRUGO , debugfs, + &pkg_interrupt_cnt); +debugfs_create_u32 ("pkg_thres_work" ,S_IRUGO , debugfs, + &pkg_work_cnt); }/*
Signature · 1 line
2.22.0
Quoted 9 lines · Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Zhang Rui <[email protected]>Cc Eduardo Valentin <[email protected]>Cc Daniel Lezcano <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Reviewed-by Daniel Lezcano <[email protected]>
Quoted 44 lines
--- drivers/thermal/intel/x86_pkg_temp_thermal.c | 25 ++++---------------- 1 file changed, 5 insertions(+), 20 deletions(-)drivers/thermal/intel/x86_pkg_temp_thermal.c +5
-20@@ -87,29 +87,14 @@ static struct dentry *debugfs;static unsigned int pkg_interrupt_cnt;static unsigned int pkg_work_cnt; -static int pkg_temp_debugfs_init (void ) +static void pkg_temp_debugfs_init (void ) { -struct dentry *d; - debugfs =debugfs_create_dir ("pkg_temp_thermal" ,NULL ); -if (!debugfs) -return -ENOENT ; - - d =debugfs_create_u32 ("pkg_thres_interrupt" ,S_IRUGO , debugfs, - &pkg_interrupt_cnt); -if (!d) - goto err_out; - - d =debugfs_create_u32 ("pkg_thres_work" ,S_IRUGO , debugfs, - &pkg_work_cnt); -if (!d) - goto err_out; -return 0 ; - -err_out: -debugfs_remove_recursive (debugfs); -return -ENOENT ; +debugfs_create_u32 ("pkg_thres_interrupt" ,S_IRUGO , debugfs, + &pkg_interrupt_cnt); +debugfs_create_u32 ("pkg_thres_work" ,S_IRUGO , debugfs, + &pkg_work_cnt); }/*
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog