platform/x86: intel_pmc_core: Add ICL-NNPI support to PMC Core
PATCH 1/1 platform/x86: intel_pmc_core: Add ICL-NNPI support to PMC Core
Ice Lake Neural Network Processor for deep learning inference a.k.a. ICL-NNPI can re-use Ice Lake Mobile regmap to enable Intel PMC Core driver on it.
--- drivers/platform/x86/intel_pmc_core.c | 1 + 1 file changed, 1 insertion(+)
drivers/platform/x86/intel_pmc_core.c +1 -0
@@ -815,6 +815,7 @@ static const struct x86_cpu_id intel_pmc_core_ids[] = {INTEL_CPU_FAM6 (KABYLAKE_DESKTOP , spt_reg_map),INTEL_CPU_FAM6 (CANNONLAKE_MOBILE , cnp_reg_map),INTEL_CPU_FAM6 (ICELAKE_MOBILE , icl_reg_map), + INTEL_CPU_FAM6(ICELAKE_NNPI, icl_reg_map), {} };
Signature · 1 line
2.17.1
Quoted 5 lines · Rajneesh Bhardwaj
Ice Lake Neural Network Processor for deep learning inference a.k.a. ICL-NNPI can re-use Ice Lake Mobile regmap to enable Intel PMC Core driver on it.
This will be postponed till next cycle since the CPU model will not appear before merge window.
So, please, resend than (I guess somewhat in a month).
Quoted 24 lines
Cc Darren Hart <[email protected]>Cc Andy Shevchenko <[email protected]>Signed-off-by Rajneesh Bhardwaj <[email protected]>--- drivers/platform/x86/intel_pmc_core.c | 1 + 1 file changed, 1 insertion(+)drivers/platform/x86/intel_pmc_core.c +1
-1@@ -815,6 +815,7 @@ static const struct x86_cpu_id intel_pmc_core_ids[] = {INTEL_CPU_FAM6 (KABYLAKE_DESKTOP , spt_reg_map),INTEL_CPU_FAM6 (CANNONLAKE_MOBILE , cnp_reg_map),INTEL_CPU_FAM6 (ICELAKE_MOBILE , icl_reg_map), + INTEL_CPU_FAM6(ICELAKE_NNPI, icl_reg_map), {} }; --2.17.1
Signature · 2 lines
With Best Regards, Andy Shevchenko
Hi Andy
Quoted 9 lines · Andy Shevchenko
Quoted 4 lines · Rajneesh Bhardwaj
Ice Lake Neural Network Processor for deep learning inference a.k.a. ICL-NNPI can re-use Ice Lake Mobile regmap to enable Intel PMC Core driver on it.
This will be postponed till next cycle since the CPU model will not appear before merge window.
So, please, resend than (I guess somewhat in a month).
The dependent CPUID Patch is now upstream, https://github.com/torvalds/linux/blob/bed38c3e2dca01b358a62b5e73b46e875742fd75/arch/x86/include/asm/intel-family.h#L59 so can you please apply this one?
Thank you
Rajneesh
Quoted 26 lines
Quoted 25 lines
Cc Darren Hart <[email protected]>Cc Andy Shevchenko <[email protected]>Signed-off-by Rajneesh Bhardwaj <[email protected]>--- drivers/platform/x86/intel_pmc_core.c | 1 + 1 file changed, 1 insertion(+)drivers/platform/x86/intel_pmc_core.c +1
-1@@ -815,6 +815,7 @@ static const struct x86_cpu_id intel_pmc_core_ids[] = {INTEL_CPU_FAM6 (KABYLAKE_DESKTOP , spt_reg_map),INTEL_CPU_FAM6 (CANNONLAKE_MOBILE , cnp_reg_map),INTEL_CPU_FAM6 (ICELAKE_MOBILE , icl_reg_map), + INTEL_CPU_FAM6(ICELAKE_NNPI, icl_reg_map), {} }; --2.17.1
Quoted 10 lines · Rajneesh
Hi Andy
Quoted 6 lines · Andy Shevchenko
Quoted 4 lines · Rajneesh Bhardwaj
Ice Lake Neural Network Processor for deep learning inference a.k.a. ICL-NNPI can re-use Ice Lake Mobile regmap to enable Intel PMC Core driver on it.
Quoted 8 lines
Quoted 3 lines
This will be postponed till next cycle since the CPU model will not appear before merge window.
So, please, resend than (I guess somewhat in a month).The dependent CPUID Patch is now upstream,
https://github.com/torvalds/linux/blob/bed38c3e2dca01b358a62b5e73b46e875742fd75/arch/x86/include/asm/intel-family.h#L59
so can you please apply this one?
Yes, it's in plan for rc2.
Signature · 2 lines
With Best Regards, Andy Shevchenko