staging: rtl8723bs: hal: Remove return type of initrecvbuf
PATCH 1/1 staging: rtl8723bs: hal: Remove return type of initrecvbuf
change return of initrecvbuf from s32 to void. As this function always returns SUCCESS .
fix checkpatch warning "Comparison to false is error prone"
Signed-off-by Hariprasad Kelam <[email protected]>
--- drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c +3 -7
@@ -10,14 +10,12 @@#include <rtw_debug.h> #include <rtl8723b_hal.h> -static s32 initrecvbuf (struct recv_buf *precvbuf,struct adapter *padapter) +static void initrecvbuf (struct recv_buf *precvbuf,struct adapter *padapter) {INIT_LIST_HEAD (&precvbuf->list);spin_lock_init (&precvbuf->recvbuf_lock); precvbuf->adapter = padapter; - -return _SUCCESS; } static void update_recvframe_attrib(struct adapter *padapter,
@@ -177,7 +175,7 @@ static void rtl8723bs_c2h_packet_handler(struct adapter *padapter, res =rtw_c2h_packet_wk_cmd (padapter, tmp, length); -if (res == false) +if (!res)kfree (tmp);/* DBG_871X("-%s res(%d)\n", __func__, res); */
@@ -435,9 +433,7 @@ s32 rtl8723bs_init_recv_priv(struct adapter *padapter)/* init each recv buffer */ precvbuf = (struct recv_buf *)precvpriv->precv_buf;for (i =0 ; i <NR_RECVBUFF ; i++) { - res =initrecvbuf (precvbuf, padapter); -if (res == _FAIL) -break ; +initrecvbuf (precvbuf, padapter);if (!precvbuf->pskb) {SIZE_PTR tmpaddr =0 ;
Signature · 1 line
2.7.4
Greg Kroah-Hartman
maintainerQuoted 4 lines · Hariprasad Kelam
change return of initrecvbuf from s32 to void. As this function always returns SUCCESS .
fix checkpatch warning "Comparison to false is error prone"
That is doing multiple things in the same patch, please break this up :(