iommu: fix integer truncation
Subsystems (2)
PATCH 1/1 iommu: fix integer truncation
On 32-bit architectures, phys_addr_t may be different from dma_add_t, both smaller and bigger. This can lead to an overflow during an assignment that clang warns about:
drivers/iommu/dma-iommu.c:230:10: error: implicit conversion from 'dma_addr_t' (aka 'unsigned long long') to
'phys_addr_t' (aka 'unsigned int') changes value from 18446744073709551615 to 4294967295 [-Werror,-Wconstant-conversion]
Use phys_addr_t here because that is the type that the variable was declared as.
--- drivers/iommu/dma-iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iommu/dma-iommu.c +2 -2
@@ -226,8 +226,8 @@ static int iova_reserve_pci_windows(struct pci_dev *dev, start = window->res->end - window->offset +1 ;/* If window is last entry */ if (window->node.next == &bridge->dma_ranges && - end != ~(dma_addr_t )0 ) { - end = ~(dma_addr_t )0 ; + end != ~(phys_addr_t )0 ) { + end = ~(phys_addr_t )0 ; goto resv_iova; } }
Signature · 1 line
2.20.0
Joerg Roedel
maintainerQuoted 4 lines · Arnd Bergmann
On 32-bit architectures,
phys_addr_tmay be different fromdma_add_t, both smaller and bigger. This can lead to an overflow during an assignment that clang warns about:
Quoted 8 lines
drivers/iommu/dma-iommu.c:230:10: error: implicit conversion from 'dma_addr_t' (aka 'unsigned long long') to'phys_addr_t' (aka 'unsigned int') changes value from 18446744073709551615 to 4294967295 [-Werror,-Wconstant-conversion]Use
phys_addr_there because that is the type that the variable was declared as.Fixes aadad097cd46 ("iommu/dma: Reserve IOVA for PCIe inaccessible DMA address")Signed-off-by Arnd Bergmann <[email protected]>
Applied, thanks.
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu