lib/igt_eld: fix potential read from undefined value

PATCH In review Simon Ser 3 participants 6 messages Jun 18, 2019 – Jun 19, 2019 Library code

Share & tools

Simon Ser

author

2019-06-18 12:55 UTC #0 lore raw

PATCH 1/2 lib/igt_eld: fix potential read from undefined value

If the ELD doesn't contain a monitor_present line (this shouldn't happen), then the value is garbage. Define the variable as a safety net.

Signed-off-by Simon Ser <[email protected]>

---
 lib/igt_eld.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

lib/igt_eld.c +1 -1

index 15dd8ac95189..3d7fd4dd0a82 100644
@@ -152,7 +152,7 @@ static bool eld_parse_entry(const char *path, struct eld_entry *eld)
 	char buf[1024];
 	char *key, *value, *sad_key;
 	size_t len;
-	bool monitor_present;
+	bool monitor_present = false;
 	int sad_index;
 
 	memset(eld, 0, sizeof(*eld));

Signature · 6 lines

2.22.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Simon Ser

author

2019-06-18 12:55 UTC #1 lore raw

PATCH 2/2 tests/kms_chamelium: fix read from uninitialized value in flatline audio test

streak isn't initialized, which makes the test fail in the case in which it's not zero by chance. This bug has been seen in production™.

Signed-off-by Simon Ser <[email protected]>

---
 tests/kms_chamelium.c | 1 +
 1 file changed, 1 insertion(+)

tests/kms_chamelium.c +1 -0

index 94438e9ae0fc..378024d8fd05 100644
@@ -1237,6 +1237,7 @@ static bool test_audio_flatline(struct audio_state *state)
 	recv = NULL;
 	recv_len = 0;
 	amp_success = false;
+	streak = 0;
 	while (!amp_success && state->msec < AUDIO_TIMEOUT) {
 		audio_state_receive(state, &recv, &recv_len);

Signature · 6 lines

2.22.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Peres, Martin

Reviewed-by Martin Peres on v1 2/2

2019-06-18 13:01 UTC #2 lore raw

Re: [igt-dev] [PATCH i-g-t 2/2] tests/kms_chamelium: fix read from uninitialized value in flatline audio test

Quoted 4 lines · Simon

streak isn't initialized, which makes the test fail in the case in which it's not zero by chance. This bug has been seen in production™.
Signed-off-by Simon Ser <[email protected]>

Reviewed-by Martin Peres <[email protected]>

Quoted 10 lines

---
 tests/kms_chamelium.c | 1 +
 1 file changed, 1 insertion(+)

tests/kms_chamelium.c +0 -0

index 94438e9ae0fc..378024d8fd05 100644

tests/kms_chamelium.c static bool test_audio_flatline(struct audio_state *state) · line 1243

Quoted 7 lines

tests/kms_chamelium.c +1 -0

@@ -1237,6 +1237,7 @@ static bool test_audio_flatline(struct audio_state *state)
 	recv = NULL;
 	recv_len = 0;
 	amp_success = false;
+	streak = 0;
 	while (!amp_success && state->msec < AUDIO_TIMEOUT) {
 		audio_state_receive(state, &recv, &recv_len);

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Peres, Martin

Reviewed-by Martin Peres on v1 1/2

2019-06-18 13:01 UTC #3 lore raw

In reply to Simon Ser

Quoted 4 lines · Simon

If the ELD doesn't contain a monitor_present line (this shouldn't happen), then the value is garbage. Define the variable as a safety net.
Signed-off-by Simon Ser <[email protected]>

Reviewed-by Martin Peres <[email protected]>

Quoted 10 lines

---
 lib/igt_eld.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

lib/igt_eld.c +0 -0

index 15dd8ac95189..3d7fd4dd0a82 100644

lib/igt_eld.c static bool eld_parse_entry(const char *path, struct eld_entry *eld) · line 158

Quoted 8 lines

lib/igt_eld.c +1 -1

@@ -152,7 +152,7 @@ static bool eld_parse_entry(const char *path, struct eld_entry *eld)
 	char buf[1024];
 	char *key, *value, *sad_key;
 	size_t len;
-	bool monitor_present;
+	bool monitor_present = false;
 	int sad_index;
 
 	memset(eld, 0, sizeof(*eld));

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2019-06-18 14:18 UTC #4 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib/igt_eld: fix potential read from undefined value

In reply to Simon Ser

== Series Details ==

Series: series starting with [i-g-t,1/2] lib/igt_eld: fix potential read from undefined value
URL : https://patchwork.freedesktop.org/series/62305/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6291 -> IGTPW_3172
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/62305/revisions/1/mbox/

Known issues
------------

Here are the changes found in IGTPW_3172 that come from known issues:

### IGT changes ###

#### Possible fixes ####

* igt@gem_mmap_gtt@basic-short:
- fi-icl-u3: [DMESG-WARN][1] ([fdo#107724]) -> [PASS][2] +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/fi-icl-u3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/fi-icl-u3/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u2: [FAIL][3] ([fdo#103167]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/fi-icl-u2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/fi-icl-u2/igt@[email protected]

[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724

Participating hosts (48 -> 36)
------------------------------

Missing (12): fi-kbl-soraka fi-cml-u2 fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-ivb-3770 fi-icl-y fi-byt-clapper fi-bdw-samus fi-cml-u

Build changes
-------------

* IGT: IGT_5059 -> IGTPW_3172

CI_DRM_6291: 30a8dd688b1e9b56df650976b5058da5022dcfb8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3172: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/
IGT_5059: 1f67ee0d09d6513f487f2be74aae9700e755258a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2019-06-19 02:16 UTC #5 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] lib/igt_eld: fix potential read from undefined value

In reply to Simon Ser

== Series Details ==

Series: series starting with [i-g-t,1/2] lib/igt_eld: fix potential read from undefined value
URL : https://patchwork.freedesktop.org/series/62305/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6291_full -> IGTPW_3172_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/62305/revisions/1/mbox/

Known issues
------------

Here are the changes found in IGTPW_3172_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_eio@in-flight-suspend:
- shard-kbl: [PASS][1] -> [DMESG-WARN][2] ([fdo#110913 ]) +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-kbl2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-kbl7/igt@[email protected]

* igt@gem_exec_balancer@smoke:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#110854])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-iclb2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-iclb7/igt@[email protected]

* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
- shard-snb: [PASS][5] -> [DMESG-WARN][6] ([fdo#110789] / [fdo#110913 ])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-snb2/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-snb5/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html

* igt@gem_persistent_relocs@forked-thrash-inactive:
- shard-snb: [PASS][7] -> [INCOMPLETE][8] ([fdo#105411])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-snb1/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-snb1/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-apl: [PASS][9] -> [DMESG-WARN][10] ([fdo#110913 ]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-apl8/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-apl6/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-snb: [PASS][11] -> [DMESG-WARN][12] ([fdo#110913 ])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-snb6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-snb7/igt@[email protected]

* igt@i915_pm_rpm@i2c:
- shard-iclb: [PASS][13] -> [INCOMPLETE][14] ([fdo#107713] / [fdo#108840])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-iclb4/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-iclb2/igt@[email protected]

* igt@i915_pm_rpm@legacy-planes:
- shard-iclb: [PASS][15] -> [INCOMPLETE][16] ([fdo#107713] / [fdo#108840] / [fdo#109960])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-iclb1/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-iclb2/igt@[email protected]

* igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
- shard-hsw: [PASS][17] -> [SKIP][18] ([fdo#109271]) +14 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-hsw6/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-hsw1/igt@[email protected]

* igt@kms_flip@dpms-vs-vblank-race-interruptible:
- shard-hsw: [PASS][19] -> [INCOMPLETE][20] ([fdo#103540])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-hsw6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-hsw2/igt@[email protected]

* igt@kms_flip@flip-vs-suspend:
- shard-apl: [PASS][21] -> [DMESG-WARN][22] ([fdo#108566]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-apl1/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-apl7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
- shard-kbl: [PASS][23] -> [FAIL][24] ([fdo#103167])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-kbl2/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-kbl3/igt@[email protected]
- shard-apl: [PASS][25] -> [FAIL][26] ([fdo#103167])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-apl4/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-apl2/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [PASS][27] -> [FAIL][28] ([fdo#103167]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109642])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-iclb2/igt@kms_psr2_su@page_flip.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-iclb7/igt@kms_psr2_su@page_flip.html

* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109441]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-iclb5/igt@kms_psr@psr2_sprite_mmap_gtt.html

* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-glk: [PASS][33] -> [DMESG-FAIL][34] ([fdo#105763] / [fdo#106538])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-glk9/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-glk9/igt@[email protected]

* igt@kms_setmode@basic:
- shard-hsw: [PASS][35] -> [FAIL][36] ([fdo#99912])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-hsw1/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-hsw8/igt@[email protected]
- shard-kbl: [PASS][37] -> [FAIL][38] ([fdo#99912])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-kbl3/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-kbl4/igt@[email protected]

* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-kbl: [PASS][39] -> [INCOMPLETE][40] ([fdo#103665])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-kbl4/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-kbl4/igt@[email protected]

#### Possible fixes ####

* igt@gem_mmap_gtt@hang:
- shard-kbl: [DMESG-WARN][41] ([fdo#110913 ]) -> [PASS][42] +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-kbl7/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-kbl4/igt@[email protected]

* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-snb: [DMESG-WARN][43] ([fdo#110789] / [fdo#110913 ]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-snb7/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-snb2/igt@[email protected]

* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
- shard-apl: [DMESG-WARN][45] ([fdo#110913 ]) -> [PASS][46] +4 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-apl4/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-apl6/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html

* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-snb: [DMESG-WARN][47] ([fdo#110913 ]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-snb2/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-snb6/igt@[email protected]

* igt@i915_selftest@live_evict:
- shard-kbl: [INCOMPLETE][49] ([fdo#103665] / [fdo#110938]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-kbl1/igt@i915_selftest@live_evict.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-kbl1/igt@i915_selftest@live_evict.html

* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-kbl: [INCOMPLETE][51] ([fdo#103665]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-kbl4/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-kbl1/igt@[email protected]

* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic:
- shard-hsw: [SKIP][53] ([fdo#109271]) -> [PASS][54] +18 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-hsw1/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-hsw6/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-kbl: [DMESG-WARN][55] ([fdo#108566]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-kbl6/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-kbl1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-iclb: [FAIL][57] ([fdo#103167]) -> [PASS][58] +6 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-iclb2/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-iclb5/igt@[email protected]

* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][59] ([fdo#109441]) -> [PASS][60] +3 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-iclb7/igt@kms_psr@psr2_primary_mmap_cpu.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html

* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-glk: [DMESG-FAIL][61] ([fdo#105763] / [fdo#106538]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-glk2/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-glk5/igt@[email protected]

* igt@kms_setmode@basic:
- shard-apl: [FAIL][63] ([fdo#99912]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-apl1/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-apl6/igt@[email protected]

* igt@perf_pmu@enable-race-vcs0:
- shard-apl: [INCOMPLETE][65] ([fdo#103927]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6291/shard-apl2/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3172/shard-apl8/igt@[email protected]

Participating hosts (10 -> 6)
------------------------------

Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005

Build changes
-------------

* IGT: IGT_5059 -> IGTPW_3172
* Piglit: piglit_4509 -> None

== Logs ==