Skip to contentSkip to conversation

fb-test-app: Revert upstream 77bdfc6 "add function to place framebuffer ..."

PATCH Superseded Andy Shevchenko 2 participants 6 messages Jun 18, 2019 – Jun 26, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 fb-test-app: Revert upstream 77bdfc6 "add function to place framebuffer ..."

The patch breaks at least hotplug displays to work.

More details in submitted PR to the upstream, i.e.
https://github.com/prpplague/fb-test-app/pull/5.

---
- now correct patch

 ...ion-to-place-framebuffer-in-graphics.patch | 49 +++++++++++++++++++
 1 file changed, 49 insertions(+)
 create mode 100644 package/fb-test-app/0001-Revert-add-function-to-place-framebuffer-in-graphics.patch
package/fb-test-app/0001-Revert-add-function-to-place-framebuffer-in-graphics.patch new file +49 -0
new file mode 100644
index 0000000000..f8e5fb3c26
@@ -0,0 +1,49 @@
+From f960002becced31ea6ce1e1160b4e1b24ef9afa5 Mon Sep 17 00:00:00 2001
+From: Andy Shevchenko <[email protected]>
+Date: Tue, 18 Jun 2019 18:26:28 +0300
+Subject: [PATCH 1/1] Revert "add function to place framebuffer in graphics
+ mode"
+
+First of all, it's completely unclear why /dev/tty1 is being hardcoded.
+Second, the function may switch the console to a wrong mode without restoring.
+Last, but not least, this breaks display in hotplug mode in my case.
+
+I have an SPI panel connected and I load an overlay to enable it. If I ran
+fb-test and do unload-load cycle, display becomes unusable till the reboot.
+
+Revert hack commit 77bdfc6ccbebb39caed4ac167a983ad3ad1e1ccb for good.
+
+Link: https://github.com/HED-Inc/fb-test-app/commit/ef9c21a2e55160ad52c40f7c2a07fcab95e484e1
+Signed-off-by: Andy Shevchenko <[email protected]>
+---
+ common.c | 8 +-------
+ 1 file changed, 1 insertion(+), 7 deletions(-)
+
+diff --git a/common.c b/common.c
+index a341dbe..1f47d00 100644
+--- a/common.c
++++ b/common.c
+@@ -31,19 +31,13 @@
+ #include <sys/mman.h>
+ 
+ #include <linux/fb.h>
+-#include <linux/kd.h>
+ 
+ #include "common.h"
+ 
+ void fb_open(int fb_num, struct fb_info *fb_info)
+ {
+ 	char str[64];
+-	int fd,tty;
+-
+-	tty = open("/dev/tty1", O_RDWR);
+-
+-	if(ioctl(tty, KDSETMODE, KD_GRAPHICS) == -1)
+-		printf("Failed to set graphics mode on tty1\n");
++	int fd;
+ 
+ 	sprintf(str, "/dev/fb%d", fb_num);
+ 	fd = open(str, O_RDWR);
+-- 
+2.20.1
+
Signature · 1 line
2.20.1
#1 lore raw

PATCH v2 1/1 fb-test-app: Revert upstream 77bdfc6 "add function to place framebuffer ..."

Quoted 4 lines · On Tue, 18 Jun 2019 18:46:50 +0300 Andy Shevchenko…

The patch breaks at least hotplug displays to work.

More details in submitted PR to the upstream, i.e.
https://github.com/prpplague/fb-test-app/pull/5.

This link does not exist.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH v2 1/1 fb-test-app: Revert upstream 77bdfc6 "add function to place framebuffer ..."

Quoted 9 lines · Thomas Petazzoni
Quoted 4 lines · On Tue, 18 Jun 2019 18:46:50 +0300 Andy Shevchenko…

The patch breaks at least hotplug displays to work.

More details in submitted PR to the upstream, i.e.
https://github.com/prpplague/fb-test-app/pull/5.

This link does not exist.

First time in my life I see such a reaction to the bug report. So, owner basically removed repository completely without any word to say.

It means we have to change now URL as well.
Perhaps I'm upstream de facto now.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw

PATCH v2 1/1 fb-test-app: Revert upstream 77bdfc6 "add function to place framebuffer ..."

Quoted 6 lines · On Wed, 19 Jun 2019 14:05:43 +0300 Andy Shevchenko…
Quoted 5 lines · Thomas Petazzoni
Quoted 2 lines · On Tue, 18 Jun 2019 18:46:50 +0300 Andy Shevchenko…

The patch breaks at least hotplug displays to work.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

More details in submitted PR to the upstream, i.e.
https://github.com/prpplague/fb-test-app/pull/5.

This link does not exist.

First time in my life I see such a reaction to the bug report. So, owner basically removed repository completely without any word to say.

Ah, ah, interesting indeed! This is quite surprising from David Anders to be honest. Perhaps we could contact him separately and see what happened ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH v2 1/1 fb-test-app: Revert upstream 77bdfc6 "add function to place framebuffer ..."

Quoted 11 lines · Thomas Petazzoni
Quoted 9 lines · On Wed, 19 Jun 2019 14:05:43 +0300 Andy Shevchenko…
Quoted 8 lines · Thomas Petazzoni
Quoted 4 lines · On Tue, 18 Jun 2019 18:46:50 +0300 Andy Shevchenko…

The patch breaks at least hotplug displays to work.

More details in submitted PR to the upstream, i.e.
https://github.com/prpplague/fb-test-app/pull/5.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

This link does not exist.

First time in my life I see such a reaction to the bug report. So, owner basically removed repository completely without any word to say.

Ah, ah, interesting indeed! This is quite surprising from David Anders to be honest. Perhaps we could contact him separately and see what happened ?

I don't know the guy.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#5 lore raw

PATCH v2 1/1 fb-test-app: Revert upstream 77bdfc6 "add function to place framebuffer ..."

Quoted 14 lines · Andy Shevchenko
Quoted 13 lines · Thomas Petazzoni
Quoted 11 lines · On Wed, 19 Jun 2019 14:05:43 +0300 Andy Shevchenko…
Quoted 9 lines · Thomas Petazzoni
Quoted 4 lines · On Tue, 18 Jun 2019 18:46:50 +0300 Andy Shevchenko…

The patch breaks at least hotplug displays to work.

More details in submitted PR to the upstream, i.e.
https://github.com/prpplague/fb-test-app/pull/5.

This link does not exist.

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

First time in my life I see such a reaction to the bug report. So, owner basically removed repository completely without any word to say.

Ah, ah, interesting indeed! This is quite surprising from David Anders to be honest. Perhaps we could contact him separately and see what happened ?

I don't know the guy.

So, Are we going to fix (an annoying) bug?

Signature · 2 lines
With Best Regards,
Andy Shevchenko