watchdog: bcm_kona_wdt: no need to check return value of debugfs_create functions
PATCH 1/1 watchdog: bcm_kona_wdt: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Wim Van Sebroeck <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Florian Fainelli <[email protected]>
Cc Ray Jui <[email protected]>
Cc Scott Branden <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
--- drivers/watchdog/bcm_kona_wdt.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-)
drivers/watchdog/bcm_kona_wdt.c +4 -10
@@ -143,24 +143,18 @@ static void bcm_kona_wdt_debug_init(struct platform_device *pdev) wdt->debugfs =NULL ; dir =debugfs_create_dir (BCM_KONA_WDT_NAME ,NULL ); -if (IS_ERR_OR_NULL (dir)) -return ; -if (debugfs_create_file ("info" ,S_IFREG |S_IRUGO , dir, wdt, - &bcm_kona_fops)) - wdt->debugfs = dir; -else - debugfs_remove_recursive(dir); +debugfs_create_file ("info" ,S_IFREG |S_IRUGO , dir, wdt, + &bcm_kona_fops); + wdt->debugfs = dir; }static void bcm_kona_wdt_debug_exit (struct platform_device *pdev) {struct bcm_kona_wdt *wdt =platform_get_drvdata (pdev); -if (wdt && wdt->debugfs) { +if (wdt)debugfs_remove_recursive (wdt->debugfs); - wdt->debugfs =NULL ; - } }#else
Signature · 1 line
2.22.0
Quoted 4 lines · Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Quoted 8 lines
Cc Wim Van Sebroeck <[email protected]>Cc Guenter Roeck <[email protected]>Cc Florian Fainelli <[email protected]>Cc Ray Jui <[email protected]>Cc Scott Branden <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Reviewed-by Guenter Roeck <[email protected]>
Quoted 40 lines
--- drivers/watchdog/bcm_kona_wdt.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-)drivers/watchdog/bcm_kona_wdt.c +4
-10@@ -143,24 +143,18 @@ static void bcm_kona_wdt_debug_init(struct platform_device *pdev) wdt->debugfs =NULL ; dir =debugfs_create_dir (BCM_KONA_WDT_NAME ,NULL ); -if (IS_ERR_OR_NULL (dir)) -return ; -if (debugfs_create_file ("info" ,S_IFREG |S_IRUGO , dir, wdt, - &bcm_kona_fops)) - wdt->debugfs = dir; -else - debugfs_remove_recursive(dir); +debugfs_create_file ("info" ,S_IFREG |S_IRUGO , dir, wdt, + &bcm_kona_fops); + wdt->debugfs = dir; }static void bcm_kona_wdt_debug_exit (struct platform_device *pdev) {struct bcm_kona_wdt *wdt =platform_get_drvdata (pdev); -if (wdt && wdt->debugfs) { +if (wdt)debugfs_remove_recursive (wdt->debugfs); - wdt->debugfs =NULL ; - } }#else Signature · 1 line
2.22.0