Enabled DM_VIDEO for Colibri iMX7 NAND/iMX6ULL
cover Enabled DM_VIDEO for Colibri iMX7 NAND/iMX6ULL
From: Igor Opaniuk <[email protected]>
This patch-series fixes some issues in mxsfb fbdev bindings (incorrect structure). Currently there is a support only for old format, new one wil be introduced soon [1].
Also it enables support of DM_VIDEO for Colibri iMX7 NAND version and for Colibri iMX6ULL.
[1] https://www.kernel.org/doc/Documentation/devicetree/bindings/display/mxsfb.txt
Igor Opaniuk (6):
video: mxsfb: fix mxsfb fbdev binding issues
ARM: dts: colibri_imx7: Fix lcdif node definition
configs: colibri_imx7: enable DM_VIDEO
colibri-imx6ull: support building with DM_VIDEO=y
ARM: dts: colibri-imx6ull: extend lcdif node
configs: colibri-imx6ull: switch to DM_VIDEO
arch/arm/dts/imx6ull-colibri.dts | 32 +++++++++++++ arch/arm/dts/imx7-colibri.dtsi | 47 +++++++++++--------- arch/arm/mach-imx/mx6/soc.c | 2 +- configs/colibri-imx6ull_defconfig | 2 +- configs/colibri_imx7_defconfig | 2 +- drivers/video/mxsfb.c | 74 ++++++++++++++++++++++++++----- include/configs/colibri-imx6ull.h | 2 +- 7 files changed, 124 insertions(+), 37 deletions(-)
Signature · 1 line
2.17.1
PATCH 1/6 video: mxsfb: fix mxsfb fbdev binding issues
From: Igor Opaniuk <[email protected]>
Add support for display and bits-per-pixel properties.
--- drivers/video/mxsfb.c | 74 ++++++++++++++++++++++++++++++++++++------- 1 file changed, 62 insertions(+), 12 deletions(-)
drivers/video/mxsfb.c +62 -12
@@ -271,6 +271,42 @@ dealloc_fb: }#else /* ifndef CONFIG_DM_VIDEO */ +static int mxs_of_get_timings (struct udevice *dev, +struct display_timing *timings, +u32 *bpp) +{ +int ret =0 ; +u32 display_phandle; +ofnode display_node; + + ret =ofnode_read_u32 (dev_ofnode (dev),"display" , &display_phandle); +if (ret) { +dev_err (dev,"required display property isn't provided\n" ); +return -EINVAL ; + } + + display_node =ofnode_get_by_phandle (display_phandle); +if (!ofnode_valid (display_node)) { +dev_err (dev,"failed to find display subnode\n" ); +return -EINVAL ; + } + + ret =ofnode_read_u32 (display_node,"bits-per-pixel" , bpp); +if (ret) { +dev_err (dev, +"required bits-per-pixel property isn't provided\n" ); +return -EINVAL ; + } + + ret =ofnode_decode_display_timing (display_node,0 , timings); +if (ret) { +dev_err (dev,"failed to get any display timings\n" ); +return -EINVAL ; + } + +return ret; +} +static int mxs_video_probe (struct udevice *dev) {struct video_uc_platdata *plat =dev_get_uclass_platdata (dev);
@@ -278,18 +314,16 @@ static int mxs_video_probe(struct udevice *dev)struct ctfb_res_modes mode;struct display_timing timings; -int bpp =-1 ; +u32 bpp =0 ;u32 fb_start, fb_end;int ret;debug ("%s() plat: base 0x%lx, size 0x%x\n" , __func__, plat->base, plat->size); - ret =ofnode_decode_display_timing (dev_ofnode (dev),0 , &timings); -if (ret) { -dev_err (dev,"failed to get any display timings\n" ); -return -EINVAL ; - } + ret =mxs_of_get_timings (dev, &timings, &bpp); +if (ret) +return ret; mode.xres = timings.hactive.typ; mode.yres = timings.vactive.typ;
@@ -301,13 +335,12 @@ static int mxs_video_probe(struct udevice *dev) mode.vsync_len = timings.vsync_len.typ; mode.pixclock =HZ2PS (timings.pixelclock.typ); - bpp =BITS_PP ; - ret =mxs_probe_common (&mode, bpp, plat->base);if (ret)return ret;switch (bpp) { +case 32 :case 24 :case 18 : uc_priv->bpix =VIDEO_BPP32 ;
@@ -341,15 +374,32 @@ static int mxs_video_bind(struct udevice *dev) {struct video_uc_platdata *plat =dev_get_uclass_platdata (dev);struct display_timing timings; +u32 bpp =0 ; +u32 bytes_pp =0 ;int ret; - ret =ofnode_decode_display_timing (dev_ofnode (dev),0 , &timings); -if (ret) { -dev_err (dev,"failed to get any display timings\n" ); + ret =mxs_of_get_timings (dev, &timings, &bpp); +if (ret) +return ret; + +switch (bpp) { +case 32 : +case 24 : +case 18 : + bytes_pp =4 ; +break ; +case 16 : + bytes_pp =2 ; +break ; +case 8 : + bytes_pp =1 ; +break ; +default : +dev_err (dev,"invalid bpp specified (bpp = %i)\n" , bpp);return -EINVAL ; } - plat->size = timings.hactive.typ * timings.vactive.typ *BYTES_PP ; + plat->size = timings.hactive.typ * timings.vactive.typ * bytes_pp;return 0 ; }
Signature · 1 line
2.17.1
PATCH 1/6 video: mxsfb: fix mxsfb fbdev binding issues
+ Oleksandr
Quoted 135 lines · Igor Opaniuk
From: Igor Opaniuk <[email protected]>
Add support for display and bits-per-pixel properties.
Signed-off-by Igor Opaniuk <[email protected]>--- drivers/video/mxsfb.c | 74 ++++++++++++++++++++++++++++++++++++------- 1 file changed, 62 insertions(+), 12 deletions(-)drivers/video/mxsfb.c +62
-13@@ -271,6 +271,42 @@ dealloc_fb: }#else /* ifndef CONFIG_DM_VIDEO */ +static int mxs_of_get_timings (struct udevice *dev, +struct display_timing *timings, +u32 *bpp) +{ +int ret =0 ; +u32 display_phandle; +ofnode display_node; + + ret =ofnode_read_u32 (dev_ofnode (dev),"display" , &display_phandle); +if (ret) { +dev_err (dev,"required display property isn't provided\n" ); +return -EINVAL ; + } + + display_node =ofnode_get_by_phandle (display_phandle); +if (!ofnode_valid (display_node)) { +dev_err (dev,"failed to find display subnode\n" ); +return -EINVAL ; + } + + ret =ofnode_read_u32 (display_node,"bits-per-pixel" , bpp); +if (ret) { +dev_err (dev, +"required bits-per-pixel property isn't provided\n" ); +return -EINVAL ; + } + + ret =ofnode_decode_display_timing (display_node,0 , timings); +if (ret) { +dev_err (dev,"failed to get any display timings\n" ); +return -EINVAL ; + } + +return ret; +} +static int mxs_video_probe (struct udevice *dev) {struct video_uc_platdata *plat =dev_get_uclass_platdata (dev);@@ -278,18 +314,16 @@ static int mxs_video_probe(struct udevice *dev)struct ctfb_res_modes mode;struct display_timing timings; -int bpp =-1 ; +u32 bpp =0 ;u32 fb_start, fb_end;int ret;debug ("%s() plat: base 0x%lx, size 0x%x\n" , __func__, plat->base, plat->size); - ret =ofnode_decode_display_timing (dev_ofnode (dev),0 , &timings); -if (ret) { -dev_err (dev,"failed to get any display timings\n" ); -return -EINVAL ; - } + ret =mxs_of_get_timings (dev, &timings, &bpp); +if (ret) +return ret; mode.xres = timings.hactive.typ; mode.yres = timings.vactive.typ;@@ -301,13 +335,12 @@ static int mxs_video_probe(struct udevice *dev) mode.vsync_len = timings.vsync_len.typ; mode.pixclock =HZ2PS (timings.pixelclock.typ); - bpp =BITS_PP ; - ret =mxs_probe_common (&mode, bpp, plat->base);if (ret)return ret;switch (bpp) { +case 32 :case 24 :case 18 : uc_priv->bpix =VIDEO_BPP32 ;@@ -341,15 +374,32 @@ static int mxs_video_bind(struct udevice *dev) {struct video_uc_platdata *plat =dev_get_uclass_platdata (dev);struct display_timing timings; +u32 bpp =0 ; +u32 bytes_pp =0 ;int ret; - ret =ofnode_decode_display_timing (dev_ofnode (dev),0 , &timings); -if (ret) { -dev_err (dev,"failed to get any display timings\n" ); + ret =mxs_of_get_timings (dev, &timings, &bpp); +if (ret) +return ret; + +switch (bpp) { +case 32 : +case 24 : +case 18 : + bytes_pp =4 ; +break ; +case 16 : + bytes_pp =2 ; +break ; +case 8 : + bytes_pp =1 ; +break ; +default : +dev_err (dev,"invalid bpp specified (bpp = %i)\n" , bpp);return -EINVAL ; } - plat->size = timings.hactive.typ * timings.vactive.typ *BYTES_PP ; + plat->size = timings.hactive.typ * timings.vactive.typ * bytes_pp;return 0 ; } --2.17.1
Signature · 8 lines
Best regards - Freundliche Grüsse - Meilleures salutations Igor Opaniuk mailto: igor.opaniuk at gmail.com skype: igor.opanyuk +380 (93) 836 40 67 http://ua.linkedin.com/in/iopaniuk
PATCH 1/6 video: mxsfb: fix mxsfb fbdev binding issues
Quoted 146 lines · Igor Opaniuk
+ Oleksandr
Quoted 133 lines · Igor Opaniuk
From: Igor Opaniuk <[email protected]>
Add support for display and bits-per-pixel properties.
Signed-off-by Igor Opaniuk <[email protected]>--- drivers/video/mxsfb.c | 74 ++++++++++++++++++++++++++++++++++++------- 1 file changed, 62 insertions(+), 12 deletions(-)drivers/video/mxsfb.c +62
-13@@ -271,6 +271,42 @@ dealloc_fb: }#else /* ifndef CONFIG_DM_VIDEO */ +static int mxs_of_get_timings (struct udevice *dev, +struct display_timing *timings, +u32 *bpp) +{ +int ret =0 ; +u32 display_phandle; +ofnode display_node; + + ret =ofnode_read_u32 (dev_ofnode (dev),"display" , &display_phandle); +if (ret) { +dev_err (dev,"required display property isn't provided\n" ); +return -EINVAL ; + } + + display_node =ofnode_get_by_phandle (display_phandle); +if (!ofnode_valid (display_node)) { +dev_err (dev,"failed to find display subnode\n" ); +return -EINVAL ; + } + + ret =ofnode_read_u32 (display_node,"bits-per-pixel" , bpp); +if (ret) { +dev_err (dev, +"required bits-per-pixel property isn't provided\n" ); +return -EINVAL ; + } + + ret =ofnode_decode_display_timing (display_node,0 , timings); +if (ret) { +dev_err (dev,"failed to get any display timings\n" ); +return -EINVAL ; + } + +return ret; +} +static int mxs_video_probe (struct udevice *dev) {struct video_uc_platdata *plat =dev_get_uclass_platdata (dev);@@ -278,18 +314,16 @@ static int mxs_video_probe(struct udevice *dev)struct ctfb_res_modes mode;struct display_timing timings; -int bpp =-1 ; +u32 bpp =0 ;u32 fb_start, fb_end;int ret;debug ("%s() plat: base 0x%lx, size 0x%x\n" , __func__, plat->base, plat->size); - ret =ofnode_decode_display_timing (dev_ofnode (dev),0 , &timings); -if (ret) { -dev_err (dev,"failed to get any display timings\n" ); -return -EINVAL ; - } + ret =mxs_of_get_timings (dev, &timings, &bpp); +if (ret) +return ret; mode.xres = timings.hactive.typ; mode.yres = timings.vactive.typ;@@ -301,13 +335,12 @@ static int mxs_video_probe(struct udevice *dev) mode.vsync_len = timings.vsync_len.typ; mode.pixclock =HZ2PS (timings.pixelclock.typ); - bpp =BITS_PP ; - ret =mxs_probe_common (&mode, bpp, plat->base);if (ret)return ret;switch (bpp) { +case 32 :case 24 :case 18 : uc_priv->bpix =VIDEO_BPP32 ;@@ -341,15 +374,32 @@ static int mxs_video_bind(struct udevice *dev) {struct video_uc_platdata *plat =dev_get_uclass_platdata (dev);struct display_timing timings; +u32 bpp =0 ; +u32 bytes_pp =0 ;int ret; - ret =ofnode_decode_display_timing (dev_ofnode (dev),0 , &timings); -if (ret) { -dev_err (dev,"failed to get any display timings\n" ); + ret =mxs_of_get_timings (dev, &timings, &bpp); +if (ret) +return ret; + +switch (bpp) { +case 32 : +case 24 : +case 18 : + bytes_pp =4 ; +break ; +case 16 : + bytes_pp =2 ; +break ; +case 8 : + bytes_pp =1 ; +break ; +default : +dev_err (dev,"invalid bpp specified (bpp = %i)\n" , bpp);return -EINVAL ; } - plat->size = timings.hactive.typ * timings.vactive.typ *BYTES_PP ; + plat->size = timings.hactive.typ * timings.vactive.typ * bytes_pp;return 0 ; } --Quoted 2 lines
2.17.1
--
Best regards - Freundliche Grüsse - Meilleures salutationsIgor Opaniuk
Quoted 8 lines
mailto: igor.opaniuk at gmail.com
skype: igor.opanyuk
+380 (93) 836 40 67
http://ua.linkedin.com/in/iopaniuk
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot
Signature · 6 lines
Best regards Oleksandr Suvorov Toradex AG Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500 4800 (main line)
PATCH 2/6 ARM: dts: colibri_imx7: Fix lcdif node definition
In reply to Igor OpaniukFrom: Igor Opaniuk <[email protected]>
Fix lcdif DT node and make it conform to the structure defined in the Linux devicetree bindings [1]. Currently there is support only for old style lcdif node definitions.
[1] https://www.kernel.org/doc/Documentation/devicetree/bindings/display/mxsfb.txt
--- arch/arm/dts/imx7-colibri.dtsi | 47 +++++++++++++++++++--------------- 1 file changed, 26 insertions(+), 21 deletions(-)
arch/arm/dts/imx7-colibri.dtsi +26 -21
@@ -113,29 +113,34 @@ }; &lcdif { - u-boot,dm-pre-reloc; status = "okay"; + display = <&display0>; + u-boot,dm-pre-reloc; - display-timings { - native-mode = <&timing_vga>; - - /* Standard VGA timing */ - timing_vga: 640x480 { - u-boot,dm-pre-reloc; - clock-frequency = <25175000>; - hactive = <640>; - vactive = <480>; - hback-porch = <48>; - hfront-porch = <16>; - vback-porch = <33>; - vfront-porch = <10>; - hsync-len = <96>; - vsync-len = <2>; - - de-active = <1>; - hsync-active = <0>; - vsync-active = <0>; - pixelclk-active = <0>; + display0: display0 { + bits-per-pixel = <18>; + bus-width = <24>; + status = "okay"; + + display-timings { + native-mode = <&timing_vga>; + timing_vga: 640x480 { + u-boot,dm-pre-reloc; + clock-frequency = <25175000>; + hactive = <640>; + vactive = <480>; + hback-porch = <48>; + hfront-porch = <16>; + vback-porch = <33>; + vfront-porch = <10>; + hsync-len = <96>; + vsync-len = <2>; + + de-active = <1>; + hsync-active = <0>; + vsync-active = <0>; + pixelclk-active = <0>; + }; }; }; };
Signature · 1 line
2.17.1
PATCH 2/6 ARM: dts: colibri_imx7: Fix lcdif node definition
+ Oleksandr
Quoted 77 lines · Igor Opaniuk
From: Igor Opaniuk <[email protected]>
Fix lcdif DT node and make it conform to the structure defined in the Linux devicetree bindings [1]. Currently there is support only for old style lcdif node definitions.
[1] https://www.kernel.org/doc/Documentation/devicetree/bindings/display/mxsfb.txt
Signed-off-by Igor Opaniuk <[email protected]>--- arch/arm/dts/imx7-colibri.dtsi | 47 +++++++++++++++++++--------------- 1 file changed, 26 insertions(+), 21 deletions(-)arch/arm/dts/imx7-colibri.dtsi +26
-22@@ -113,29 +113,34 @@ }; &lcdif { - u-boot,dm-pre-reloc; status = "okay"; + display = <&display0>; + u-boot,dm-pre-reloc; - display-timings { - native-mode = <&timing_vga>; - - /* Standard VGA timing */ - timing_vga: 640x480 { - u-boot,dm-pre-reloc; - clock-frequency = <25175000>; - hactive = <640>; - vactive = <480>; - hback-porch = <48>; - hfront-porch = <16>; - vback-porch = <33>; - vfront-porch = <10>; - hsync-len = <96>; - vsync-len = <2>; - - de-active = <1>; - hsync-active = <0>; - vsync-active = <0>; - pixelclk-active = <0>; + display0: display0 { + bits-per-pixel = <18>; + bus-width = <24>; + status = "okay"; + + display-timings { + native-mode = <&timing_vga>; + timing_vga: 640x480 { + u-boot,dm-pre-reloc; + clock-frequency = <25175000>; + hactive = <640>; + vactive = <480>; + hback-porch = <48>; + hfront-porch = <16>; + vback-porch = <33>; + vfront-porch = <10>; + hsync-len = <96>; + vsync-len = <2>; + + de-active = <1>; + hsync-active = <0>; + vsync-active = <0>; + pixelclk-active = <0>; + }; }; }; }; --2.17.1
Signature · 8 lines
Best regards - Freundliche Grüsse - Meilleures salutations Igor Opaniuk mailto: igor.opaniuk at gmail.com skype: igor.opanyuk +380 (93) 836 40 67 http://ua.linkedin.com/in/iopaniuk
PATCH 2/6 ARM: dts: colibri_imx7: Fix lcdif node definition
Quoted 88 lines · Igor Opaniuk
+ Oleksandr
Quoted 75 lines · Igor Opaniuk
From: Igor Opaniuk <[email protected]>
Fix lcdif DT node and make it conform to the structure defined in the Linux devicetree bindings [1]. Currently there is support only for old style lcdif node definitions.
[1] https://www.kernel.org/doc/Documentation/devicetree/bindings/display/mxsfb.txt
Signed-off-by Igor Opaniuk <[email protected]>--- arch/arm/dts/imx7-colibri.dtsi | 47 +++++++++++++++++++--------------- 1 file changed, 26 insertions(+), 21 deletions(-)arch/arm/dts/imx7-colibri.dtsi +26
-22@@ -113,29 +113,34 @@ }; &lcdif { - u-boot,dm-pre-reloc; status = "okay"; + display = <&display0>; + u-boot,dm-pre-reloc; - display-timings { - native-mode = <&timing_vga>; - - /* Standard VGA timing */ - timing_vga: 640x480 { - u-boot,dm-pre-reloc; - clock-frequency = <25175000>; - hactive = <640>; - vactive = <480>; - hback-porch = <48>; - hfront-porch = <16>; - vback-porch = <33>; - vfront-porch = <10>; - hsync-len = <96>; - vsync-len = <2>; - - de-active = <1>; - hsync-active = <0>; - vsync-active = <0>; - pixelclk-active = <0>; + display0: display0 { + bits-per-pixel = <18>; + bus-width = <24>; + status = "okay"; + + display-timings { + native-mode = <&timing_vga>; + timing_vga: 640x480 { + u-boot,dm-pre-reloc; + clock-frequency = <25175000>; + hactive = <640>; + vactive = <480>; + hback-porch = <48>; + hfront-porch = <16>; + vback-porch = <33>; + vfront-porch = <10>; + hsync-len = <96>; + vsync-len = <2>; + + de-active = <1>; + hsync-active = <0>; + vsync-active = <0>; + pixelclk-active = <0>; + }; }; }; }; --Quoted 2 lines
2.17.1
--
Best regards - Freundliche Grüsse - Meilleures salutationsIgor Opaniuk
Quoted 8 lines
mailto: igor.opaniuk at gmail.com
skype: igor.opanyuk
+380 (93) 836 40 67
http://ua.linkedin.com/in/iopaniuk
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot
Signature · 6 lines
Best regards Oleksandr Suvorov Toradex AG Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500 4800 (main line)
PATCH 3/6 configs: colibri_imx7: enable DM_VIDEO
In reply to Igor OpaniukFrom: Igor Opaniuk <[email protected]>
Enable DM_VIDEO support for Colibri iMX7 NAND version.
--- configs/colibri_imx7_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
configs/colibri_imx7_defconfig +1 -1
@@ -75,6 +75,6 @@ CONFIG_USB_GADGET_VENDOR_NUM=0x1b67 CONFIG_USB_GADGET_PRODUCT_NUM=0x4000 CONFIG_CI_UDC=y CONFIG_USB_GADGET_DOWNLOAD=y -CONFIG_VIDEO=y +CONFIG_DM_VIDEO=y CONFIG_OF_LIBFDT_OVERLAY=y CONFIG_FDT_FIXUP_PARTITIONS=y
Signature · 1 line
2.17.1
PATCH 3/6 configs: colibri_imx7: enable DM_VIDEO
+ Oleksandr
Quoted 25 lines · Igor Opaniuk
From: Igor Opaniuk <[email protected]>
Enable
DM_VIDEOsupport for Colibri iMX7 NAND version.Signed-off-by Igor Opaniuk <[email protected]>--- configs/colibri_imx7_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)configs/colibri_imx7_defconfig +1
-2@@ -75,6 +75,6 @@ CONFIG_USB_GADGET_VENDOR_NUM=0x1b67 CONFIG_USB_GADGET_PRODUCT_NUM=0x4000 CONFIG_CI_UDC=y CONFIG_USB_GADGET_DOWNLOAD=y -CONFIG_VIDEO=y +CONFIG_DM_VIDEO=y CONFIG_OF_LIBFDT_OVERLAY=y CONFIG_FDT_FIXUP_PARTITIONS=y --2.17.1
Signature · 8 lines
Best regards - Freundliche Grüsse - Meilleures salutations Igor Opaniuk mailto: igor.opaniuk at gmail.com skype: igor.opanyuk +380 (93) 836 40 67 http://ua.linkedin.com/in/iopaniuk
PATCH 3/6 configs: colibri_imx7: enable DM_VIDEO
Quoted 36 lines · Igor Opaniuk
+ Oleksandr
Quoted 23 lines · Igor Opaniuk
From: Igor Opaniuk <[email protected]>
Enable
DM_VIDEOsupport for Colibri iMX7 NAND version.Signed-off-by Igor Opaniuk <[email protected]>--- configs/colibri_imx7_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)configs/colibri_imx7_defconfig +1
-2@@ -75,6 +75,6 @@ CONFIG_USB_GADGET_VENDOR_NUM=0x1b67 CONFIG_USB_GADGET_PRODUCT_NUM=0x4000 CONFIG_CI_UDC=y CONFIG_USB_GADGET_DOWNLOAD=y -CONFIG_VIDEO=y +CONFIG_DM_VIDEO=y CONFIG_OF_LIBFDT_OVERLAY=y CONFIG_FDT_FIXUP_PARTITIONS=y --Quoted 2 lines
2.17.1
--
Best regards - Freundliche Grüsse - Meilleures salutationsIgor Opaniuk
Quoted 8 lines
mailto: igor.opaniuk at gmail.com
skype: igor.opanyuk
+380 (93) 836 40 67
http://ua.linkedin.com/in/iopaniuk
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot
Signature · 6 lines
Best regards Oleksandr Suvorov Toradex AG Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500 4800 (main line)
PATCH 4/6 colibri-imx6ull: support building with DM_VIDEO=y
In reply to Igor OpaniukFrom: Igor Opaniuk <[email protected]>
1. This fixes linking issues when building with DM_VIDEO enabled mxsfb driver.
2. Provide proper defines for both VIDEO=y and DM_VIDEO=y.
--- arch/arm/mach-imx/mx6/soc.c | 2 +- include/configs/colibri-imx6ull.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-imx/mx6/soc.c +1 -1
@@ -549,7 +549,7 @@ const struct boot_mode soc_boot_modes[] = {void reset_misc (void ) {#ifndef CONFIG_SPL_BUILD -#ifdef CONFIG_VIDEO_MXS +#if defined(CONFIG_VIDEO_MXS ) && !defined(CONFIG_DM_VIDEO )lcdif_power_down ();#endif #endif
include/configs/colibri-imx6ull.h +1 -1
@@ -170,7 +170,7 @@#define CONFIG_SYS_DFU_DATA_BUF_SIZE SZ_16M#define DFU_DEFAULT_POLL_TIMEOUT 300 -#ifdef CONFIG_VIDEO +#if defined(CONFIG_VIDEO ) || defined(CONFIG_DM_VIDEO )#define CONFIG_VIDEO_MXS #define MXS_LCDIF_BASE MX6UL_LCDIF1_BASE_ADDR#define CONFIG_VIDEO_LOGO
Signature · 1 line
2.17.1
PATCH 4/6 colibri-imx6ull: support building with DM_VIDEO=y
+ Oleksandr
Quoted 42 lines · Igor Opaniuk
From: Igor Opaniuk <[email protected]>
1. This fixes linking issues when building with
DM_VIDEOenabled mxsfb driver.
2. Provide proper defines for both VIDEO=y and DM_VIDEO=y.Signed-off-by Igor Opaniuk <[email protected]>--- arch/arm/mach-imx/mx6/soc.c | 2 +- include/configs/colibri-imx6ull.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)arch/arm/mach-imx/mx6/soc.c +1
-1@@ -549,7 +549,7 @@ const struct boot_mode soc_boot_modes[] = {void reset_misc (void ) {#ifndef CONFIG_SPL_BUILD -#ifdef CONFIG_VIDEO_MXS +#if defined(CONFIG_VIDEO_MXS ) && !defined(CONFIG_DM_VIDEO )lcdif_power_down ();#endif #endif include/configs/colibri-imx6ull.h +1
-2@@ -170,7 +170,7 @@#define CONFIG_SYS_DFU_DATA_BUF_SIZE SZ_16M#define DFU_DEFAULT_POLL_TIMEOUT 300 -#ifdef CONFIG_VIDEO +#if defined(CONFIG_VIDEO ) || defined(CONFIG_DM_VIDEO )#define CONFIG_VIDEO_MXS #define MXS_LCDIF_BASE MX6UL_LCDIF1_BASE_ADDR#define CONFIG_VIDEO_LOGO --2.17.1
Signature · 8 lines
Best regards - Freundliche Grüsse - Meilleures salutations Igor Opaniuk mailto: igor.opaniuk at gmail.com skype: igor.opanyuk +380 (93) 836 40 67 http://ua.linkedin.com/in/iopaniuk
PATCH 4/6 colibri-imx6ull: support building with DM_VIDEO=y
Quoted 53 lines · Igor Opaniuk
+ Oleksandr
Quoted 40 lines · Igor Opaniuk
From: Igor Opaniuk <[email protected]>
1. This fixes linking issues when building with
DM_VIDEOenabled mxsfb driver.
2. Provide proper defines for both VIDEO=y and DM_VIDEO=y.Signed-off-by Igor Opaniuk <[email protected]>--- arch/arm/mach-imx/mx6/soc.c | 2 +- include/configs/colibri-imx6ull.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)arch/arm/mach-imx/mx6/soc.c +1
-1@@ -549,7 +549,7 @@ const struct boot_mode soc_boot_modes[] = {void reset_misc (void ) {#ifndef CONFIG_SPL_BUILD -#ifdef CONFIG_VIDEO_MXS +#if defined(CONFIG_VIDEO_MXS ) && !defined(CONFIG_DM_VIDEO )lcdif_power_down ();#endif #endif include/configs/colibri-imx6ull.h +1
-2@@ -170,7 +170,7 @@#define CONFIG_SYS_DFU_DATA_BUF_SIZE SZ_16M#define DFU_DEFAULT_POLL_TIMEOUT 300 -#ifdef CONFIG_VIDEO +#if defined(CONFIG_VIDEO ) || defined(CONFIG_DM_VIDEO )#define CONFIG_VIDEO_MXS #define MXS_LCDIF_BASE MX6UL_LCDIF1_BASE_ADDR#define CONFIG_VIDEO_LOGO --Quoted 2 lines
2.17.1
--
Best regards - Freundliche Grüsse - Meilleures salutationsIgor Opaniuk
Quoted 8 lines
mailto: igor.opaniuk at gmail.com
skype: igor.opanyuk
+380 (93) 836 40 67
http://ua.linkedin.com/in/iopaniuk
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot
Signature · 6 lines
Best regards Oleksandr Suvorov Toradex AG Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500 4800 (main line)
PATCH 5/6 ARM: dts: colibri-imx6ull: extend lcdif node
In reply to Igor OpaniukFrom: Igor Opaniuk <[email protected]>
Provide proper display timings for lcdif node, used by mxsfb DM_VIDEO enabled framebuffer driver.
--- arch/arm/dts/imx6ull-colibri.dts | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+)
arch/arm/dts/imx6ull-colibri.dts +32 -0
@@ -12,8 +12,10 @@ compatible = "toradex,colibri-imx6ull", "fsl,imx6ull"; aliases { + u-boot,dm-pre-reloc; mmc0 = &usdhc1; usb0 = &usbotg1; /* required for ums */ + display0 = &lcdif; }; chosen {
@@ -156,6 +158,36 @@ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_lcdif_dat &pinctrl_lcdif_ctrl>; + status = "okay"; + display = <&display0>; + u-boot,dm-pre-reloc; + + display0: display0 { + bits-per-pixel = <18>; + bus-width = <24>; + status = "okay"; + + display-timings { + native-mode = <&timing_vga>; + timing_vga: 640x480 { + u-boot,dm-pre-reloc; + clock-frequency = <25175000>; + hactive = <640>; + vactive = <480>; + hback-porch = <48>; + hfront-porch = <16>; + vback-porch = <33>; + vfront-porch = <10>; + hsync-len = <96>; + vsync-len = <2>; + + de-active = <1>; + hsync-active = <0>; + vsync-active = <0>; + pixelclk-active = <0>; + }; + }; + }; }; /* PWM <A> */
Signature · 1 line
2.17.1
PATCH 5/6 ARM: dts: colibri-imx6ull: extend lcdif node
+ Oleksandr
Quoted 66 lines · Igor Opaniuk
From: Igor Opaniuk <[email protected]>
Provide proper display timings for lcdif node, used by mxsfb
DM_VIDEOenabled framebuffer driver.Signed-off-by Igor Opaniuk <[email protected]>--- arch/arm/dts/imx6ull-colibri.dts | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+)arch/arm/dts/imx6ull-colibri.dts +32
-1@@ -12,8 +12,10 @@ compatible = "toradex,colibri-imx6ull", "fsl,imx6ull"; aliases { + u-boot,dm-pre-reloc; mmc0 = &usdhc1; usb0 = &usbotg1; /* required for ums */ + display0 = &lcdif; }; chosen {@@ -156,6 +158,36 @@ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_lcdif_dat &pinctrl_lcdif_ctrl>; + status = "okay"; + display = <&display0>; + u-boot,dm-pre-reloc; + + display0: display0 { + bits-per-pixel = <18>; + bus-width = <24>; + status = "okay"; + + display-timings { + native-mode = <&timing_vga>; + timing_vga: 640x480 { + u-boot,dm-pre-reloc; + clock-frequency = <25175000>; + hactive = <640>; + vactive = <480>; + hback-porch = <48>; + hfront-porch = <16>; + vback-porch = <33>; + vfront-porch = <10>; + hsync-len = <96>; + vsync-len = <2>; + + de-active = <1>; + hsync-active = <0>; + vsync-active = <0>; + pixelclk-active = <0>; + }; + }; + }; }; /* PWM <A> */ --2.17.1
Signature · 8 lines
Best regards - Freundliche Grüsse - Meilleures salutations Igor Opaniuk mailto: igor.opaniuk at gmail.com skype: igor.opanyuk +380 (93) 836 40 67 http://ua.linkedin.com/in/iopaniuk
PATCH 5/6 ARM: dts: colibri-imx6ull: extend lcdif node
Quoted 77 lines · Igor Opaniuk
+ Oleksandr
Quoted 64 lines · Igor Opaniuk
From: Igor Opaniuk <[email protected]>
Provide proper display timings for lcdif node, used by mxsfb
DM_VIDEOenabled framebuffer driver.Signed-off-by Igor Opaniuk <[email protected]>--- arch/arm/dts/imx6ull-colibri.dts | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+)arch/arm/dts/imx6ull-colibri.dts +32
-1@@ -12,8 +12,10 @@ compatible = "toradex,colibri-imx6ull", "fsl,imx6ull"; aliases { + u-boot,dm-pre-reloc; mmc0 = &usdhc1; usb0 = &usbotg1; /* required for ums */ + display0 = &lcdif; }; chosen {@@ -156,6 +158,36 @@ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_lcdif_dat &pinctrl_lcdif_ctrl>; + status = "okay"; + display = <&display0>; + u-boot,dm-pre-reloc; + + display0: display0 { + bits-per-pixel = <18>; + bus-width = <24>; + status = "okay"; + + display-timings { + native-mode = <&timing_vga>; + timing_vga: 640x480 { + u-boot,dm-pre-reloc; + clock-frequency = <25175000>; + hactive = <640>; + vactive = <480>; + hback-porch = <48>; + hfront-porch = <16>; + vback-porch = <33>; + vfront-porch = <10>; + hsync-len = <96>; + vsync-len = <2>; + + de-active = <1>; + hsync-active = <0>; + vsync-active = <0>; + pixelclk-active = <0>; + }; + }; + }; }; /* PWM <A> */ --Quoted 2 lines
2.17.1
--
Best regards - Freundliche Grüsse - Meilleures salutationsIgor Opaniuk
Quoted 8 lines
mailto: igor.opaniuk at gmail.com
skype: igor.opanyuk
+380 (93) 836 40 67
http://ua.linkedin.com/in/iopaniuk
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot
--
Best regards
Oleksandr Suvorov
Toradex AG
Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500 4800 (main line)
PATCH 6/6 configs: colibri-imx6ull: switch to DM_VIDEO
In reply to Igor OpaniukFrom: Igor Opaniuk <[email protected]>
Use CONFIG_DM_VIDEO=y by default for Colibri iMX6ULL.
--- configs/colibri-imx6ull_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
configs/colibri-imx6ull_defconfig +1 -1
@@ -80,6 +80,6 @@ CONFIG_USB_GADGET_VENDOR_NUM=0x1b67 CONFIG_USB_GADGET_PRODUCT_NUM=0x4000 CONFIG_CI_UDC=y CONFIG_USB_GADGET_DOWNLOAD=y -CONFIG_VIDEO=y +CONFIG_DM_VIDEO=y CONFIG_OF_LIBFDT_OVERLAY=y CONFIG_FDT_FIXUP_PARTITIONS=y
Signature · 1 line
2.17.1
PATCH 6/6 configs: colibri-imx6ull: switch to DM_VIDEO
+Oleksandr
Quoted 25 lines · Igor Opaniuk
From: Igor Opaniuk <[email protected]>
Use
CONFIG_DM_VIDEO=yby default for Colibri iMX6ULL.Signed-off-by Igor Opaniuk <[email protected]>--- configs/colibri-imx6ull_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)configs/colibri-imx6ull_defconfig +1
-2@@ -80,6 +80,6 @@ CONFIG_USB_GADGET_VENDOR_NUM=0x1b67 CONFIG_USB_GADGET_PRODUCT_NUM=0x4000 CONFIG_CI_UDC=y CONFIG_USB_GADGET_DOWNLOAD=y -CONFIG_VIDEO=y +CONFIG_DM_VIDEO=y CONFIG_OF_LIBFDT_OVERLAY=y CONFIG_FDT_FIXUP_PARTITIONS=y --2.17.1
Signature · 8 lines
Best regards - Freundliche Grüsse - Meilleures salutations Igor Opaniuk mailto: igor.opaniuk at gmail.com skype: igor.opanyuk +380 (93) 836 40 67 http://ua.linkedin.com/in/iopaniuk
PATCH 6/6 configs: colibri-imx6ull: switch to DM_VIDEO
Quoted 36 lines · Igor Opaniuk
+Oleksandr
Quoted 23 lines · Igor Opaniuk
From: Igor Opaniuk <[email protected]>
Use
CONFIG_DM_VIDEO=yby default for Colibri iMX6ULL.Signed-off-by Igor Opaniuk <[email protected]>--- configs/colibri-imx6ull_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)configs/colibri-imx6ull_defconfig +1
-2@@ -80,6 +80,6 @@ CONFIG_USB_GADGET_VENDOR_NUM=0x1b67 CONFIG_USB_GADGET_PRODUCT_NUM=0x4000 CONFIG_CI_UDC=y CONFIG_USB_GADGET_DOWNLOAD=y -CONFIG_VIDEO=y +CONFIG_DM_VIDEO=y CONFIG_OF_LIBFDT_OVERLAY=y CONFIG_FDT_FIXUP_PARTITIONS=y --Quoted 2 lines
2.17.1
--
Best regards - Freundliche Grüsse - Meilleures salutationsIgor Opaniuk
Quoted 8 lines
mailto: igor.opaniuk at gmail.com
skype: igor.opanyuk
+380 (93) 836 40 67
http://ua.linkedin.com/in/iopaniuk
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot
Signature · 6 lines
Best regards Oleksandr Suvorov Toradex AG Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500 4800 (main line)
cover Enabled DM_VIDEO for Colibri iMX7 NAND/iMX6ULL
In reply to Igor Opaniuk+ Oleksandr
Quoted 32 lines · Igor Opaniuk
From: Igor Opaniuk <[email protected]>
This patch-series fixes some issues in mxsfb fbdev bindings (incorrect structure). Currently there is a support only for old format, new one wil be introduced soon [1].
Also it enables support of
DM_VIDEOfor Colibri iMX7 NAND version and for Colibri iMX6ULL.[1] https://www.kernel.org/doc/Documentation/devicetree/bindings/display/mxsfb.txt
Igor Opaniuk (6):
video: mxsfb: fix mxsfb fbdev binding issues
ARM: dts:colibri_imx7: Fix lcdif node definition
configs:colibri_imx7: enableDM_VIDEO
colibri-imx6ull: support building with DM_VIDEO=y
ARM: dts: colibri-imx6ull: extend lcdif node
configs: colibri-imx6ull: switch toDM_VIDEOarch/arm/dts/imx6ull-colibri.dts | 32 +++++++++++++ arch/arm/dts/imx7-colibri.dtsi | 47 +++++++++++--------- arch/arm/mach-imx/mx6/soc.c | 2 +- configs/colibri-imx6ull_defconfig | 2 +- configs/colibri_imx7_defconfig | 2 +- drivers/video/mxsfb.c | 74 ++++++++++++++++++++++++++----- include/configs/colibri-imx6ull.h | 2 +- 7 files changed, 124 insertions(+), 37 deletions(-)--
2.17.1
Signature · 8 lines
Best regards - Freundliche Grüsse - Meilleures salutations Igor Opaniuk mailto: igor.opaniuk at gmail.com skype: igor.opanyuk +380 (93) 836 40 67 http://ua.linkedin.com/in/iopaniuk
cover Enabled DM_VIDEO for Colibri iMX7 NAND/iMX6ULL
In reply to Igor OpaniukHi Anatolij,
Quoted 29 lines · Igor Opaniuk
From: Igor Opaniuk <[email protected]>
This patch-series fixes some issues in mxsfb fbdev bindings (incorrect structure). Currently there is a support only for old format, new one wil be introduced soon [1].
Also it enables support of
DM_VIDEOfor Colibri iMX7 NAND version and for Colibri iMX6ULL.[1] https://www.kernel.org/doc/Documentation/devicetree/bindings/display/mxsfb.txt
Igor Opaniuk (6):
video: mxsfb: fix mxsfb fbdev binding issues
ARM: dts:colibri_imx7: Fix lcdif node definition
configs:colibri_imx7: enableDM_VIDEO
colibri-imx6ull: support building with DM_VIDEO=y
ARM: dts: colibri-imx6ull: extend lcdif node
configs: colibri-imx6ull: switch toDM_VIDEOarch/arm/dts/imx6ull-colibri.dts | 32 +++++++++++++ arch/arm/dts/imx7-colibri.dtsi | 47 +++++++++++--------- arch/arm/mach-imx/mx6/soc.c | 2 +- configs/colibri-imx6ull_defconfig | 2 +- configs/colibri_imx7_defconfig | 2 +- drivers/video/mxsfb.c | 74 ++++++++++++++++++++++++++----- include/configs/colibri-imx6ull.h | 2 +- 7 files changed, 124 insertions(+), 37 deletions(-)
Quoted 3 lines
--
2.17.1
Are there any objections from your side to get this patch-series applied? Please let me know if you have any comments/suggestions.
Thanks!
Signature · 8 lines
Best regards - Freundliche Grüsse - Meilleures salutations Igor Opaniuk mailto: igor.opaniuk at gmail.com skype: igor.opanyuk +380 (93) 836 40 67 http://ua.linkedin.com/in/iopaniuk
cover Enabled DM_VIDEO for Colibri iMX7 NAND/iMX6ULL
Hi,
Quoted 45 lines · Igor Opaniuk
Hi Anatolij,
Quoted 29 lines · Igor Opaniuk
From: Igor Opaniuk <[email protected]>
This patch-series fixes some issues in mxsfb fbdev bindings (incorrect structure). Currently there is a support only for old format, new one wil be introduced soon [1].
Also it enables support of
DM_VIDEOfor Colibri iMX7 NAND version and for Colibri iMX6ULL.[1] https://www.kernel.org/doc/Documentation/devicetree/bindings/display/mxsfb.txt
Igor Opaniuk (6):
video: mxsfb: fix mxsfb fbdev binding issues
ARM: dts:colibri_imx7: Fix lcdif node definition
configs:colibri_imx7: enableDM_VIDEO
colibri-imx6ull: support building with DM_VIDEO=y
ARM: dts: colibri-imx6ull: extend lcdif node
configs: colibri-imx6ull: switch toDM_VIDEOarch/arm/dts/imx6ull-colibri.dts | 32 +++++++++++++ arch/arm/dts/imx7-colibri.dtsi | 47 +++++++++++--------- arch/arm/mach-imx/mx6/soc.c | 2 +- configs/colibri-imx6ull_defconfig | 2 +- configs/colibri_imx7_defconfig | 2 +- drivers/video/mxsfb.c | 74 ++++++++++++++++++++++++++----- include/configs/colibri-imx6ull.h | 2 +- 7 files changed, 124 insertions(+), 37 deletions(-)Quoted 3 lines
--
2.17.1Are there any objections from your side to get this patch-series applied? Please let me know if you have any comments/suggestions.
Thanks!
--
Best regards - Freundliche Grüsse - Meilleures salutations
Quoted 6 lines
Igor Opaniuk
mailto: igor.opaniuk at gmail.com
skype: igor.opanyuk
+380 (93) 836 40 67
http://ua.linkedin.com/in/iopaniuk
Just a gentle reminder - patches have been sitting in ML for almost 1 month. If anyone has any objections/suggestions, please let me know ( taking into account that MW closes soon, I would like to address all issues/comments
ASAP and get it applied, if there are any)
Thanks
Signature · 8 lines
Best regards - Freundliche Grüsse - Meilleures salutations Igor Opaniuk mailto: igor.opaniuk at gmail.com skype: igor.opanyuk +380 (93) 836 40 67 http://ua.linkedin.com/in/iopaniuk
cover Enabled DM_VIDEO for Colibri iMX7 NAND/iMX6ULL
In reply to Igor OpaniukHi Igor,
On Thu, 11 Jul 2019 13:59:35 +0300
Igor Opaniuk igor.opaniuk at gmail.com wrote:
...
Quoted 2 lines
Are there any objections from your side to get this patch-series applied? Please let me know if you have any comments/suggestions.
Sorry for delay, my build tests passed now. I've queued the series for v2019.10. Thanks!
--
Anatolij
cover Enabled DM_VIDEO for Colibri iMX7 NAND/iMX6ULL
Hi Anatlolij,
Quoted 6 lines · Anatolij Gustschin
Hi Igor,
On Thu, 11 Jul 2019 13:59:35 +0300
Igor Opaniuk igor.opaniuk at gmail.com wrote:
...
Quoted 8 lines
Quoted 2 lines
Are there any objections from your side to get this patch-series applied? Please let me know if you have any comments/suggestions.
Sorry for delay, my build tests passed now. I've queued the series for v2019.10. Thanks!
--
Anatolij
No problem :),
thanks a lot for looking into this and applying the series!
Signature · 8 lines
Best regards - Freundliche Grüsse - Meilleures salutations Igor Opaniuk mailto: igor.opaniuk at gmail.com skype: igor.opanyuk +380 (93) 836 40 67 http://ua.linkedin.com/in/iopaniuk
cover Enabled DM_VIDEO for Colibri iMX7 NAND/iMX6ULL
In reply to Igor OpaniukOn Wed, 19 Jun 2019 11:47:04 +0300
Igor Opaniuk igor.opaniuk at gmail.com wrote:
...
Quoted 8 lines
Igor Opaniuk (6):
video: mxsfb: fix mxsfb fbdev binding issues
ARM: dts:colibri_imx7: Fix lcdif node definition
configs:colibri_imx7: enableDM_VIDEO
colibri-imx6ull: support building with DM_VIDEO=y
ARM: dts: colibri-imx6ull: extend lcdif node
configs: colibri-imx6ull: switch toDM_VIDEO
Quoted 8 lines
arch/arm/dts/imx6ull-colibri.dts | 32 +++++++++++++ arch/arm/dts/imx7-colibri.dtsi | 47 +++++++++++--------- arch/arm/mach-imx/mx6/soc.c | 2 +- configs/colibri-imx6ull_defconfig | 2 +- configs/colibri_imx7_defconfig | 2 +- drivers/video/mxsfb.c | 74 ++++++++++++++++++++++++++----- include/configs/colibri-imx6ull.h | 2 +- 7 files changed, 124 insertions(+), 37 deletions(-)
Applied to u-boot-video/master, thanks!
--
Anatolij