bpf: verifier: add a break statement in switch
Subsystems (4)
PATCH 1/1 bpf: verifier: add a break statement in switch
Notice that in this case, it's much clearer to explicitly add a break rather than letting the code to fall through. It also avoid potential future fall-through warnings[1].
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
[1] https://lore.kernel.org/patchwork/patch/1087056/
--- kernel/bpf/verifier.c | 1 + 1 file changed, 1 insertion(+)
kernel/bpf/verifier.c +1 -0
@@ -6066,6 +6066,7 @@ static int check_return_code(struct bpf_verifier_env *env) range =tnum_range (0 ,3 ); enforce_attach_type_range =tnum_range (2 ,3 ); } +break ;case BPF_PROG_TYPE_CGROUP_SOCK :case BPF_PROG_TYPE_CGROUP_SOCK_ADDR :case BPF_PROG_TYPE_SOCK_OPS :
Signature · 1 line
2.21.0
Quoted 5 lines · Gustavo A. R. Silva
Notice that in this case, it's much clearer to explicitly add a break rather than letting the code to fall through. It also avoid potential future fall-through warnings[1].
Quoted 7 lines
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
[1] https://lore.kernel.org/patchwork/patch/1087056/
Signed-off-by Gustavo A. R. Silva <[email protected]>---
Quoted 18 lines
kernel/bpf/verifier.c | 1 + 1 file changed, 1 insertion(+)kernel/bpf/verifier.c +1
-1@@ -6066,6 +6066,7 @@ static int check_return_code(struct bpf_verifier_env *env) range =tnum_range (0 ,3 ); enforce_attach_type_range =tnum_range (2 ,3 ); } +break ;case BPF_PROG_TYPE_CGROUP_SOCK :case BPF_PROG_TYPE_CGROUP_SOCK_ADDR :case BPF_PROG_TYPE_SOCK_OPS : --2.21.0
Quoted 10 lines · Andrii Nakryiko
Quoted 8 lines · Gustavo A. R. Silva
Notice that in this case, it's much clearer to explicitly add a break rather than letting the code to fall through. It also avoid potential future fall-through warnings[1].
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Quoted 7 lines
Quoted 4 lines
[1] https://lore.kernel.org/patchwork/patch/1087056/
Signed-off-by Gustavo A. R. Silva <[email protected]>---
Acked-by Andrii Nakryiko <[email protected]>
Thanks, Andrii.
--
Gustavo