drm/msm/dsi: Add parentheses to quirks check in dsi_phy_hw_v3_0_lane_settings
PATCH 1/1 drm/msm/dsi: Add parentheses to quirks check in dsi_phy_hw_v3_0_lane_settings
Clang warns:
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c:80:6: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses]
if (!phy->cfg->quirks & V3_0_0_10NM_OLD_TIMINGS_QUIRK) {
^ ~
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c:80:6: note: add parentheses
after the '!' to evaluate the bitwise operator first
if (!phy->cfg->quirks & V3_0_0_10NM_OLD_TIMINGS_QUIRK) {
^
( )
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c:80:6: note: add parentheses
around left hand side expression to silence this warning
if (!phy->cfg->quirks & V3_0_0_10NM_OLD_TIMINGS_QUIRK) {
^
( )1 warning generated.
Add parentheses around the bitwise AND so it is evaluated first then negated.
--- drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c +1 -1
@@ -77,7 +77,7 @@ static void dsi_phy_hw_v3_0_lane_settings(struct msm_dsi_phy *phy) tx_dctrl[i]); } -if (!phy->cfg->quirks &V3_0_0_10NM_OLD_TIMINGS_QUIRK ) { +if (!(phy->cfg->quirks &V3_0_0_10NM_OLD_TIMINGS_QUIRK )) {/* Toggle BIT 0 to release freeze I/0 */ dsi_phy_write (lane_base +REG_DSI_10nm_PHY_LN_TX_DCTRL (3 ),0x05 );dsi_phy_write (lane_base +REG_DSI_10nm_PHY_LN_TX_DCTRL (3 ),0x04 );
Signature · 1 line
2.22.0
Quoted 18 lines · Nathan Chancellor
Clang warns:
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c:80:6: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses]if (!phy->cfg->quirks & V3_0_0_10NM_OLD_TIMINGS_QUIRK) { ^ ~ drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c:80:6: note: add parentheses after the '!' to evaluate the bitwise operator first if (!phy->cfg->quirks & V3_0_0_10NM_OLD_TIMINGS_QUIRK) { ^ ( ) drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c:80:6: note: add parentheses around left hand side expression to silence this warning if (!phy->cfg->quirks & V3_0_0_10NM_OLD_TIMINGS_QUIRK) { ^ ( )
Quoted 7 lines
1 warning generated.
Add parentheses around the bitwise AND so it is evaluated first then negated.
Fixes 3dbbf8f09e83 ("drm/msm/dsi: Add old timings quirk for 10nm phy")
This link is broken, could you please fix it up?
The rest is:
Quoted 21 lines
Reported-by kbuild test robot <[email protected]>Reviewed-by Jeffrey Hugo <[email protected]>Signed-off-by Nathan Chancellor <[email protected]>--- drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c +1
-2@@ -77,7 +77,7 @@ static void dsi_phy_hw_v3_0_lane_settings(struct msm_dsi_phy *phy) tx_dctrl[i]); } -if (!phy->cfg->quirks &V3_0_0_10NM_OLD_TIMINGS_QUIRK ) { +if (!(phy->cfg->quirks &V3_0_0_10NM_OLD_TIMINGS_QUIRK )) {/* Toggle BIT 0 to release freeze I/0 */ dsi_phy_write (lane_base +REG_DSI_10nm_PHY_LN_TX_DCTRL (3 ),0x05 );dsi_phy_write (lane_base +REG_DSI_10nm_PHY_LN_TX_DCTRL (3 ),0x04 ); --
Quoted 2 lines
2.22.0
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno
Quoted 22 lines · Sean Paul
Quoted 20 lines · Nathan Chancellor
Clang warns:
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c:80:6: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses]if (!phy->cfg->quirks & V3_0_0_10NM_OLD_TIMINGS_QUIRK) { ^ ~ drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c:80:6: note: add parentheses after the '!' to evaluate the bitwise operator first if (!phy->cfg->quirks & V3_0_0_10NM_OLD_TIMINGS_QUIRK) { ^ ( ) drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c:80:6: note: add parentheses around left hand side expression to silence this warning if (!phy->cfg->quirks & V3_0_0_10NM_OLD_TIMINGS_QUIRK) { ^ ( )1 warning generated.
Quoted 7 lines
Quoted 5 lines
Add parentheses around the bitwise AND so it is evaluated first then negated.
Fixes 3dbbf8f09e83 ("drm/msm/dsi: Add old timings quirk for 10nm phy")This link is broken, could you please fix it up?
Thanks for catching this, v2 on the way.
Cheers,
Nathan
Quoted 21 lines
The rest is:
Reviewed-by Sean Paul <[email protected]>Quoted 15 lines
Reported-by kbuild test robot <[email protected]>Reviewed-by Jeffrey Hugo <[email protected]>Signed-off-by Nathan Chancellor <[email protected]>--- drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c +0
-0@@ -77,7 +77,7 @@ static void dsi_phy_hw_v3_0_lane_settings(struct msm_dsi_phy *phy) tx_dctrl[i]); }
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c +1
-2-if (!phy->cfg->quirks &V3_0_0_10NM_OLD_TIMINGS_QUIRK ) { +if (!(phy->cfg->quirks &V3_0_0_10NM_OLD_TIMINGS_QUIRK )) {/* Toggle BIT 0 to release freeze I/0 */ dsi_phy_write (lane_base +REG_DSI_10nm_PHY_LN_TX_DCTRL (3 ),0x05 );dsi_phy_write (lane_base +REG_DSI_10nm_PHY_LN_TX_DCTRL (3 ),0x04 ); --2.22.0
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno
PATCH v2 1/1 drm/msm/dsi: Add parentheses to quirks check in dsi_phy_hw_v3_0_lane_settings
In reply to Nathan ChancellorClang warns:
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c:80:6: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses]
if (!phy->cfg->quirks & V3_0_0_10NM_OLD_TIMINGS_QUIRK) {
^ ~
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c:80:6: note: add parentheses
after the '!' to evaluate the bitwise operator first
if (!phy->cfg->quirks & V3_0_0_10NM_OLD_TIMINGS_QUIRK) {
^
( )
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c:80:6: note: add parentheses
around left hand side expression to silence this warning
if (!phy->cfg->quirks & V3_0_0_10NM_OLD_TIMINGS_QUIRK) {
^
( )1 warning generated.
Add parentheses around the bitwise AND so it is evaluated first then negated.
---
v1 -> v2:
* Fix broken link (thanks to Sean for pointing it out)
* Add Sean's reviewed-by
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c +1 -1
@@ -77,7 +77,7 @@ static void dsi_phy_hw_v3_0_lane_settings(struct msm_dsi_phy *phy) tx_dctrl[i]); } -if (!phy->cfg->quirks &V3_0_0_10NM_OLD_TIMINGS_QUIRK ) { +if (!(phy->cfg->quirks &V3_0_0_10NM_OLD_TIMINGS_QUIRK )) {/* Toggle BIT 0 to release freeze I/0 */ dsi_phy_write (lane_base +REG_DSI_10nm_PHY_LN_TX_DCTRL (3 ),0x05 );dsi_phy_write (lane_base +REG_DSI_10nm_PHY_LN_TX_DCTRL (3 ),0x04 );
Signature · 6 lines
2.22.0 _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno
Sean Paul
reviewerQuoted 17 lines · Nathan Chancellor
Clang warns:
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c:80:6: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses]if (!phy->cfg->quirks & V3_0_0_10NM_OLD_TIMINGS_QUIRK) { ^ ~ drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c:80:6: note: add parentheses after the '!' to evaluate the bitwise operator first if (!phy->cfg->quirks & V3_0_0_10NM_OLD_TIMINGS_QUIRK) { ^ ( ) drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c:80:6: note: add parentheses around left hand side expression to silence this warning if (!phy->cfg->quirks & V3_0_0_10NM_OLD_TIMINGS_QUIRK) { ^ ( )
Quoted 6 lines
1 warning generated.
Add parentheses around the bitwise AND so it is evaluated first then negated.
Fixes 3dbbf8f09e83 ("drm/msm/dsi: Add old timings quirk for 10nm phy")
Hmm, so it looks like this patch isn't upstream. What tree are you basing this on?
Sean
Quoted 31 lines
Reported-by kbuild test robot <[email protected]>Reviewed-by Jeffrey Hugo <[email protected]>Reviewed-by Sean Paul <[email protected]>Signed-off-by Nathan Chancellor <[email protected]>---
v1 -> v2:
* Fix broken link (thanks to Sean for pointing it out)
* Add Sean's reviewed-bydrivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c +1
-1@@ -77,7 +77,7 @@ static void dsi_phy_hw_v3_0_lane_settings(struct msm_dsi_phy *phy) tx_dctrl[i]); } -if (!phy->cfg->quirks &V3_0_0_10NM_OLD_TIMINGS_QUIRK ) { +if (!(phy->cfg->quirks &V3_0_0_10NM_OLD_TIMINGS_QUIRK )) {/* Toggle BIT 0 to release freeze I/0 */ dsi_phy_write (lane_base +REG_DSI_10nm_PHY_LN_TX_DCTRL (3 ),0x05 );dsi_phy_write (lane_base +REG_DSI_10nm_PHY_LN_TX_DCTRL (3 ),0x04 );Signature · 1 line
2.22.0
Signature · 1 line
Sean Paul, Software Engineer, Google / Chromium OS
Quoted 21 lines · Sean Paul
Quoted 19 lines · Nathan Chancellor
Clang warns:
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c:80:6: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses]if (!phy->cfg->quirks & V3_0_0_10NM_OLD_TIMINGS_QUIRK) { ^ ~ drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c:80:6: note: add parentheses after the '!' to evaluate the bitwise operator first if (!phy->cfg->quirks & V3_0_0_10NM_OLD_TIMINGS_QUIRK) { ^ ( ) drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c:80:6: note: add parentheses around left hand side expression to silence this warning if (!phy->cfg->quirks & V3_0_0_10NM_OLD_TIMINGS_QUIRK) { ^ ( )1 warning generated.
Quoted 7 lines
Quoted 4 lines
Add parentheses around the bitwise AND so it is evaluated first then negated.
Fixes 3dbbf8f09e83 ("drm/msm/dsi: Add old timings quirk for 10nm phy")Hmm, so it looks like this patch isn't upstream. What tree are you basing this on?
it is in msm-next-staging.. (which will be pushed to msm-next after some testing)
I've pulled Nathan's patch in on top..
BR,
-R
Quoted 37 lines
Sean
Quoted 29 lines
Reported-by kbuild test robot <[email protected]>Reviewed-by Jeffrey Hugo <[email protected]>Reviewed-by Sean Paul <[email protected]>Signed-off-by Nathan Chancellor <[email protected]>---
v1 -> v2:
* Fix broken link (thanks to Sean for pointing it out)
* Add Sean's reviewed-bydrivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c +1
-2@@ -77,7 +77,7 @@ static void dsi_phy_hw_v3_0_lane_settings(struct msm_dsi_phy *phy) tx_dctrl[i]); } -if (!phy->cfg->quirks &V3_0_0_10NM_OLD_TIMINGS_QUIRK ) { +if (!(phy->cfg->quirks &V3_0_0_10NM_OLD_TIMINGS_QUIRK )) {/* Toggle BIT 0 to release freeze I/0 */ dsi_phy_write (lane_base +REG_DSI_10nm_PHY_LN_TX_DCTRL (3 ),0x05 );dsi_phy_write (lane_base +REG_DSI_10nm_PHY_LN_TX_DCTRL (3 ),0x04 ); --Quoted 2 lines
2.22.0
--
Sean Paul, Software Engineer, Google / Chromium OS