drm/edid: use for_each_displayid_db where applicable
Subsystems (2)
PATCH 1/1 drm/edid: use for_each_displayid_db where applicable
Replace the duplicated versions of the while loop with the new macro.
Signed-off-by Andres Rodriguez <[email protected]>
Cc Dave Airlie <[email protected]>
---
This patch depends on "drm/edid: parse CEA blocks embedded in DisplayID"
I didn't send them together to avoid grouping the portion that was cc:stable and the "touch ups" into the same series.
drivers/gpu/drm/drm_edid.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)
drivers/gpu/drm/drm_edid.c +2 -10
@@ -4730,11 +4730,7 @@ static int add_displayid_detailed_modes(struct drm_connector *connector,return 0 ; idx +=sizeof (struct displayid_hdr ); -while (block = (struct displayid_block *)&displayid[idx], - idx +sizeof (struct displayid_block ) <= length && - idx +sizeof (struct displayid_block ) + block->num_bytes <= length && - block->num_bytes >0 ) { - idx += block->num_bytes +sizeof (struct displayid_block ); +for_each_displayid_db (displayid, block, idx, length) {switch (block->tag) {case DATA_BLOCK_TYPE_1_DETAILED_TIMING : num_modes +=add_displayid_detailed_1_modes (connector, block);
@@ -5279,11 +5275,7 @@ static int drm_parse_display_id(struct drm_connector *connector,return ret; idx +=sizeof (struct displayid_hdr ); -while (block = (struct displayid_block *)&displayid[idx], - idx +sizeof (struct displayid_block ) <= length && - idx +sizeof (struct displayid_block ) + block->num_bytes <= length && - block->num_bytes >0 ) { - idx += block->num_bytes +sizeof (struct displayid_block ); +for_each_displayid_db (displayid, block, idx, length) {DRM_DEBUG_KMS ("block id 0x%x, rev %d, len %d\n" , block->tag, block->rev, block->num_bytes);
Signature · 6 lines
2.19.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel